Modify ↓
Attachments (2)
Change History (8)
by , 4 weeks ago
| Attachment: | 24950.patch added |
|---|
comment:1 by , 2 weeks ago
| Summary: | Refactoring: Created a constant for the literal "WMS Error" → [patch] Fix Sonar issues in AddImageryLayerAction |
|---|
comment:2 by , 2 weeks ago
| Milestone: | → 26.09 |
|---|---|
| Owner: | changed from to |
| Status: | new → needinfo |
That doesn't work. tr() must surround the text or it wont be detected as translatable string
- So either marktr() around the text assignment and tr() around the usage or
- tr() in the assignment and use the text without tr() when it is ensured to be initialized after the I18n framework.
Or move the string into the functions and use tr() there.
Probably the easiest solution here is usage of marktr().
by , 2 weeks ago
| Attachment: | 24950.2.patch added |
|---|
comment:3 by , 2 weeks ago
Thanks for pointing that out. I had overlooked the translation logic, unfortunately. It should be correct again now.
comment:4 by , 2 weeks ago
| Status: | needinfo → new |
|---|
comment:6 by , 2 weeks ago
Now you forget the import. Added it. Nowadays I use KI to additionally review the provided patches in the hope it catches issues I overlook and it also didn't catch this fact. So you're not alone. :-)
Anyway you provided me with a patch where I started the AI review with the question in mind "will it catch this". Worth it.
Note:
See TracTickets
for help on using tickets.
The recurring string 'WMS Error' has been defined as a constant. Furthermore, curly braces have been added to control structures, and fields and variables have been declared as "final".