support amenity=lounger [PATCH]

[mkoniecz]

What steps will reproduce the problem?

1. create node
2. add amenity=lounger to it

What is the expected result?

It has an icon

What happens instead?

Nothing

Please provide any additional information below. Attach a screenshot if possible.

It is in iD presets (that is how I found it, I have also some similar candidates and I can create tickets/patches if that would be welcome) - see ​https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/amenity/lounger.json

iD presets have decent icon, using ​https://rapideditor.github.io/temaki/docs/#icon-temaki-lounger which maybe can be reused

has decent usage, 16k - see ​https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dlounger

I would add that preset for nodes only, like iD does

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2026-05-22 07:49:37 +0200 (Fri, 22 May 2026)
Revision:19575
Build-Date:2026-05-23 01:30:44
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19575 en) Linux Ubuntu 24.04.4 LTS
Memory Usage: 1148 MB / 7996 MB (127 MB allocated, but free)
Java version: 21.0.10+7-Ubuntu-124.04, Ubuntu, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920x1200x[Multi depth]@60Hz (scaling 1.00×1.00) :0.1 1920x1200x[Multi depth]@60Hz (scaling 1.00×1.00)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: LXQt
Java package: openjdk-21-jre:amd64-21.0.10+7-1~24.04
Java ATK Wrapper package: libatk-wrapper-java:all-0.40.0-3build2
libcommons-compress-java: libcommons-compress-java:all-1.25.0-1
libcommons-logging-java: libcommons-logging-java:all-1.3.0-1ubuntu1
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ todo (159)

Last errors/warnings:
- 00003.265 W: Update plugins - You updated your JOSM software. To prevent problems the plugins should be updated as well.  Update plugins now?
- 00055.950 W: java.net.SocketTimeoutException: Connect timed out
- 00060.592 W: java.net.SocketTimeoutException: Connect timed out
- 00060.595 E: java.net.SocketTimeoutException: Connect timed out
- 00060.612 E: org.openstreetmap.josm.io.OsmTransferException: Could not connect to the OSM server. Please check your internet connection.. Cause: java.net.SocketTimeoutException: Connect timed out
- 00060.631 E: IO Exception - <html>Failed to upload data to or download data from<br>'https://api.openstreetmap.org/api/0.6/map?bbox=19.8952103,49.8586814,19.9249077,49.8861187'<br>due to a problem with transferring data.<br>Details (untranslated): Connect timed out</html>
- 00211.908 W: Region [WMS_BLOCK_v2] : Problem verifying disk.

[mkoniecz]

Disclaimers: I am co-maintainer of ​https://github.com/openstreetmap/id-tagging-schema and received in past funding enabling me to work on it.

[gaben]

Hopefully I can dig into the tickets starting next week :)

[mkoniecz]

would it be helpful for me to provide a patch?

[stoecker]

Yes.

[mkoniecz]

I found https://josm.openstreetmap.de/changeset/14959/josm but it is quite old.

https://josm.openstreetmap.de/changeset/19026/josm is a more recent one

I will try to make something

[mkoniecz]

I also found ​https://github.com/JOSM/josm - I faintly remember editing on clone of it, and generating patch file. Hopefully it is still acceptable...

I will try to make a patch.

[mkoniecz]

I cloned ​https://github.com/JOSM/josm putting it into
/home/mateusz/Documents/install_moje/OSM_software/josm/

I modified presets to add support to amenity=lounger (patch attached)

I set Map Paint Style to point to
/home/mateusz/Documents/install_moje/OSM_software/josm/resources/styles/standard/elemstyles.mapcss
activated it and deactivated stock one

I set Tagging Presets to point to
/home/mateusz/Documents/install_moje/OSM_software/josm/resources/data/defaultpresets.xml
activated them and deactivated stock one

I added extra icon path setting it to
/home/mateusz/Documents/install_moje/OSM_software/josm/resources/images

I made a patching attempt (see file)

I no longer see complaints at JOSM boot (previously it was complaining about missing icon, it went away after setting an extra icon path in settings)

---

but something is wrong: I do not see any effect of my changes (no icon visible in JOSM, no autocompletion, even error in logs went away)

I will look at it again but if anyone has a good idea what I should check or see an obvious problem in my patch...

[stoecker]

In 19626/josm:

add amenity=lounger, patch by mkoniecz, fix #24740

[stoecker]

Seems your test environment has some issues, although on first view it looks good to me.

[gaben]

It works for me as well. Two things I see:

• the icon is solid white and barely visible on the Tags/Memberships panel with the default Java LaF on Linux
• optional attributes are missing (material, colour is nice IMO)

[mkoniecz]

the icon is solid white and barely visible on the Tags/Memberships panel with the default Java LaF on Linux

maybe black-white mix like bench has would be better?

I am really confused why my JOSM install hates me, I guess I will try to change something

[mkoniecz]

It works for me as well

OK, that it is first time for "it works on my computer" happening for my code in reverse direction than usually.

[mkoniecz]

Seems your test environment has some issues

well, it is just JOSM configured to read preset files from local repo
I was not expecting that it can be misconfigured

confusing other parts of preset work? I would be less confused if mappaint /icons / presets would be completely broken

[skyper]

Yes, most of the time, finding/creating proper icons is the most time-consuming part. With the different LaFs and backgrounds in MapView in mind, you need at least one contrasting background colour. See for example #20270.

I would add that preset for nodes only, like iD does

It is quite strange. The approved proposal only allowed it for nodes but the very first wiki page allowed it for nodes, ways and areas and it was never changed. Most of the projects supporting this tag allow all object types.
The new patch 24740.patch​ now adds ways but not areas.
Can we sort this out, please.

EDIT: add link to patch

[mkoniecz]

Out of 18 249 uses only 221 are not nodes...

Also, for this type of object nodes really really make more sense.

I think that wiki should be updated instead.

The new patch now adds ways but not areas.

https://josm.openstreetmap.de/changeset/19626/josm seems to add only nodes? Or do you mean some other patch?

With the different LaFs and backgrounds in MapView in mind, you need at least one contrasting background colour.

I agree, I was kind of surprised it got merged but I will try to provide also an updated icon

[mkoniecz]

Seems your test environment has some issues

turns out icons were not showing up on map because custom icon path config was not saved (assuming PEBKAC)

[skyper]

Replying to mkoniecz:

Out of 18 249 uses only 221 are not nodes...

I have no time to deeper investigate and this is the wrong place to dive into.

Also, for this type of object nodes really really make more sense.

I thought the same about benches until I found a bench as circle around a tree and needed a way to properly map it. For long and possibly curved benches and loungers, I understand why some mappers prefer to use a way.

I would say areas do not make sense but, yet again, they map hedges as areas in the Netherlands.

For me, one strength of JOSM is that it is not that restrictive.

The new patch now adds ways but not areas.

https://josm.openstreetmap.de/changeset/19626/josm seems to add only nodes? Or do you mean some other patch?

Another patch, 24740.patch​, sorry, I have updated my comment.
I think, Gabe already fixed most of the issues.

[mkoniecz]

I think, Gabe already fixed most of the issues.

except - maybe - supporting mapping those as areas, right?