[PATCH] "area=yes is unnecessary for amenity" doesn't apply to benches, which can be tagged as areas or loops

[mistenman]

The "Unnecessary tags" validator ruleset emits a warning "area=yes is unnecessary for amenity" for way:closed[amenity][area?][!highway]. This doesn't make sense for amenity=benches, which can be mapped as closed non-area ways when they form a long continuous loop, or as closed area ways, when they're a large platform people can sit on. I suggest we exclude amenity=bench from this unnecessary tag warning, and add a new validator rule for way:closed[amenity=bench][area!=yes][area!=no] that warns "amenity=bench on a closed way is ambiguous. Specify area=yes for a seating platform area or area=no for a linear bench loop". I've attached a patch to this effect.

I can see amenity=bicycle_parking facing the same issue, but I think mapping them as closed non-area ways is uncommon.

[mistenman]

Adds new rule to geometry.mapcss for way:closed[amenity=bench][area!=yes][area!=no] and exludes amenity=bench from the way:closed[amenity][area?][!highway] warning in unnecessary.mapcss

[anonymous]

Thanks for the patch
Unfortunately, fixing validator is only solving half of the problems. The preset should be adjusted along side and first of all allow areas (closed ways) and a checkbox for area should be added. #23694 could be fixed along side as well.

skyper (who is denied to login (429)).

[mistenman]

I see, then I'll adjust the preset and send patch v2 here within a few hours.

[stoecker]

skyper (who is denied to login (429)).

Ooops. Login should not have been blocked (but it starts with log :-) Try again.

P.S. A newer browser will REALLY help! There are at least 5 later version of Firefox.

[skyper]

Replying to stoecker:

skyper (who is denied to login (429)).

Ooops. Login should not have been blocked (but it starts with log :-) Try again.

Thanks, works again.

P.S. A newer browser will REALLY help! There are at least 5 later version of Firefox.

Sorry, my browser is fully up to date. Do not trust the main version as debian adds a lot of patches to the lts version. The main version does not change but the trailing numbers are important. Anyway thanks for the tip, I will try to work around it.

[skyper]

Replying to mistenman:

I see, then I'll adjust the preset and send patch v2 here within a few hours.

Thanks for your understanding.
I believe josm is in the stabilization phase, atm, as a new stable release (milestone:26.09) will be released soon. So it will take a few days up to a week until new patches will be committed unless it is a hot fix for a regression.

After another glance at taginfo maybe direction=* (like advertising board) and checkboxes for lit and covered could be added as optional if the preset is updated.