Modify

Opened 8 months ago

Closed 8 months ago

#23596 closed enhancement (fixed)

[Patch] name=Bâtiment (French for "building"), especially on buildings, is suspicious and worth flagging by validator

Reported by: mkoniecz Owned by: GerdP
Priority: normal Milestone: 24.03
Component: Core validator Version:
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. create way
  2. put name=Bâtiment tag on it
  3. put building=yes tag on it
  4. run validator

What is the expected result?

Validator complains about suspicious name

What happens instead?

Nothing

Please provide any additional information below. Attach a screenshot if possible.

name=bâtiment name=Bâtiment name=batiment name=Batiment are known variants

see http://overpass-turbo.eu/s/1JrK (recent additions, over 1200 since 2024-03-01)

see http://overpass-turbo.eu/s/1JrM (over 2500 in total)

and yes, it is responsibility of HOT and project creators to ensure that this kind of data is cleaned - I am also working on contacting them

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2024-04-02 21:41:08 +0200 (Tue, 02 Apr 2024)
Revision:19026
Build-Date:2024-04-03 01:31:00
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (19026 en) Linux Ubuntu 20.04.6 LTS
Memory Usage: 452 MB / 3970 MB (257 MB allocated, but free)
Java version: 17.0.10+7-Ubuntu-120.04.1, Private Build, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 1920×1200 (scaling 1.00×1.00) :0.1 1920×1200 (scaling 1.00×1.00)
Maximum Screen Size: 1920×1200
Best cursor sizes: 16×16→16×16, 32×32→32×32
Environment variable LANG: en_US.UTF-8
System property file.encoding: UTF-8
System property sun.jnu.encoding: UTF-8
Locale info: en_US
Numbers with default locale: 1234567890 -> 1234567890
Desktop environment: LXQt
Java package: openjdk-17-jre:amd64-17.0.10+7-1~20.04.1
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Plugins:
+ buildings_tools (36226)
+ measurement (36200)
+ reverter (36233)
+ todo (137)

Map paint styles:
+ ${HOME}/Desktop/tmp/josm/resources/styles/standard/elemstyles.mapcss
- https://josm.openstreetmap.de/josmfile?page=Styles/Fixme&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/LessObtrusiveNodes&zip=1

Validator rules:
+ https://josm.openstreetmap.de/josmfile?page=Rules/OSMLint&zip=1
- ${HOME}/Documents/install_moje/OSM software/manual editing and discussions/josm/resources/data/validator/deprecated.mapcss
+ ${HOME}/Desktop/tmp/josm/resources/data/validator/combinations.mapcss

Last errors/warnings:
- 00019.884 E: java.nio.file.NoSuchFileException: ${HOME}/Desktop/tmp/josm/resources/styles/standard/elemstyles.mapcss
- 00019.886 E: java.nio.file.NoSuchFileException: ${HOME}/Desktop/tmp/josm/resources/styles/standard
- 00019.887 W: Initializing map style ${HOME}/Desktop/tmp/josm/resources/styles/standard/elemstyles.mapcss completed in 5 ms (1 errors, 0 warnings)
- 00022.953 W: Failed to add ${HOME}/Desktop/tmp/josm/resources/data/validator/combinations.mapcss to tag checker
- 00022.953 W: java.nio.file.NoSuchFileException: ${HOME}/Desktop/tmp/josm/resources/data/validator/combinations.mapcss
- 00022.965 E: Invalid line in resource://data/validator/ignoretags.cfg : 'NHD:GNIS_ID' does not contain '='
- 00022.965 E: Invalid line in resource://data/validator/ignoretags.cfg : 'gnis:id' does not contain '='
- 00022.967 E: Invalid line in resource://data/validator/ignoretags.cfg : 'nhd:gnis_id' does not contain '='
- 00022.967 E: Invalid line in resource://data/validator/ignoretags.cfg : 'ref:gnis' does not contain '='
- 00022.968 E: Invalid line in resource://data/validator/ignoretags.cfg : 'tiger:PLACENS' does not contain '='

Attachments (2)

hot.png (142.2 KB ) - added by mkoniecz 8 months ago.
23596.patch (1.2 KB ) - added by GerdP 8 months ago.

Download all attachments as: .zip

Change History (6)

by mkoniecz, 8 months ago

Attachment: hot.png added

comment:1 by mkoniecz, 8 months ago

See at least #17633 #17100 #17629 for similar tickets.

by GerdP, 8 months ago

Attachment: 23596.patch added

comment:2 by GerdP, 8 months ago

Milestone: 24.03
Owner: changed from team to GerdP
Status: newassigned
Summary: name=Bâtiment (French for "building"), especially on buildings, is suspicious and worth flagging by validator[Patch] name=Bâtiment (French for "building"), especially on buildings, is suspicious and worth flagging by validator

With the patch you'll see this warning
descriptive name - name=Bâtiment (1)

OK?

comment:3 by mkoniecz, 8 months ago

seems like a good idea, and if it needs tweaking then it can be tweaked in general for all entries reported here

comment:4 by GerdP, 8 months ago

Resolution: fixed
Status: assignedclosed

In 19028/josm:

fix #23596: name=Bâtiment (French for "building"), especially on buildings, is suspicious and worth flagging by validator

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain GerdP.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.