Modify

Opened 6 months ago

Closed 6 months ago

Last modified 5 months ago

#17633 closed enhancement (fixed)

complain about even more descriptive names and propose to delete them [PATCH]

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 19.05
Component: Core validator Version:
Keywords: name Cc:

Description (last modified by mkoniecz)

Patch at https://josm.openstreetmap.de/ticket/17633#comment:19

Updated list of suspicious names used more than 2000 times to check:

Please provide any additional information below. Attach a screenshot if possible.

http://overpass-turbo.eu/s/I7p http://overpass-turbo.eu/s/I7r http://overpass-turbo.eu/s/I7t

Next part of https://josm.openstreetmap.de/ticket/17100 and https://josm.openstreetmap.de/ticket/17629

To be added in https://josm.openstreetmap.de/browser/josm/trunk/data/validator/unnecessary.mapcss#L93

Many were matched in https://josm.openstreetmap.de/changeset/15005/josm but some still remain

Attachments (0)

Change History (23)

comment:1 Changed 6 months ago by mkoniecz

For name=Path: highway=path dominates, but I plan on matching also relatively rare highway=footway and highway=cycleway to do not encourage people to keep name and switch to highway=footway.

comment:2 Changed 6 months ago by mkoniecz

For name=School that for some bizarre reason is on large scale used in countries without English used as a local language (probably ow quality HOT edits were the reason) should be matched and removed on amenity=school, building=school and get warnings on building=*.

comment:3 Changed 6 months ago by mkoniecz

Description: modified (diff)

comment:4 Changed 6 months ago by mkoniecz

Description: modified (diff)

comment:5 Changed 6 months ago by mkoniecz

Description: modified (diff)

comment:6 Changed 6 months ago by mkoniecz

Description: modified (diff)

comment:7 Changed 6 months ago by mkoniecz

Description: modified (diff)

comment:8 Changed 6 months ago by mkoniecz

Description: modified (diff)

comment:9 Changed 6 months ago by mkoniecz

Whops, many of them were already added in https://josm.openstreetmap.de/changeset/15005/josm

comment:10 Changed 6 months ago by mkoniecz

Description: modified (diff)

comment:11 Changed 6 months ago by mkoniecz

Description: modified (diff)

comment:12 Changed 6 months ago by mkoniecz

Description: modified (diff)

comment:13 Changed 6 months ago by Don-vip

Yep sorry I didn't mention my analysis:

​casa: 4902 "houses" in Spanish? > added for building=house
​Markt: 3960 "markets" in German? > not added, appears for streets, not markets
​Аптека: 3824 pharmacies in Russian > added for amenity=pharmacy
​Bahnhof: 2872 "railway stations" in German? > not added, appears for streets and some buildings where railway=station is not set
​Plebania: 2794 "presbitaries" in Polish? > not added, we should check with Polish community
​Kancelaria: 2757 "offices" in Polish? > not added, we should check with Polish community
​Столовая: 2648 "canteens" in Russian? > not added, there is no osm tag for "canteen" I think
​School: 2550 schools? > added for amenity=school
​مسجد: 2445 "mosques" in Persian? - yes, see ​https://fa.wikipedia.org/wiki/%D9%85%D8%B3%D8%AC%D8%AF > added
​Школа: 2436 "schools" in Russian? - yes, it should be treated like name=school > added
​.: 2429 WTF? > I didn't check yet
​Calvaire: 2223 calvaries in French > not sure. wayside cross does not have exactly the same meaning, so I didn't add it
​Park: "" in ? > appears to have a lot of locations named "Park"
​Siedlung: 2188 "settlements" in German? > same, so I didn't add it

comment:14 Changed 6 months ago by mkoniecz

​Park: "" in ? > appears to have a lot of locations named "Park"

1400 leisure=park name=Park seems to be a legit validator targets - http://overpass-turbo.eu/s/I92

​Plebania: 2794 "presbitaries" in Polish? > not added, we should check with Polish community

This is on a border of descriptive name and real name. Given that removal of blatant descriptive names is controversial for some I would not introduce this check (as may be obvious from my stream of issues/patches related to descriptive names I strongly dislike them, but I would hesitate here)

​Kancelaria: 2757 "offices" in Polish? > not added, we should check with Polish community

This is probably mostly for parish offices. The same situation as with plebania. I would not do anything for now and revisit it after blatant descriptive names are purged. I would not remove it manually in my usual editing.

.

Dot as name probably makes no sense at all, but it is not a descriptive name. I would give it a separate check.

​Siedlung

Not sure here what should be done with it, unfamiliar with meaning here.

Last edited 6 months ago by mkoniecz (previous) (diff)

comment:15 Changed 6 months ago by mkoniecz

Overall, I would add rules for

leisure=park name=Park - 1400 cases, ​http://overpass-turbo.eu/s/I92

name=. but as a separate rule (suspicious tags?)

There is also about 200-300 cases of name=School on buildings without amenity=school, it may be worth adding rule for that - http://overpass-turbo.eu/s/I95

comment:16 Changed 6 months ago by mkoniecz

Last edited 6 months ago by mkoniecz (previous) (diff)

comment:17 Changed 6 months ago by mkoniecz

Description: modified (diff)
Summary: complain about even more descriptive names and propose to delete themcomplain about even more descriptive names and propose to delete them [PATCH]

comment:18 Changed 6 months ago by Don-vip

two remarks:

  • for building=school, please use the same values (french, russian) that defined for amenity=school
  • adding school to building!=house condition looks wrong

comment:19 Changed 6 months ago by mkoniecz

comment:20 Changed 6 months ago by mkoniecz

Description: modified (diff)

comment:21 Changed 6 months ago by Don-vip

Keywords: name added
Milestone: 19.05

comment:22 Changed 6 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 15044/josm:

fix #17633 - complain about even more descriptive names (patch by mkoniecz, modified)

comment:23 Changed 5 months ago by Klumbumbus

In 15061/josm:

  • fix #17693 - render tunnel=flooded like tunnel=culvert
  • see #17633 - combine validator rules

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.