Modify

Opened 4 weeks ago

Closed 4 weeks ago

Last modified 2 weeks ago

#17634 closed enhancement (fixed)

Reject uploads that do not follow comment/source upload policy

Reported by: Don-vip Owned by: Don-vip
Priority: normal Milestone: 19.04
Component: Core Version:
Keywords: upload comment source policy terms Cc:

Description

On the same way we warn users when they try to upload without specifying a comment or a source, it might be useful to reject uploads for which the comment or source does not follow a configurable policy (for example, absence of mandatory terms or presence of forbidden terms).

Attachments (2)

forbidden.png (10.7 KB) - added by Don-vip 4 weeks ago.
required.png (10.3 KB) - added by Don-vip 4 weeks ago.

Download all attachments as: .zip

Change History (17)

Changed 4 weeks ago by Don-vip

Attachment: forbidden.png added

Changed 4 weeks ago by Don-vip

Attachment: required.png added

comment:1 Changed 4 weeks ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 15010/josm:

fix #17634 - Reject uploads that do not follow comment/source upload policy, using the following 4 new properties:

  • upload.comment.forbidden-terms
  • upload.comment.mandatory-terms
  • upload.source.forbidden-terms
  • upload.source.mandatory-terms

comment:2 Changed 4 weeks ago by Don-vip

This is what the warning looks like:



comment:3 Changed 4 weeks ago by Klumbumbus

For now these windows will never appear as the 4 new properties are all empty, right? Do you plan to add terms? What about upload.source.forbidden-terms=google, google-maps, googlemaps, google-earth, googleearth? Is it case insensitive?

comment:4 Changed 4 weeks ago by Don-vip

Yes the idea is to offer a configurable mechanism for those who need it (organized editing, etc.). I guess we can add some terms that apply to everyone. It is not yet case insensitive but it should.

comment:5 Changed 4 weeks ago by Don-vip

In 15015/josm:

see #17634 - use case insensitive comparison, forbid google as source

comment:6 Changed 4 weeks ago by aceman

Yes I also suggest to add some default set of rejected words. E.g. if the full changeset description is something like "test", "update", "correction", "edit", those should be rejected. Such descriptions without any meaning are useless for OSM.

comment:7 in reply to:  6 Changed 4 weeks ago by Don-vip

Replying to aceman:

E.g. if the full changeset description is something like "test", "update", "correction", "edit", those should be rejected. Such descriptions without any meaning are useless for OSM.

I disagree. Something like "osmose/JOSM corrections" is something very common. Think also about "2019 cadastral update on my area", etc. Only flagrant abuses like Google Maps should be rejected by default.

Last edited 4 weeks ago by Don-vip (previous) (diff)

comment:8 Changed 4 weeks ago by aceman

Those would be fine.

I meant when the whole comment/description of the changeset is the single word like "correction", not when the word is only a part of it.

comment:9 Changed 4 weeks ago by Don-vip

This is already catched by the "too short" (< 10 latin characters or < 4 CJK characters) mechanism.

comment:10 Changed 4 weeks ago by Zverikk

Why?!
Mappers often write "google" or "yandex" as a source, helping us find malicious edits.
You are removing this option, making mappers invent something like "survey".
What do you get from that?

comment:11 Changed 4 weeks ago by stoecker

Another why: I think for a longer time now JOSM is unable to display GoogleSat at all. They don't use TMS for their Maps-API anymore (or even image formats, but rather protobuf data).

comment:12 Changed 3 weeks ago by Stereo

DWG still occasionally, rarely, finds people using Google satellite imagery. We have our own ways of adding that imagery to JOSM for checking.

comment:13 Changed 3 weeks ago by Zverikk

Well, it would be much easier for DWG and local communities to find such people using changeset comments, not just a hunch.

comment:14 Changed 3 weeks ago by Don-vip

In 15040/josm:

see #17634 - remove google from default list of forbidden terms. Useful for DWG

comment:15 Changed 2 weeks ago by Don-vip

In 15051/josm:

see #17634 - allow to define exceptions to the list of forbidden terms, through upload.comment.exception-terms property

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.