[PATCH] Support for natural=shrubbery

[JeroenHoek]

Minimal rendering for natural=shrubbery. This simply gives these shrubby areas the same area fill as natural=scrub to provide a base-line rendering preventing meaningless grey lines.

For more in-depth rendering of natural=shrubbery, including hints for vegetation density and height, a Map Paint Style is available.

The second patch ports my preset for this tag here.

[skyper]

As the numbers for natural=shrubbery are high enough to be picked up by a jenkins test, I guess it is time to create a default preset, too, which comes down to find or create an appropriate icon.

[JeroenHoek]

I can submit the preset I already have here: https://josm.openstreetmap.de/wiki/Presets/Greenery

I will do that in a separate issue. This one is just the minimal rendering.

[skyper]

I would appreciate a preset.Thanks in advance.

[JeroenHoek]

Replying to skyper:

I would appreciate a preset.Thanks in advance.

Added.

[taylor.smock]

@JeroenHoek: Thank you for contributing your parts of shrubbery preset to JOSM, specifically the svgs. I was kind of wondering how I'd make icons for it that made sense.

I was looking through testCheckPopularTags last week, and I started updating/adding presets for most of the missing tags.

A few questions, since my implementation for Shrubbery was a bit different (I was referring to ​osmwiki:Tag:natural=shrubbery, specifically the useful combination):

• Why not include the genus_species_taxon fields? (<reference ref="genus_species_taxon"/>)
• Why not include the leaf fields? (<reference ref="leaf"/>)

A few notes:

• You shouldn't need to add .png or .svg after an image name -- the JOSM image loader will try .svg then .png
• I'm not a big fan of reusing a color of something that is very similar (scrub#007000 versus shrubbery#007000, maybe 00B000?).

In my implementation, I didn't add the shape field, since it wasn't well-defined, and I don't know enough about horticulture to know whether or not it should be well-defined.

[JeroenHoek]

I can add the genus fields etc., though these are not used very often (same as with other natural features).

Shape is essentially a free-form field, so it is strictly defined in terms of its meaning (what is the shape of this area of shrubbery, which makes sense mostly in the context of box-hedges ('box') or fancy topiaries (hedges cut into fancy shapes)), but leaves the values to the user.

I'll update the patch.

[JeroenHoek]

You shouldn't need to add .png or .svg after an image name -- the JOSM image loader will try .svg then .png

I'm following the example shown by other presets in that file. I probably shouldn't deviate from that.

[JeroenHoek]

Replying to taylor.smock:

I've changed the patches with your suggestions.

(Ignore 0001-Add-minimal-rendering-for-natural-shrubbery.2.patch.)

[taylor.smock]

Something I should have noticed is that the icons provided don't quite fulfill the requirements on DevelopersGuide/DefaultPresets#PossibleproblemswithsvginJOSM . I'm fiddling with the SVGs right now. I'll go ahead and reupload them so you can make certain I didn't mess up what you intended.

[taylor.smock]

Modified SVG to fix potential issues (see wiki:DevelopersGuide/DefaultPresets#PossibleproblemswithsvginJOSM )

[skyper]

How about adding preset_link "Similar but different tag" between natural=shrub and shrubbery?

[taylor.smock]

In 18687/josm:

Fix #22792: Add natural=shrubbery (icons from JeroenHoek, patch by JeroenHoek, modified)