Modify

#22792 closed enhancement (fixed)

[PATCH] Support for natural=shrubbery

Reported by: JeroenHoek Owned by: team
Priority: normal Milestone: 23.03
Component: Internal mappaint style Version:
Keywords: natural shrubbery Cc:

Description (last modified by JeroenHoek)

Minimal rendering for natural=shrubbery. This simply gives these shrubby areas the same area fill as natural=scrub to provide a base-line rendering preventing meaningless grey lines.

For more in-depth rendering of natural=shrubbery, including hints for vegetation density and height, a Map Paint Style is available.

The second patch ports my preset for this tag here.


Attachments (4)

Screenshot from 2023-03-06 19-12-16.png (125.6 KB ) - added by JeroenHoek 17 months ago.
0001-Add-minimal-rendering-for-natural-shrubbery.patch (1.8 KB ) - added by JeroenHoek 17 months ago.
0002-Add-preset-for-natural-shrubbery.patch (69.4 KB ) - added by JeroenHoek 17 months ago.
22792.patch (58.0 KB ) - added by taylor.smock 17 months ago.
Modified SVG to fix potential issues (see wiki:DevelopersGuide/DefaultPresets#PossibleproblemswithsvginJOSM )

Download all attachments as: .zip

Change History (17)

comment:1 by skyper, 17 months ago

Keywords: natural shrubbery added

As the numbers for natural=shrubbery are high enough to be picked up by a jenkins test, I guess it is time to create a default preset, too, which comes down to find or create an appropriate icon.

comment:2 by JeroenHoek, 17 months ago

I can submit the preset I already have here: https://josm.openstreetmap.de/wiki/Presets/Greenery

I will do that in a separate issue. This one is just the minimal rendering.

Last edited 17 months ago by JeroenHoek (previous) (diff)

comment:3 by skyper, 17 months ago

I would appreciate a preset.Thanks in advance.

comment:4 by JeroenHoek, 17 months ago

Description: modified (diff)
Summary: [PATCH] Minimal support for natural=shrubbery[PATCH] Support for natural=shrubbery

in reply to:  3 comment:5 by JeroenHoek, 17 months ago

Replying to skyper:

I would appreciate a preset.Thanks in advance.

Added.

comment:6 by taylor.smock, 17 months ago

@JeroenHoek: Thank you for contributing your parts of shrubbery preset to JOSM, specifically the svgs. I was kind of wondering how I'd make icons for it that made sense.

I was looking through testCheckPopularTags last week, and I started updating/adding presets for most of the missing tags.

A few questions, since my implementation for Shrubbery was a bit different (I was referring to osmwiki:Tag:natural=shrubbery, specifically the useful combination):

  • Why not include the genus_species_taxon fields? (<reference ref="genus_species_taxon"/>)
  • Why not include the leaf fields? (<reference ref="leaf"/>)

A few notes:

  • You shouldn't need to add .png or .svg after an image name -- the JOSM image loader will try .svg then .png
  • I'm not a big fan of reusing a color of something that is very similar (scrub#007000 versus shrubbery#007000, maybe 00B000?).

In my implementation, I didn't add the shape field, since it wasn't well-defined, and I don't know enough about horticulture to know whether or not it should be well-defined.

comment:7 by JeroenHoek, 17 months ago

I can add the genus fields etc., though these are not used very often (same as with other natural features).

Shape is essentially a free-form field, so it is strictly defined in terms of its meaning (what is the shape of this area of shrubbery, which makes sense mostly in the context of box-hedges ('box') or fancy topiaries (hedges cut into fancy shapes)), but leaves the values to the user.

I'll update the patch.

comment:8 by JeroenHoek, 17 months ago

You shouldn't need to add .png or .svg after an image name -- the JOSM image loader will try .svg then .png

I'm following the example shown by other presets in that file. I probably shouldn't deviate from that.

in reply to:  6 comment:9 by JeroenHoek, 17 months ago

Replying to taylor.smock:

I've changed the patches with your suggestions.

(Ignore 0001-Add-minimal-rendering-for-natural-shrubbery.2.patch.)

comment:10 by taylor.smock, 17 months ago

Something I should have noticed is that the icons provided don't quite fulfill the requirements on DevelopersGuide/DefaultPresets#PossibleproblemswithsvginJOSM . I'm fiddling with the SVGs right now. I'll go ahead and reupload them so you can make certain I didn't mess up what you intended.

by taylor.smock, 17 months ago

Attachment: 22792.patch added

Modified SVG to fix potential issues (see wiki:DevelopersGuide/DefaultPresets#PossibleproblemswithsvginJOSM )

comment:11 by taylor.smock, 17 months ago

Milestone: 23.03

comment:12 by skyper, 17 months ago

How about adding preset_link "Similar but different tag" between natural=shrub and shrubbery?

comment:13 by taylor.smock, 17 months ago

Resolution: fixed
Status: newclosed

In 18687/josm:

Fix #22792: Add natural=shrubbery (icons from JeroenHoek, patch by JeroenHoek, modified)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.