Modify

Opened 16 months ago

Last modified 16 months ago

#22791 new enhancement

[PATCH] Minimal support for man_made=quay

Reported by: JeroenHoek Owned by: team
Priority: normal Milestone:
Component: Internal mappaint style Version:
Keywords: Cc: Don-vip, stoecker, Klumbumbus, taylor.smock

Description (last modified by JeroenHoek)

This introduces minimal rendering support for man_made=quay. It renders this tag the same way as man_made=pier which is a topical neighbour. Both tags are supported on ways as well as areas.

The second patch introduces a preset based on the one for man_made=pier, and adds a checkbox for area on both.

The icon is based on the icon style used for man_made=pier and other related elements.

For both tags it seems recommended to explicitly set area=yes on closed ways which represent areas, because they can be used a linear features as well. I've had mappers correct piers I tagged with an additional area=yes, and 20% of man_made=pier has area=yes.


Attachments (3)

0001-Add-minimal-rendering-support-for-man_made-quay.patch (1.1 KB ) - added by JeroenHoek 16 months ago.
0002-Add-preset-for-man_made-quay-add-area-to-pier.patch (6.3 KB ) - added by JeroenHoek 16 months ago.
Screenshot from 2023-03-06 18-26-18.png (198.2 KB ) - added by JeroenHoek 16 months ago.

Download all attachments as: .zip

Change History (12)

comment:1 by skyper, 16 months ago

Is area=yes really needed? I cannot imagine an closed way with man_made=pier which is not an area but, please, proof me wrong.

Overall, I prefer to have a default preset for major tags present in core mappaint which often comes down to find or create an appropriate icon.

comment:2 by JeroenHoek, 16 months ago

Is area=yes really needed? I cannot imagine an closed way with man_made=pier which is not an area but, please, proof me wrong.

Me neither, but people apparently use it like that. Why are you asking me?

Overall, I prefer to have a default preset for major tags present in core mappaint which often comes down to find or create an appropriate icon.

Icon? This just matches man_made=pier. A minimal amount of rendering helps mappers prevent mistakes and makes the mapping experience more pleasant.

in reply to:  2 comment:3 by skyper, 16 months ago

Replying to JeroenHoek:

Is area=yes really needed? I cannot imagine an closed way with man_made=pier which is not an area but, please, proof me wrong.

Me neither, but people apparently use it like that. Why are you asking me?

If area=yes is needed a closed way should be rendered differently depending on area=*. Same is true for man_made=pier, by the way.

Overall, I prefer to have a default preset for major tags present in core mappaint which often comes down to find or create an appropriate icon.

Icon? This just matches man_made=pier. A minimal amount of rendering helps mappers prevent mistakes and makes the mapping experience more pleasant.

As man_made=pier and man_made=quay are similar but not identical they should not use the same icon.
Mapping experience would be much more pleasant if a preset link would be offered for the rendered feature and if users would be able to find the tag searching the presets (F3). In my eyes, evolution of the core mappaint and the defaultpresets should be in sync.

JOSM core will never support all tags so users should be aware of that and not simply change anything cause JOSM does not render it nicely. Take at look at area:highway for example.

Last edited 16 months ago by skyper (previous) (diff)

comment:4 by JeroenHoek, 16 months ago

As man_made=pier and man_made=quay are similar but not identical they should not use the same icon.

Well yeah, but this patch does not provide a preset and icon; just base-line rendering.

If area=yes is needed a closed way should be rendered differently depending on area=*. Same is true for `man_made=pier, by the way.

Sounds like a good item for a follow-up patch. It wouldn't be topical to include modifying man_made=pier here.

comment:5 by JeroenHoek, 16 months ago

In my eyes, evolution of the core mappaint and the defaultpresets should be in sync.

Is this this project's basic guideline or your personal preference? I don't mind providing presets in tandem with styling if required, but for documented and in-use tags providing base-line minimal rendering is beneficial to all users. A preset seems to go a step beyond that and suggest approval of that tag by the JOSM maintainers. Sometimes providing a preset which does justice to a tag takes a lot more insight into the tag. I can do that for tags I am more familiar with, but in cases like this (e.g., should area=yes be included?) it goes beyond providing a base-line rendering.

Last edited 16 months ago by JeroenHoek (previous) (diff)

in reply to:  5 comment:6 by skyper, 16 months ago

Cc: Don-vip stoecker Klumbumbus taylor.smock added

Replying to JeroenHoek:

In my eyes, evolution of the core mappaint and the defaultpresets should be in sync.

Is this this project's basic guideline or your personal preference?

It is my personal preference and how it is handled over the years as far as I am aware of but I do not find any official guideline.
Let's ask for more opinions.

comment:7 by stoecker, 16 months ago

Like always with JOSM it's no hard requirement, but a sensible guideline.

comment:8 by JeroenHoek, 16 months ago

Description: modified (diff)

comment:9 by JeroenHoek, 16 months ago

Description: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from team to the specified user.
Next status will be 'needinfo'. The owner will be changed from team to JeroenHoek.
as duplicate The resolution will be set to duplicate. Next status will be 'closed'. The specified ticket will be cross-referenced with this ticket.
The owner will be changed from team to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.