Modify

Opened 3 years ago

Closed 11 hours ago

Last modified 11 hours ago

#22748 closed enhancement (fixed)

[patch] Extend utility=* to buildings, street cabinets and industrial landuses

Reported by: francois.lacombe Owned by: team
Priority: normal Milestone: 26.07
Component: Internal preset Version: latest
Keywords: utility, street cabinet, service building, industrial Cc: gaben

Description (last modified by francois.lacombe)

Dear maintainers,

Following the review of Utility facilities proposal, some changes occurs in the usage of utility=* key.
All necessary documentation is almost up to date, I hope nothing is missing so far.
https://wiki.openstreetmap.org/wiki/Proposed_features/Utility_facilities

Is it possible to update man_made=street_cabinet preset with following points please?

  • Optional utility=* combobox with same values as used in combination with marker=*.
  • Remove street_cabinet=power,water,telelcom,gas,street_lighting,cable_tv,water_management values.
  • Colors should be common to utility=* values as of now and it may simplify default style.

Add utility=* combo box to building=service and building=industrial presets
It could be possible to use utility=* to color such buildings if appropriate.

As a side note, I think utility=* should be restricted to power,telecom,television and street_lighting values in combination with man_made=utility_pole (#20270 #21587).

Add following validation rules :

  • street_cabinet=poweris replaced by utility=power
  • street_cabinet=water, street_cabinet=water_management are replaced by utility=water
  • street_cabinet=sewerage is replaced by utility=sewerage
  • street_cabinet=gas and street_cabinet=gas_management are replaced by utility=gas
  • street_cabinet=telecom, street_cabinet=communication, street_cabinet=telephone and street_cabinet=broadband are replaced by utility=telecom
  • street_cabinet=cable_tv is replaced by utility=television
  • street_cabinet=street_lighting is replaced by utility=street_lighting
  • industrial=gas is deprecated and replaced by utility=gas

Let me know if any additional documentation is required

Best regards

Attachments (1)

josm_22748_24724.patch (17.7 KB ) - added by francois.lacombe 3 months ago.
Patch for this ticket and #24724

Download all attachments as: .zip

Change History (12)

comment:1 by aceman, 3 years ago

Component: Core validatorInternal preset
Version: latest

Yes it is also needed to update the preset for street_cabinet in JOSM core. Now people are alreary converting cabinets to utility and it is a pity JOSM still produces new 'street_cabinet' tags which should be 'utility'.

https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dstreet_cabinet

Version 0, edited 3 years ago by aceman (next)

comment:2 by francois.lacombe, 3 years ago

Description: modified (diff)

comment:3 by francois.lacombe, 3 years ago

Hello

I missed and completely second your comment aceman.

It is the first point of this ticket: update man_made=street_cabinet preset with utility=* and remove corresponding vaues of street_cabinet=*.

comment:4 by gaben, 2 years ago

Cc: gaben added

comment:5 by francois.lacombe, 2 years ago

Cc: gaben removed
Description: modified (diff)

comment:6 by francois.lacombe, 2 years ago

Cc: gaben added

by francois.lacombe, 3 months ago

Attachment: josm_22748_24724.patch added

Patch for this ticket and #24724

comment:7 by stoecker, 3 months ago

Milestone: 26.05

comment:8 by gaben, 3 months ago

Summary: Extend utility=* to buildings, street cabinets and industrial landuses[patch] Extend utility=* to buildings, street cabinets and industrial landuses

comment:9 by stoecker, 3 weeks ago

Milestone: 26.0526.07

Milestone renamed

comment:10 by stoecker, 11 hours ago

Resolution: fixed
Status: newclosed

In 19591/josm:

fix #22748 - patch by francois.lacombe - Extend utility=* to buildings, street cabinets and industrial landuses

comment:11 by stoecker, 11 hours ago

In 19593/josm:

see #22748 - fix typo

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.