Modify

Opened 2 years ago

Closed 15 months ago

#22749 closed enhancement (worksforme)

Adding more validation errors for areas

Reported by: etienne.julien@… Owned by: etienne.julien@…
Priority: normal Milestone:
Component: Core validator Version:
Keywords: broken multipolygon Cc:

Description

Just wanted to report that OSM Inspector for Areas returns in some cases a different and more complete set of validation errors (overlaps, roles missing, ...).

More info https://community.openstreetmap.org/t/looking-for-a-tool-that-can-identify-broken-forest-bounds/9043/6

Attachments (1)

multipolygon_example.osm.xz (82.2 KB ) - added by skyper 2 years ago.
r13113130

Download all attachments as: .zip

Change History (9)

comment:1 by skyper, 2 years ago

Component: CoreCore validator
Keywords: broken multipolygon added

comment:2 by skyper, 2 years ago

Owner: changed from team to etienne.julien@…
Status: newneedinfo

You are talking about multipolygon relations, right?
There are already several warnings about multipolygon relations therefore, please, attach some small examples and tell us what you expect to be warned about. Thanks

comment:3 by anonymous, 2 years ago

Yes multipolygon relations.

e.g Relation 13113130

JOSM shows 1 error:

  • role for 1075732657 should be outerway

OSMI shows 2 errors:

  • node 9383789576 touching ring
  • node 1059812214 in multiple rings

e.g relation 13113129

OSMI shows additionally 1 error:

  • node 957957244 in multiple rings

These node-touching-rings errors are important since they may not be rendered properly

comment:5 by skyper, 2 years ago

Well, a single touching node might be valid and I already get some informational warnings (need to be enabled in preferences):

  • Multipolygon rings share node (6)
  • With the currently used mappaint style the style for outer way mismatches the area style (1)

EDIT: this is with the attached r13113130.

Last edited 2 years ago by skyper (previous) (diff)

in reply to:  3 comment:6 by skyper, 2 years ago

Replying to anonymous:

Yes multipolygon relations.

e.g Relation 13113130

JOSM shows 1 error:

  • role for 1075732657 should be outerway

OSMI shows 2 errors:

  • node 9383789576 touching ring
  • node 1059812214 in multiple rings

e.g relation 13113129

OSMI shows additionally 1 error:

  • node 957957244 in multiple rings

These node-touching-rings errors are important since they may not be rendered properly

I do not find n957957244 in r13113129 and n1059812214 in r1075732657.

Last edited 2 years ago by skyper (previous) (diff)

comment:7 by skyper, 2 years ago

I have just recheck and the only problem with current r13113129 is marked as error: Role verification problem - Role for '‎residential (landuse)‎ (11 nodes) [id: 291 359 096]‌' should be 'outer' (1)
Similar is true for the attached r13113130. In my eyes, all problems are mentioned at least as informational warnings.

@etienne.julien:
Do you find any problem not found by validator? If so, please, mention the object ids, thanks

comment:8 by skyper, 15 months ago

Resolution: worksforme
Status: needinfoclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain etienne.julien@….
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.