Modify

Opened 3 months ago

Last modified 3 months ago

#21235 new enhancement

[PATCH] Stop whitelisting footway=*, and add footway=separate to blacklist candidates for sidewalk=*

Reported by: JeroenHoek Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: footway sidewalk Cc:

Description (last modified by JeroenHoek)

To resolve #10851, #10976, #15439, and #19389 the validator checks if ways have footway=* set with one of the values typically used for sidewalk=*. This seems to be a fairly common mistake, so it's good to have a warning here.

Issues

There are two minor issues with the current validation approach I would like to resolve.

footway=separate is missing

The validator checks for left, right, both, none, and no. separate is missing from this list.

Whitelist blocks all other possible footway values except for three

While the above values are clear examples of misstagging, footway is not an invalid key, and is used to provide a refining of highway=footway. The validator acknowledges this for access_aisle, crossing, and sidewalk, but excludes everything else. This seems too strict compared to the other rules — we don't whitelist values for highway=* for example. Mappers can (and do) create new values, and some are gaining broader acceptance. This check seems superfluous with the checks for values that probably mean sidewalk=* in place.

Patch

In the attached patch:

  • A check for footway=separate is added.
  • The whitelist for footway=* is removed.

Are there any issues I am overlooking or reintroducing with this patch?

Attachments (1)

0001-Fix-minor-issues-with-footway-validation.patch (3.0 KB) - added by JeroenHoek 3 months ago.
Patch

Download all attachments as: .zip

Change History (12)

comment:1 Changed 3 months ago by JeroenHoek

Description: modified (diff)

comment:2 Changed 3 months ago by JeroenHoek

Component: CoreCore validator
Type: defectenhancement

comment:3 Changed 3 months ago by JeroenHoek

Description: modified (diff)

comment:4 Changed 3 months ago by skyper

According to #21242, sidewalk=none should be replaced by sidewalk=no, so JOSM is correct with the special treatment.

comment:5 Changed 3 months ago by skyper

Keywords: footway sidewalk added

comment:6 Changed 3 months ago by anonymous

Really? This isn't reflected in the current documentation of sidewalk=*. I'm not seeing any recent mention on the Taggin-ML either.

I'm not opposed to deprecating sidewalk=none, but was this discussed somewhere else than on the Taggin-ML and the wiki-page for sidewalk=*?

comment:7 Changed 3 months ago by JeroenHoek

(Comment by me.)

comment:9 Changed 3 months ago by mkoniecz

that was me, sorry

Changed 3 months ago by JeroenHoek

Patch

comment:10 Changed 3 months ago by JeroenHoek

Description: modified (diff)

comment:11 Changed 3 months ago by JeroenHoek

I've removed the removal of the special treatment of footway=none from the patch.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to JeroenHoek
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.