Opened 10 years ago
Closed 10 years ago
#10851 closed defect (fixed)
Validation tests for foot/footway/sidewalk
Reported by: | naoliv | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 14.12 |
Component: | Core validator | Version: | |
Keywords: | mapcss | Cc: | Klumbumbus |
Description (last modified by )
First a problem: validating a way with highway=footway
+ foot=no
gives us a footway used with foot=
(note that there isn't a value after the =
)
- done.
Now the enhancements: highway=residential
+ sidewalk=both
+ foot=no
doesn't issue a warning (it's as contradictory as using highway=footway
+ foot=no
)
- controversial
Also, highway=residential
+ footway=both
doesn't warn that footway
is deprecated (and that sidewalk
should be used instead)
- done.
Attachments (0)
Change History (23)
comment:1 by , 10 years ago
Cc: | added |
---|
follow-up: 3 comment:2 by , 10 years ago
Milestone: | → 14.12 |
---|---|
Summary: | Validation tests for foot/footwat/sidewalk → Validation tests for foot/footway/sidewalk |
comment:3 by , 10 years ago
Replying to Klumbumbus:
with
highway=foot
you meanhighway=footway
?
Yes, sorry :-)
Also, sidewalk=both
(on second paragraph) can be both|left|right|yes
and footway=both
(third paragraph) can be both|left|right
comment:4 by , 10 years ago
Description: | modified (diff) |
---|
comment:6 by , 10 years ago
Replying to naoliv:
First a problem: validating a way with
highway=footway
+foot=no
gives us afootway used with foot=
(note that there isn't a value after the=
)
In this case we could fix this by simply changing !?
to =no
in trunk/data/validator/highway.mapcss#L67, but I made a ticket for this, see #10859
follow-up: 10 comment:7 by , 10 years ago
Replying to naoliv:
Now the enhancements:
highway=residential
+sidewalk=both
+foot=no
doesn't issue a warning
It seems some people tag this way when the sidewalks are mapped as separate ways, however I'm not sure if this is good tagging.
Example: way/220407308.
In this case should the sidewalk
key set to no
or be removed?
Overpass turbo querry: http://overpass-turbo.eu/s/6yN
comment:9 by , 10 years ago
Description: | modified (diff) |
---|
follow-up: 14 comment:10 by , 10 years ago
Replying to Klumbumbus:
It seems some people tag this way when the sidewalks are mapped as separate ways, however I'm not sure if this is good tagging.
Example: way/220407308.
In this case should thesidewalk
key set tono
or be removed?
My understanding is that sidewalk
is an attribute of the highway
.
It's also what is documented in http://wiki.openstreetmap.org/wiki/Sidewalk:
The sidewalk (or pavement) is that part of a highway set aside for the use of pedestrians, often separated from the carriageway (or roadway) by a kerb (also curb). A sidewalk may be separated from the carriageway by only a kerb, by a road verge or alternatively may be at some distance from the road (but still associated with it) or separated from the road by some form of barrier, for example bushes or a line of trees. A road may have a sidewalk on only one side of the carriageway, or both side or have no sidewalks.
If the highway allows pedestrians at the sidewalk then it's wrong to use foot=no
(so foot=no
should be removed)
Like it's implicit that a car may not drive on the sidewalk, it should be implied that a pedestrian must use the sidewalk (and not the street itself) for walking.
comment:11 by , 10 years ago
foot=no
is definitely wrong. Reminds me about the discussion of bicycle=use_sidepath
.
Actually, there are some discussions on the German mailing about the issues with separately tagged side_ways. Tagging it on the highway=*
and as separate object without any indication seems to be wrong, especially, as I know some places where you find both. The sidewalk directly at the kerbs and a parallel footway 2-3 metres away.
One solution could be sidewalk(:left/right/both)=separate_way
or similar.
comment:12 by , 10 years ago
Just complementing, I randomly picked some objects from your overpass query and, from the sample, they all have a wrong foot=no
.
follow-up: 16 comment:14 by , 10 years ago
Replying to naoliv:
If the highway allows pedestrians at the sidewalk then it's wrong to use
foot=no
(sofoot=no
should be removed)
Like it's implicit that a car may not drive on the sidewalk, it should be implied that a pedestrian must use the sidewalk (and not the street itself) for walking.
This is not to be implied. It depends on the country law, whether pedestrians MUST use the sidewalk. Also, the change here actually goes against ticket #9379. Please see the discussion there about the per-country specifics.
I agree that it is not defined on the wiki whether the foot=* applies to the road surface+any sidewalks OR only to the road surface itself (asphalt). Ticket #9379 idea is for it to apply only to the road surface. And in the ticket here you now take the opposite explanation.
comment:15 by , 10 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
follow-ups: 17 18 comment:16 by , 10 years ago
Replying to aceman:
This is not to be implied. It depends on the country law, whether pedestrians MUST use the sidewalk. Also, the change here actually goes against ticket #9379. Please see the discussion there about the per-country specifics.
What happens if the sidewalk is blocked or full of snow ?
I agree that it is not defined on the wiki whether the foot=* applies to the road surface+any sidewalks OR only to the road surface itself (asphalt). Ticket #9379 idea is for it to apply only to the road surface. And in the ticket here you now take the opposite explanation.
#9379 follows exactly the same direction as foot=*
counts for the whole highway=*
. Since #9379 was fixed, validator warns about foot=yes
without sidewalk=*
, nothing more.
Regarding this ticket, we could use the same warnings for cycleway=*
and bicycle=no
.
comment:17 by , 10 years ago
Replying to skyper:
Regarding this ticket, we could use the same warnings for
cycleway=*
andbicycle=no
.
Where is this warning that I am not seeing using a test way with highway=residential
+ cycleway=lane
+ bicycle=no
?
comment:18 by , 10 years ago
comment:20 by , 10 years ago
comment:21 by , 10 years ago
No problem, my Jenkins had some problems this week and I wasn't available to fix them until now.
comment:23 by , 10 years ago
Description: | modified (diff) |
---|---|
Resolution: | → fixed |
Status: | reopened → closed |
with
highway=foot
you meanhighway=footway
?