Modify

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#10859 closed defect (fixed)

validator warning incomplete

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 15.04
Component: Core validator Version:
Keywords: template_report, placeholder, mapcss Cc: naoliv

Description

Problem: If used a key only selector ([key]) in a validator rule and in the warning message {x.tag}, the value of the key is not displayed.

Example validator rule from #10825:

node:unconnected[entrance] {
  throwWarning: tr("{0} must be connected to a way", "{1.tag}");
}

Displays as entrance= must be connected to a way

It should display the actual value of entrance after the =

other example from #10851:

way[highway=footway][foot?!] {
  throwWarning: tr("{0} used with {1}", "{0.value}", "{1.tag}");
}

Displays as footway used with foot=

It should display the actual value of foot ("no") after the =

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-12-16 02:34:51
Last Changed Author: bastiK
Revision: 7805
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-12-15 20:44:26 +0100 (Mon, 15 Dec 2014)
Last Changed Rev: 7805

Identification: JOSM/1.5 (7805 de) Windows 7 32-Bit
Memory Usage: 247 MB / 742 MB (123 MB allocated, but free)
Java version: 1.7.0_71, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:C:\Program Files\Java\jre7\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files\josm-latest.jnlp, -Djnlpx.remove=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=256m,768m, -Djnlpx.splashport=61442, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==]
Dataset consistency test: No problems found

Attachments (0)

Change History (6)

comment:1 Changed 4 years ago by Klumbumbus

Cc: naoliv added

comment:2 Changed 4 years ago by naoliv

It seems to be #9782

comment:3 Changed 4 years ago by Don-vip

Keywords: mapcss added

comment:4 Changed 3 years ago by simon04

Resolution: fixed
Status: newclosed

In 8266/josm:

fix #9782 fix #10859 - MapCSS validator: evaluate real key and value for KeyConditions

comment:5 Changed 3 years ago by simon04

Milestone: 15.04

comment:6 Changed 3 years ago by Klumbumbus

Great, Thanks! I think this is a good step to reduce the number of people, who vote for "Unverständlichkeit" at http://osm.haraldhartmann.de/umfrage/poll/9

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.