Modify

Opened 4 years ago

Closed 2 years ago

#10976 closed enhancement (fixed)

Fix subtags together with footway=both/left/right

Reported by: skyper Owned by: team
Priority: normal Milestone: 16.12
Component: Core validator Version:
Keywords: fix footway sidewalk Cc:

Description

There are some subtags of footway=both/left/right like footway:surface or footway:width plus width:footway, width:footway and similar.

Please, with changing footway to sidewalk also change all other keys, too.

Attachments (1)

example_josm_10976.osm (639 bytes) - added by skyper 4 years ago.
osm example file

Download all attachments as: .zip

Change History (9)

comment:1 Changed 4 years ago by Klumbumbus

Can you please be a bit more precise?

Changed 4 years ago by skyper

Attachment: example_josm_10976.osm added

osm example file

comment:2 Changed 4 years ago by skyper

Replying to Klumbumbus:

Can you please be a bit more precise?

Sorry, yes

In validator you get a warning about footway=both/left/right and an option to automatically fix it changing the key to sidewalk but there could be subtags for the footway which should be changed to like surface:footway=* which need to be adjusted, too.

Have a look at attached example file

Last edited 4 years ago by skyper (previous) (diff)

comment:3 Changed 2 years ago by skyper

Still get these warnings and always have to be really careful to check all tags before auto-fixing.

comment:4 Changed 2 years ago by Klumbumbus

In 11364/josm:

see #10976 - disable autofix for footway to sidewalk warning if another key which contains footway: is present

comment:5 Changed 2 years ago by Klumbumbus

Auto fixing the other tags is a bit more complex and not possible in mapcss I think. I don't think someone has time for a Java test atm. So I disabled the autofix for now if another key which contains footway: is present.

comment:6 in reply to:  5 Changed 2 years ago by skyper

Replying to Klumbumbus:

Auto fixing the other tags is a bit more complex and not possible in mapcss I think. I don't think someone has time for a Java test atm. So I disabled the autofix for now if another key which contains footway: is present.

Thanks a lot.

comment:7 Changed 2 years ago by skyper

@Klumbumbus:
I can live well with the current behaviour and the numbers of hits will hopefully drop. Please, go ahead and mark this as fixed.

comment:8 Changed 2 years ago by Klumbumbus

Milestone: 16.12
Resolution: fixed
Status: newclosed

ok

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.