changeset_comment and changeset_source are not decoded

[pyrog]

What steps will reproduce the problem?

1. From ​OSMTM, project #837 contribute to a task
2. Click on the button Edit with JOSM
3. The parameters in URL of the remote control are encoded by OSMTM

​http://127.0.0.1:8111/load_and_zoom?left=125.44739&bottom=11.99634&right=125.45288&top=12.00171&changeset_comment=%2523hotosm-project-837%2520-%2520Typhoon%2520Ruby%2520-%2520%2523SkyEye%2520%2523RubyPH%2520&changeset_source=tms%5B23%5D%3Ahttp%3A%2F%2Fimagery.openstreetmap.fr%2Ftms%2F1.0.0%2Frubyph%2F%7Bzoom%7D%2F%7Bx%7D%2F%7By%7D.png

What is the expected result?

When uploading datas to OSM, the comment should be "#hotosm-project-837 - Typhoon Ruby - #SkyEye #RubyPH"

What happens instead?

The comment is "%23hotosm-project-837%20-%20Typhoon%20Ruby%20-%20%23SkyEye%20%23RubyPH%20"

Please provide any additional information below. Attach a screenshot if possible.

See Issue ​hotosm/osm-tasking-manager2 #513 on github.

The datasource is correctly decoded: "tms[23]:​http://imagery.openstreetmap.fr/tms/1.0.0/rubyph/{zoom}/{x}/{y}.png"

Revision: 7906
Repository Root: http://josm.openstreetmap.de/svn
Relative URL: ^/trunk
Last Changed Author: Don-vip
Last Changed Date: 2014-12-29 00:13:58 +0100 (Mon, 29 Dec 2014)
Build-Date: 2014-12-29 00:11:17
URL: http://josm.openstreetmap.de/svn/trunk
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Rev: 7906

Identification: JOSM/1.5 (7906 en) Mac OS X 10.10.1
Memory Usage: 318 MB / 910 MB (129 MB allocated, but free)
Java version: 1.8.0_25, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Djava.util.Arrays.useLegacyMergeSort=true, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAC1Eam5scC5hcHBsaWNhdGlvbi5ocmVmPWh0dHBzOi8vam9zbS5vcGVuc3RyZWV0bWFwLmRlL2Rvd25sb2FkL2pvc20uam5scAAtRGphdmEuY2xhc3MucGF0aD0vVXNlcnMveHgvanl0aG9uMi41LjMvanl0aG9uLmphcgA=, -Djnlpx.jvm=<java.home>/bin/java, -Djnlpx.splashport=-1, -Djnlpx.home=<java.home>/bin, -Djnlpx.remove=false, -Djnlpx.offline=false, -Djnlpx.relaunch=true, -Djnlpx.session.data=/var/folders/yk/v8lzfbt522j7jc4137l070140000gn/T/session2751375396195555186, -Djnlpx.heapsize=NULL,NULL, -Djava.security.policy=file:/Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home/lib/security/javaws.policy, -DtrustProxy=true, -Dsun.awt.warmup=true, -Djava.security.manager]
Dataset consistency test: No problems found

Plugins:
- ImageWayPoint (30737)
- OpeningHoursEditor (30737)
- PicLayer (30762)
- cadastre-fr (30859)
- geotools (30762)
- gpxfilter (30738)
- imagery_offset_db (30808)
- jts (30762)
- measurement (30737)
- notes (v0.9.5)
- opendata (30806)
- reverter (30737)
- scripting (30702)
- tag2link (30719)
- undelete (30762)
- utilsplugin2 (30863)
- wikipedia (30780)

Last errors/warnings:
- W: Could not get presets icon Icon_raa.png
- E: Failed to locate image 'Icon_npu.png'
- W: Could not get presets icon Icon_npu.png
- E: Failed to locate image 'Icon_uzkb.png'
- W: Could not get presets icon Icon_uzkb.png

[simon04]

Why do you double encode the arguments. URL encoding #hotosm-project-837 once yields %23hotosm-project-837, but you specify %2523hotosm-project-837?

I think JOSM's behaviour is correct for the given request.