During "OK" click in preference window. Should catch errors (Tag Checker Data Sources) without closing the preference window.

[reichg]

Reproduce:

1) Open JOSM and go to edit -> preferences -> Data Validator
2) Input invalid text into the "Data Sources" field within the Tag Checker Test
3) Click "OK".
4) Notice error pop up but the whole preferences window closes.

Expected Behavior:

1) Input invalid text into the "Data Sources" field within the Tag Checker Test
2) Click "OK".
3) Notice error pop up
4) exit error popup and keep preference window open.

In general while running through validation during the "OK" button click we should keep the preference window open so the user doesn't have to come back to preferences to fix the issue.

[Don-vip]

Please don't CC us and don't set the milestone by yourself. This is up to us.

[reichg]

Replying to Don-vip:

Please don't CC us and don't set the milestone by yourself. This is up to us.

I received some contradictory information saying I could cc maintainers and set milestones. I will not do this in the future.

[skyper]

Replying to reichg:

Replying to Don-vip:

Please don't CC us and don't set the milestone by yourself. This is up to us.

I received some contradictory information saying I could cc maintainers and set milestones. I will not do this in the future.

Think you mixed up some information. Depending on the user's settings cc might be useful if you ask a direct question to a person.
Dirk Stoecker wrote that it is ok to set a milestone for tickets with a patch ready for commit. In any other situation, please, leave it untouched (empty).

[skyper]

I had the same problems some hours ago:

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2021-08-24 02:43:50 +0200 (Tue, 24 Aug 2021)
Revision:18173
Build-Date:2021-08-24 01:31:24
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (18173 en) Linux Debian GNU/Linux 11 (bullseye)
Java version: 17-ea+19-Debian-1, Debian, OpenJDK 64-Bit Server VM
Look and Feel: com.formdev.flatlaf.FlatDarculaLaf
Desktop environment: GNOME

Plugins:
+ flatlaf (35799)

[reichg]

Replying to skyper:

Replying to reichg:

Replying to Don-vip:

Please don't CC us and don't set the milestone by yourself. This is up to us.

I received some contradictory information saying I could cc maintainers and set milestones. I will not do this in the future.

Think you mixed up some information. Depending on the user's settings cc might be useful if you ask a direct question to a person.
Dirk Stoecker wrote that it is ok to set a milestone for tickets with a patch ready for commit. In any other situation, please, leave it untouched (empty).

yeah, sure not a problem. How do you become a maintainer?