Reduce heap allocations (while rendering/validating)

[simon04]

Follow-up of #20613.

[simon04]

In 17751/josm:

see #20745 - Avoid heap allocations due to ValidatorPrefHelper.PREF_OTHER

MapCSSTagChecker: use cached validator.other property

3.23% in MapCSSTagCheckerPerformanceTest#testCity amount to BooleanProperty

[simon04]

In 17752/josm:

see #20745 - Avoid heap allocations due to BBox in IPrimitive.getBBox

Cache and return an immutable bounding box.

37.75% in MapCSSTagCheckerPerformanceTest#testCity amount to BBox::new via IPrimitive.getBBox

[simon04]

In 17756/josm:

see #20745 - Avoid heap allocations due to ValidatorPrefHelper.PREF_OTHER (fix NPE)

[GerdP]

That fix came right in time. I just wondered why unit tests failed ;)

[skyper]

Ticket #20749 has been marked as a duplicate of this ticket.

[taylor.smock]

r17752 broke the MapWithAI plugin (see #20753, fixed in plugin). In retrospect, I probably shouldn't have been modifying the returned BBoxes anyway. So thanks @simon04 for forcing me to do the right thing (tm).

[simon04]

In 17773/josm:

see #20745 - Introduce TableHelper.selectedIndices

[simon04]

In 17799/josm:

see #20745 - Avoid some heap allocations in MapCSS KeyRegexpCondition.applies

14.32% -> 9.42% in MapCSSTagCheckerPerformanceTest#testCity amount to KeyRegexpCondition.applies

[simon04]

In 17800/josm:

see #20745 - Avoid heap allocations via Selector.AbstractSelector#conds

[simon04]

In 17801/josm:

see #20745 - Avoid heap allocations in MapCSS MatchingReferrerFinder due to lambda expression

4.66% of MapCSSTagCheckerPerformanceTest#testCity amount to java.lang.invoke.Invokers$Holder.linkToTargetMethod

[simon04]

In 17802/josm:

see #20745 - Avoid heap allocations in MapCSS MatchingReferrerFinder due to Environment.withPrimitive

9.7% of MapCSSTagCheckerPerformanceTest#testCity amount to Environment.withPrimitive

[simon04]

In 17805/josm:

see #20745 - Avoid heap allocations in StyleCache

[simon04]

In 17808/josm:

see #20745 - Avoid heap allocations in MapCSS MatchingReferrerFinder due to Environment.withPrimitive

Fixup r17802.

[simon04]

In 17809/josm:

see #20745 - Avoid heap allocations in StyleCache

Fixup r17805.

[simon04]

In 17822/josm:

see #20745 - Avoid heap allocations in OsmReader

12.0% of OsmReaderPerformanceTest amount to org.openstreetmap.josm.data.osm.OsmPrimitive.updateTagged

[simon04]

In 17823/josm:

see #20745 - Avoid heap allocations in OsmReader

5.13% of OsmReaderPerformanceTest amount to org.openstreetmap.josm.data.osm.SimplePrimitiveId.hashCode

[simon04]

Enough for this milestone. :)

[Don-vip]

Replying to simon04:

In 17751/josm:

see #20745 - Avoid heap allocations due to ValidatorPrefHelper.PREF_OTHER

MapCSSTagChecker: use cached validator.other property

3.23% in MapCSSTagCheckerPerformanceTest#testCity amount to BooleanProperty

regression: #21261