Changeset 17751 in josm

Timestamp:

2021-04-12T00:16:03+02:00 (5 years ago)

Author:

simon04

Message:

see #20745 - Avoid heap allocations due to ValidatorPrefHelper.PREF_OTHER

MapCSSTagChecker: use cached validator.other property

3.23% in MapCSSTagCheckerPerformanceTest#testCity amount to BooleanProperty

File:

• trunk/src/org/openstreetmap/josm/data/validation/tests/MapCSSTagChecker.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/validation/tests/MapCSSTagChecker.java

@@ -26 +26 @@
 import org.openstreetmap.josm.data.osm.IPrimitive;
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
+import org.openstreetmap.josm.data.preferences.CachingProperty;
 import org.openstreetmap.josm.data.preferences.sources.SourceEntry;
 import org.openstreetmap.josm.data.preferences.sources.ValidatorPrefHelper;
@@ -59 +60 @@
     private final Map<MapCSSRule, MapCSSTagCheckerAndRule> ruleToCheckMap = new HashMap<>();
     private static final Map<IPrimitive, Area> mpAreaCache = new HashMap<>();
+    private static final CachingProperty<Boolean> PREF_OTHER = ValidatorPrefHelper.PREF_OTHER.cached();
     static final boolean ALL_TESTS = true;
     static final boolean ONLY_SELECTED_TESTS = false;
@@ -239 +241 @@
     @Override
     public void check(OsmPrimitive p) {
-        for (TestError e : getErrorsForPrimitive(p, ValidatorPrefHelper.PREF_OTHER.get())) {
+        for (TestError e : getErrorsForPrimitive(p, PREF_OTHER.get())) {
             addIfNotSimilar(e, errors);
         }