Changeset 17809 in josm

Timestamp:

2021-04-20T23:52:31+02:00 (3 years ago)

Author:

simon04

Message:

see #20745 - Avoid heap allocations in StyleCache

Fixup r17805.

Location:

trunk

Files:

• src/org/openstreetmap/josm/gui/mappaint/StyleCache.java (modified) (2 diffs)
• test/functional/org/openstreetmap/josm/gui/mappaint/StyleCacheTest.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/gui/mappaint/StyleCache.java

@@ -46 +46 @@
 
         if (selected) {
-            if (s.selectedStyle == null) {
-                s.selectedStyle = new DividedScale<>();
-            }
-            s.selectedStyle.put(o, r);
+            s.selectedStyle = (s.selectedStyle == null ? new DividedScale<StyleElementList>() : s.selectedStyle).put(o, r);
         } else {
-            if (s.plainStyle == null) {
-                s.plainStyle = new DividedScale<>();
-            }
-            s.plainStyle.put(o, r);
+            s.plainStyle = (s.plainStyle == null ? new DividedScale<StyleElementList>() : s.plainStyle).put(o, r);
         }
         return s.intern();
@@ -82 +76 @@
     @Override
     public boolean equals(Object obj) {
-        if (obj == null) {
-            return false;
-        }
-        if (getClass() != obj.getClass()) {
-            return false;
-        }
+        if (obj == null) return false;
+        if (getClass() != obj.getClass()) return false;
         final StyleCache other = (StyleCache) obj;
         return Objects.equals(plainStyle, other.plainStyle) && Objects.equals(selectedStyle, other.selectedStyle);

trunk/test/functional/org/openstreetmap/josm/gui/mappaint/StyleCacheTest.java

@@ -14 +14 @@
 
 import org.junit.jupiter.api.AfterAll;
-import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
@@ -53 +52 @@
     @RegisterExtension
     @SuppressFBWarnings(value = "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD")
-    public JOSMTestRules test = new JOSMTestRules().preferences().projection().mapStyles().timeout(60000);
+    public JOSMTestRules test = new JOSMTestRules().main().preferences().projection().mapStyles().timeout(60000);
 
     /**
@@ -59 +58 @@
      * @throws Exception If an error occurred during load.
      */
-    @BeforeAll
-    public static void load() throws Exception {
+    @BeforeEach
+    public void load() throws Exception {
         img = new BufferedImage(IMG_WIDTH, IMG_HEIGHT, BufferedImage.TYPE_INT_ARGB);
         try (InputStream in = Compression.getUncompressedFileInputStream(new File("nodist/data/neubrandenburg.osm.bz2"))) {
@@ -158 +157 @@
                 StyleElementList sel = p.a;
                 assertNotNull(sel);
-                Integer k = counter.get(sel);
-                if (k == null) {
-                    k = 0;
-                }
-                counter.put(sel, k + 1);
+                counter.merge(sel, 1, Integer::sum);
             }
         }