Modify

Opened 7 days ago

Last modified 6 days ago

#20130 new enhancement

Use mapcss rules instead of CrossingWays java code to find overlapping areas

Reported by: GerdP Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: crossing Cc: Klumbumbus, simon04

Description (last modified by GerdP)

Today we use the java code in CrossingWays to find e.g. "Crossing building/residential area".
This should better be done using a rule like this

/* Building overlapping landuse residential (spatial test) */
area[building][building!~/no|entrance/]  area[landuse=residential]{
  throwWarning: tr("Overlapping buildings/residential area");
}

Reasoning:

  • it also handles multipolygons (if they are complete)
  • it marks the overlapping area, not the crossing segments
  • it also handles overlaps where the two areas share nodes

In r17084 CrossingWays also finds crossings between

  • building/waterway=riverbank ("Crossing building/waterway")
  • building/railway=platform ("Crossing building/railway" (false positive?)

It doesn't find other crossing like those between building/natural=water, see #20121

Maybe it is possible to create a single mapcss test to catch different types of areas which shouldn't overlap a building?

I didn't test the impact on performance, I assume it is rather small.

Attachments (0)

Change History (5)

comment:1 Changed 7 days ago by GerdP

Description: modified (diff)

comment:2 Changed 6 days ago by Don-vip

Cc: simon04 added
Component: CoreCore validator
Keywords: crossing added

I think we already discussed about it in another ticket and there was a problem, but I don't remember what. I believe CrossingWays is doing something better than the mapCSS rule, maybe the UI reporting of the crossing location, or something like that.

comment:3 Changed 6 days ago by GerdP

In the past, the highlighting of CrossingWays was better, now it's rather the other way around.

comment:4 in reply to:  description Changed 6 days ago by skyper

Replying to GerdP:

Reasoning:

  • it marks the overlapping area, not the crossing segments

Actually with long ways, I prefer the highlighting of the crossing segments. Selecting the object is already possible, so highlighting the whole ways is not an advantage.

comment:5 Changed 6 days ago by GerdP

so highlighting the whole ways is not an advantage.

I don't understand. It is not highlighting the whole way unless the whole area is overlapping. With building the area is rarely large. F6 zooms to the interesting (=overlapping) area.
Please try the proposed rule and compare the highlighting.

Anyway, more important is that it finds all overlaps.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to GerdP
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.