#20129 closed enhancement (fixed)
[patch] Fix typos and misspellings in the code
Reported by: | gaben | Owned by: | team |
---|---|---|---|
Priority: | minor | Milestone: | 20.12 |
Component: | Core | Version: | latest |
Keywords: | typo | Cc: |
Description
Mostly comments affected, but also some method and class names as well, so please review carefully. A few comment lines were over 120 column length, so I split these to better fit in code editors window.
One place I made code logic change, but it's just a simplification, see below
-
src/org/openstreetmap/josm/data/osm/DataSet.java
1149 1149 DataSourceRemovedEvent clearEvent = new DataSourceRemovedEvent( 1150 1150 this, new LinkedHashSet<>(from.dataSources), from.dataSources.stream()); 1151 1151 if (from.dataSources.stream().filter(dataSource -> !dataSources.contains(dataSource)) 1152 . map(dataSources::add).filter(Boolean.TRUE::equals).count() > 0) {1152 .anyMatch(dataSources::add)) { 1153 1153 cachedDataSourceArea = null; 1154 1154 cachedDataSourceBounds = null; 1155 1155 }
Attachments (3)
Change History (22)
by , 4 years ago
Attachment: | josm_typos_fixed_v1.patch added |
---|
comment:1 by , 4 years ago
Type: | defect → enhancement |
---|
comment:2 by , 4 years ago
Summary: | Fix typos and misspellings in the code → [patch] Fix typos and misspellings in the code |
---|
by , 4 years ago
Attachment: | josm_typos_fixed_v2.patch added |
---|
comment:3 by , 4 years ago
comment:4 by , 4 years ago
Thanks, I didn't know that. Btw, only the ones made shorter where I looked for spelling issues, so there are still plenty of 120> length lines in the source.
Maybe it worth to propagate somewhere in the developer guideline. At least where to search for the info.
follow-up: 9 comment:5 by , 4 years ago
It is hidden in somewhere in the checkstyle and/or sonarlint configuration
by , 4 years ago
Attachment: | josm_typos_fixed_v3.patch added |
---|
Found a few more issues, final version
follow-up: 7 comment:6 by , 4 years ago
Renaming public enum OverpassOutpoutFormat is probably incompatible with the pbf plugin
comment:7 by , 4 years ago
Replying to GerdP:
Renaming public enum OverpassOutpoutFormat is probably incompatible with the pbf plugin
Well, then we fix it there as well :-)
comment:8 by , 4 years ago
Yes, sure. Since pbf plugin is very stable there is no problem with this.
comment:9 by , 4 years ago
comment:11 by , 4 years ago
comment:12 by , 4 years ago
Milestone: | → 20.12 |
---|---|
Priority: | normal → minor |
comment:13 by , 4 years ago
Please submit a pull request to https://github.com/blackears/svgSalamander for the changes in com/kitfox package.
comment:18 by , 4 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:19 by , 4 years ago
Hmm, the first change navigatable to navigable. We have a class named "NavigatableComponent.java" ;-)
Fix a missed rename (cDdHighPrecisionFormatter), small formatting improvement in gui/ExceptionDialogUtil.java