Modify

Opened 9 days ago

Closed 8 days ago

Last modified 8 days ago

#20129 closed enhancement (fixed)

[patch] Fix typos and misspellings in the code

Reported by: gaben Owned by: team
Priority: minor Milestone: 20.12
Component: Core Version: latest
Keywords: typo Cc:

Description

Mostly comments affected, but also some method and class names as well, so please review carefully. A few comment lines were over 120 column length, so I split these to better fit in code editors window.

One place I made code logic change, but it's just a simplification, see below

  • src/org/openstreetmap/josm/data/osm/DataSet.java

     
    11491149                    DataSourceRemovedEvent clearEvent = new DataSourceRemovedEvent(
    11501150                            this, new LinkedHashSet<>(from.dataSources), from.dataSources.stream());
    11511151                    if (from.dataSources.stream().filter(dataSource -> !dataSources.contains(dataSource))
    1152                             .map(dataSources::add).filter(Boolean.TRUE::equals).count() > 0) {
     1152                            .anyMatch(dataSources::add)) {
    11531153                        cachedDataSourceArea = null;
    11541154                        cachedDataSourceBounds = null;
    11551155                    }

Attachments (3)

josm_typos_fixed_v1.patch (88.4 KB) - added by gaben 9 days ago.
josm_typos_fixed_v2.patch (92.7 KB) - added by gaben 9 days ago.
Fix a missed rename (cDdHighPrecisionFormatter), small formatting improvement in gui/ExceptionDialogUtil.java
josm_typos_fixed_v3.patch (101.3 KB) - added by gaben 9 days ago.
Found a few more issues, final version

Download all attachments as: .zip

Change History (22)

Changed 9 days ago by gaben

Attachment: josm_typos_fixed_v1.patch added

comment:1 Changed 9 days ago by gaben

Type: defectenhancement

comment:2 Changed 9 days ago by gaben

Summary: Fix typos and misspellings in the code[patch] Fix typos and misspellings in the code

Changed 9 days ago by gaben

Attachment: josm_typos_fixed_v2.patch added

Fix a missed rename (cDdHighPrecisionFormatter), small formatting improvement in gui/ExceptionDialogUtil.java

comment:3 in reply to:  description Changed 9 days ago by Klumbumbus

Replying to gaben:

A few comment lines were over 120 column length, so I split these to better fit in code editors window.

The maximum line length in JOSM java files is 145.

comment:4 Changed 9 days ago by gaben

Thanks, I didn't know that. Btw, only the ones made shorter where I looked for spelling issues, so there are still plenty of 120> length lines in the source.

Maybe it worth to propagate somewhere in the developer guideline. At least where to search for the info.

comment:5 Changed 9 days ago by GerdP

It is hidden in somewhere in the checkstyle and/or sonarlint configuration

Changed 9 days ago by gaben

Attachment: josm_typos_fixed_v3.patch added

Found a few more issues, final version

comment:6 Changed 9 days ago by GerdP

Renaming public enum OverpassOutpoutFormat is probably incompatible with the pbf plugin

comment:7 in reply to:  6 Changed 9 days ago by stoecker

Replying to GerdP:

Renaming public enum OverpassOutpoutFormat is probably incompatible with the pbf plugin

Well, then we fix it there as well :-)

comment:8 Changed 9 days ago by GerdP

Yes, sure. Since pbf plugin is very stable there is no problem with this.

comment:9 in reply to:  5 Changed 8 days ago by Klumbumbus

Replying to GerdP:

It is hidden in somewhere in the checkstyle and/or sonarlint configuration

See my link in comment:3 :)

comment:10 Changed 8 days ago by GerdP

Ah, thanks, didn't recognize the number as link :O

comment:11 Changed 8 days ago by gaben

Yes, the PBF plugin incompatible with the changes.

If anyone interested, two lines here needs to be changed and everything will be fine :)

comment:12 Changed 8 days ago by Don-vip

Milestone: 20.12
Priority: normalminor

comment:13 Changed 8 days ago by Don-vip

Please submit a pull request to https://github.com/blackears/svgSalamander for the changes in com/kitfox package.

Last edited 8 days ago by Don-vip (previous) (diff)

comment:14 Changed 8 days ago by Don-vip

In 17333/josm:

see #20129 - Fix typos and misspellings in the code (patch by gaben)

comment:15 Changed 8 days ago by Don-vip

In 17334/josm:

see #20129 - rename file to match new class name

comment:16 Changed 8 days ago by Don-vip

In 35650/osm:

see #20129 - update PBF plugin to JOSM 17334

comment:17 Changed 8 days ago by Don-vip

In 35651/osm:

see #20129 - dist

comment:18 Changed 8 days ago by Don-vip

Resolution: fixed
Status: newclosed

comment:19 Changed 8 days ago by stoecker

Hmm, the first change navigatable to navigable. We have a class named "NavigatableComponent.java" ;-)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.