[patch] Fix typos and misspellings in the code

[gaben]

Mostly comments affected, but also some method and class names as well, so please review carefully. A few comment lines were over 120 column length, so I split these to better fit in code editors window.

One place I made code logic change, but it's just a simplification, see below

src/org/openstreetmap/josm/data/osm/DataSet.java

@@ -1149 +1149 @@
                     DataSourceRemovedEvent clearEvent = new DataSourceRemovedEvent(
                             this, new LinkedHashSet<>(from.dataSources), from.dataSources.stream());
                     if (from.dataSources.stream().filter(dataSource -> !dataSources.contains(dataSource))
-                            .map(dataSources::add).filter(Boolean.TRUE::equals).count() > 0) {
+                            .anyMatch(dataSources::add)) {
                         cachedDataSourceArea = null;
                         cachedDataSourceBounds = null;
                     }

[gaben]

Fix a missed rename (cDdHighPrecisionFormatter), small formatting improvement in gui/ExceptionDialogUtil.java

[Klumbumbus]

Replying to gaben:

A few comment lines were over 120 column length, so I split these to better fit in code editors window.

The maximum line length in JOSM java files is 145.

[gaben]

Thanks, I didn't know that. Btw, only the ones made shorter where I looked for spelling issues, so there are still plenty of 120> length lines in the source.

Maybe it worth to propagate somewhere in the developer guideline. At least where to search for the info.

[GerdP]

It is hidden in somewhere in the checkstyle and/or sonarlint configuration

[gaben]

Found a few more issues, final version

[GerdP]

Renaming public enum OverpassOutpoutFormat is probably incompatible with the pbf plugin

[stoecker]

Replying to GerdP:

Renaming public enum OverpassOutpoutFormat is probably incompatible with the pbf plugin

Well, then we fix it there as well :-)

[GerdP]

Yes, sure. Since pbf plugin is very stable there is no problem with this.

[Klumbumbus]

Replying to GerdP:

It is hidden in somewhere in the checkstyle and/or sonarlint configuration

See my link in comment:3 :)

[GerdP]

Ah, thanks, didn't recognize the number as link :O

[gaben]

Yes, the PBF plugin incompatible with the changes.

If anyone interested, two lines here​ needs to be changed and everything will be fine :)

[Don-vip]

Please submit a pull request to ​https://github.com/blackears/svgSalamander for the changes in com/kitfox package.

[Don-vip]

In 17333/josm:

see #20129 - Fix typos and misspellings in the code (patch by gaben)

[Don-vip]

In 17334/josm:

see #20129 - rename file to match new class name

[Don-vip]

In 35650/osm:

see #20129 - update PBF plugin to JOSM 17334

[Don-vip]

In 35651/osm:

see #20129 - dist

[stoecker]

Hmm, the first change navigatable to navigable. We have a class named "NavigatableComponent.java" ;-)