Modify

Opened 11 days ago

Closed 10 days ago

#20113 closed defect (wontfix)

Create/Update Multipolygon: Cancel in relation editor has different result compared to common relation edtior

Reported by: skyper Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: template_report create multipolygon cancel relation editor Cc:

Description

What steps will reproduce the problem?

  1. Have a closed way with one linear tag and an area tag
  2. Create MP
  3. In the relation editor click "Cancel" or press Escape

What is the expected result?

The complete action is canceled.

What happens instead?

In my case, without changes in the relation editor, it is the same behavior as clicking on "OK"
Only the possible adjustments are canceled.

Please provide any additional information below. Attach a screenshot if possible.

Update MP shows the same behavior.

This behavior is the complete opposite to the behavior when opening the relation editor from other places., especially, compared to "Create new relation" and "Create copy of relation".

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-11-18 20:16:58 +0100 (Wed, 18 Nov 2020)
Revision:17323
Build-Date:2020-11-19 02:30:51
URL:https://josm.openstreetmap.de/svn/trunk

Attachments (0)

Change History (10)

comment:1 Changed 11 days ago by GerdP

Isn't this a duplicate of #19966? No, but as long as that ticket is open I would not use the multipoly.show-relation-editor feature.
Besides that the behaviour is similar to creating a relation from presets, isn't it?

Last edited 11 days ago by GerdP (previous) (diff)

comment:2 Changed 11 days ago by skyper

With preset -> relation -> multipolygon -> new relation, I get the common dialog for "unsaved changes" and the relation is not created with No, discard the changes and close. That is ok and the same as "copy relation" and "edit relation" or "add relation" with at least one change in relation editor. Looks pretty consistent to me.

I have started updating the docu on Help/Action/UpdateMultipolygon and Help/Action/CreateMultipolygon. What does multipoly.alltags do?

comment:3 Changed 11 days ago by GerdP

I also searched for a docu today ;)
Didn't try it, but looking at the source it's about tags which don't appear in all outer ways. If set to true, tags which appear only in some outer ways might be moved to the relation.
Probably depends on the patch for the bug shown in #20110.

comment:4 Changed 11 days ago by GerdP

Reg. "cancel": I see no simple way to change the behaviour if way tags are changed. It's far easier to remove the code which opens the relation editor.

comment:5 Changed 11 days ago by skyper

Mmh, should have looked at the source code from the beginning. The relation editor is a "normal" editor ("edit Relation") and the preference setting just a shortcut to not have to open the just created/updated multipolygon, manually. I thought it is placed inside the action.

So it is no inconsistent behavior but needs a proper documentation. Still have the opinion that it is a dangerous clinch as my expectation was that I am still within the action and removing tags from the relation might even restore them on the ways.

Searching through CreateMultipolygonAction.java, I do not find the notifications Intersection between multipolygon ways or Multipolygon is not closed but only ones which are not shown to user. Where do I find the notifications?

comment:6 Changed 11 days ago by GerdP

Where do I find the notifications?

The calculation is done with the code in the validator, see makeFromWays() in MultipolygonTest.java

Last edited 11 days ago by GerdP (previous) (diff)

comment:7 Changed 11 days ago by skyper

Thanks, this should then be documented on a different page anyway, as these notifications are used by different actions.

comment:8 Changed 10 days ago by skyper

Totally forgot about #19966. Atm, this relation editor is modal and blocks all other actions. So it is not a "normal" relation editor and quite limited.

comment:9 Changed 10 days ago by GerdP

Yes, I tend to think I should simply commit the patch for #19966 now.

comment:10 Changed 10 days ago by GerdP

Resolution: wontfix
Status: newclosed

Difference in behaviour is documented in the wiki now.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.