Modify

Opened 6 weeks ago

Closed 10 days ago

Last modified 8 days ago

#19966 closed enhancement (fixed)

Create Multipolygon blocks JOSM

Reported by: skyper Owned by: team
Priority: normal Milestone: 20.11
Component: Core Version: latest
Keywords: template_report create multipolygon Cc:

Description

What steps will reproduce the problem?

  1. select a closed way
  2. "Create Multipolygon" (Ctrl+B)
  3. Relation editor opens

What is the expected result?

All actions are possible outside thr relation editor

What happens instead?

The relation editor blocks all actions outside of it.

Please provide any additional information below. Attach a screenshot if possible.

I tried to delete the member and add a different one but as selection does not work, no members can be added.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-10-19 03:04:49 +0200 (Mon, 19 Oct 2020)
Revision:17239
Build-Date:2020-10-19 01:31:02
URL:https://josm.openstreetmap.de/svn/trunk

Attachments (0)

Change History (8)

comment:1 Changed 6 weeks ago by GerdP

The relation editor only opens when preference multipoly.show-relation-editor is true.
Besides that I can reproduce this with r17084

comment:2 Changed 6 weeks ago by skyper

Keywords: regression removed

You are right, no regression. Still think, the behavior should not be different than cloning a multipolygon relation.

Last edited 6 weeks ago by skyper (previous) (diff)

comment:3 Changed 6 weeks ago by skyper

Type: defectenhancement

comment:4 Changed 6 weeks ago by GerdP

Code to force modal mode is very old, but it seems to work without it:

  • src/org/openstreetmap/josm/actions/CreateMultipolygonAction.java

     
    133133                        MainApplication.getLayerManager().getEditDataSet().clearSelection(relation);
    134134                        RelationEditor editor = RelationEditor
    135135                                .getEditor(MainApplication.getLayerManager().getEditLayer(), relation, null);
    136                         editor.setModal(true);
    137136                        editor.setVisible(true);
    138137                    } else {
    139138                        MainApplication.getLayerManager().getEditLayer().setRecentRelation(relation);

comment:5 Changed 4 weeks ago by GerdP

Milestone: 20.11

comment:6 Changed 10 days ago by GerdP

Resolution: fixed
Status: newclosed

In 17325/josm:

fix #19966 and #20115
don't open relation editor in modal mode

comment:7 Changed 10 days ago by GerdP

Milestone: 20.1120.10

comment:8 Changed 8 days ago by Don-vip

Milestone: 20.1020.11

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.