#19360 closed enhancement (fixed)
[PATCH] Calculating default zoom offset should use existing code infrastructure for HiDPI
| Reported by: | johsin18 | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 20.06 |
| Component: | Core imagery | Version: | |
| Keywords: | Cc: | simon04 |
Description
#18720 added PlatformHook.isHighDpiDisplay(). Let's rather use the existing infrastructure in the HiDPISupport class.
In addition, always setting a zoom offset of 2 whenever the scaling is not exactly identity, falls short in many cases. See the attached patch for my suggested enhancement.
Attachments (2)
Change History (8)
by , 5 years ago
| Attachment: | default-zoom-offset-based-on-HiDPISupport.patch added |
|---|
comment:1 by , 5 years ago
| Summary: | Calculating default zoom offset should use existing code infrastructure for HiDPI → [PATCH] Calculating default zoom offset should use existing code infrastructure for HiDPI |
|---|
by , 5 years ago
| Attachment: | zoom-taking-screen-scaling-into-account.patch added |
|---|
More elegant patch, taking screen scaling into account directly, not the approximate approach via zoom offset.
comment:3 by , 5 years ago
Actually, it would be even better to take screen scaling into account more directly (see my new patch, which does not even use HiDPISupport).
It also improves the "Zoom to native resolution" functionality. However, this patch is more intrusive, and would require more testing. Also, people that have set the zoom offset to 2 already manually, might download too large imagery without really noticing.
In any case, we should remove PlatformHook.isHighDpiDisplay() ASAP before some plugin starts using it and we cannot get rid of it anymore.
Patch for setting the default zoom offset based on HiDPISupport class.