Preset MappingSerbia

[Klumbumbus]

Hi,
your preset https://josm.openstreetmap.de/wiki/PresetsSource?action=diff&version=133 has errors.
For <check /> only the values "on" and "off" are valid, not "yes" and "no".
Also please note that a check has three states: on, off and unset. It is not usefull to set e.g. tunnel=no on every highway=* section that is not a tunnel. So you should remove all these default="no".

[anonymous]

Corrected

[Pedja]

Corrected

[Klumbumbus]

default="yes" is still in

[Pedja]

I guess yes is now invalid value?

[Klumbumbus]

Replying to Klumbumbus:

For <check /> only the values "on" and "off" are valid, not "yes" and "no".

[Klumbumbus]

The new URL (​https://gitlab.com/osm-serbia/mappingserbia-josm-presets/raw/master/MappingSerbia.xml) is not public accessible.

[anonymous]

Sorry, GitLab is a bit confusing. I think it is visible now.

[Klumbumbus]

Next error is empty groups like in line 427-428.
Please test after you make changes. This version and the version before both returned an error when adding the preset to JOSM.

[simon04]

You might want to run the XML schema validation locally (here shown using xmllint from ​http://www.xmlsoft.org/):

$ curl -LO https://gitlab.com/osm-serbia/mappingserbia-josm-presets/raw/master/MappingSerbia.xml
$ curl -LO https://josm.openstreetmap.de/svn/trunk/resources/data/tagging-preset.xsd
$ xmllint --noout --schema tagging-preset.xsd MappingSerbia.xml
MappingSerbia.xml:427: element group: Schemas validity error : Element '{http://josm.openstreetmap.de/tagging-preset-1.0}group': Missing child element(s). Expected is one of ( {http://josm.openstreetmap.de/tagging-preset-1.0}chunk, {http://josm.openstreetmap.de/tagging-preset-1.0}group, {http://josm.openstreetmap.de/tagging-preset-1.0}item, {http://josm.openstreetmap.de/tagging-preset-1.0}separator ).
MappingSerbia.xml:430: element group: Schemas validity error : Element '{http://josm.openstreetmap.de/tagging-preset-1.0}group': Missing child element(s). Expected is one of ( {http://josm.openstreetmap.de/tagging-preset-1.0}chunk, {http://josm.openstreetmap.de/tagging-preset-1.0}group, {http://josm.openstreetmap.de/tagging-preset-1.0}item, {http://josm.openstreetmap.de/tagging-preset-1.0}separator ).
MappingSerbia.xml:433: element group: Schemas validity error : Element '{http://josm.openstreetmap.de/tagging-preset-1.0}group': Missing child element(s). Expected is one of ( {http://josm.openstreetmap.de/tagging-preset-1.0}chunk, {http://josm.openstreetmap.de/tagging-preset-1.0}group, {http://josm.openstreetmap.de/tagging-preset-1.0}item, {http://josm.openstreetmap.de/tagging-preset-1.0}separator ).
MappingSerbia.xml:438: element group: Schemas validity error : Element '{http://josm.openstreetmap.de/tagging-preset-1.0}group': Missing child element(s). Expected is one of ( {http://josm.openstreetmap.de/tagging-preset-1.0}chunk, {http://josm.openstreetmap.de/tagging-preset-1.0}group, {http://josm.openstreetmap.de/tagging-preset-1.0}item, {http://josm.openstreetmap.de/tagging-preset-1.0}separator ).
MappingSerbia.xml:441: element group: Schemas validity error : Element '{http://josm.openstreetmap.de/tagging-preset-1.0}group': Missing child element(s). Expected is one of ( {http://josm.openstreetmap.de/tagging-preset-1.0}chunk, {http://josm.openstreetmap.de/tagging-preset-1.0}group, {http://josm.openstreetmap.de/tagging-preset-1.0}item, {http://josm.openstreetmap.de/tagging-preset-1.0}separator ).
MappingSerbia.xml:444: element group: Schemas validity error : Element '{http://josm.openstreetmap.de/tagging-preset-1.0}group': Missing child element(s). Expected is one of ( {http://josm.openstreetmap.de/tagging-preset-1.0}chunk, {http://josm.openstreetmap.de/tagging-preset-1.0}group, {http://josm.openstreetmap.de/tagging-preset-1.0}item, {http://josm.openstreetmap.de/tagging-preset-1.0}separator ).
MappingSerbia.xml:719: element group: Schemas validity error : Element '{http://josm.openstreetmap.de/tagging-preset-1.0}group': Missing child element(s). Expected is one of ( {http://josm.openstreetmap.de/tagging-preset-1.0}chunk, {http://josm.openstreetmap.de/tagging-preset-1.0}group, {http://josm.openstreetmap.de/tagging-preset-1.0}item, {http://josm.openstreetmap.de/tagging-preset-1.0}separator ).
MappingSerbia.xml:722: element group: Schemas validity error : Element '{http://josm.openstreetmap.de/tagging-preset-1.0}group': Missing child element(s). Expected is one of ( {http://josm.openstreetmap.de/tagging-preset-1.0}chunk, {http://josm.openstreetmap.de/tagging-preset-1.0}group, {http://josm.openstreetmap.de/tagging-preset-1.0}item, {http://josm.openstreetmap.de/tagging-preset-1.0}separator ).
MappingSerbia.xml:731: element group: Schemas validity error : Element '{http://josm.openstreetmap.de/tagging-preset-1.0}group': Missing child element(s). Expected is one of ( {http://josm.openstreetmap.de/tagging-preset-1.0}chunk, {http://josm.openstreetmap.de/tagging-preset-1.0}group, {http://josm.openstreetmap.de/tagging-preset-1.0}item, {http://josm.openstreetmap.de/tagging-preset-1.0}separator ).
MappingSerbia.xml:733: element group: Schemas validity error : Element '{http://josm.openstreetmap.de/tagging-preset-1.0}group': Missing child element(s). Expected is one of ( {http://josm.openstreetmap.de/tagging-preset-1.0}chunk, {http://josm.openstreetmap.de/tagging-preset-1.0}group, {http://josm.openstreetmap.de/tagging-preset-1.0}item, {http://josm.openstreetmap.de/tagging-preset-1.0}separator ).
MappingSerbia.xml:735: element group: Schemas validity error : Element '{http://josm.openstreetmap.de/tagging-preset-1.0}group': Missing child element(s). Expected is one of ( {http://josm.openstreetmap.de/tagging-preset-1.0}chunk, {http://josm.openstreetmap.de/tagging-preset-1.0}group, {http://josm.openstreetmap.de/tagging-preset-1.0}item, {http://josm.openstreetmap.de/tagging-preset-1.0}separator ).
MappingSerbia.xml:737: element group: Schemas validity error : Element '{http://josm.openstreetmap.de/tagging-preset-1.0}group': Missing child element(s). Expected is one of ( {http://josm.openstreetmap.de/tagging-preset-1.0}chunk, {http://josm.openstreetmap.de/tagging-preset-1.0}group, {http://josm.openstreetmap.de/tagging-preset-1.0}item, {http://josm.openstreetmap.de/tagging-preset-1.0}separator ).
MappingSerbia.xml:740: element group: Schemas validity error : Element '{http://josm.openstreetmap.de/tagging-preset-1.0}group': Missing child element(s). Expected is one of ( {http://josm.openstreetmap.de/tagging-preset-1.0}chunk, {http://josm.openstreetmap.de/tagging-preset-1.0}group, {http://josm.openstreetmap.de/tagging-preset-1.0}item, {http://josm.openstreetmap.de/tagging-preset-1.0}separator ).
MappingSerbia.xml:742: element group: Schemas validity error : Element '{http://josm.openstreetmap.de/tagging-preset-1.0}group': Missing child element(s). Expected is one of ( {http://josm.openstreetmap.de/tagging-preset-1.0}chunk, {http://josm.openstreetmap.de/tagging-preset-1.0}group, {http://josm.openstreetmap.de/tagging-preset-1.0}item, {http://josm.openstreetmap.de/tagging-preset-1.0}separator ).
MappingSerbia.xml:744: element group: Schemas validity error : Element '{http://josm.openstreetmap.de/tagging-preset-1.0}group': Missing child element(s). Expected is one of ( {http://josm.openstreetmap.de/tagging-preset-1.0}chunk, {http://josm.openstreetmap.de/tagging-preset-1.0}group, {http://josm.openstreetmap.de/tagging-preset-1.0}item, {http://josm.openstreetmap.de/tagging-preset-1.0}separator ).
MappingSerbia.xml:746: element group: Schemas validity error : Element '{http://josm.openstreetmap.de/tagging-preset-1.0}group': Missing child element(s). Expected is one of ( {http://josm.openstreetmap.de/tagging-preset-1.0}chunk, {http://josm.openstreetmap.de/tagging-preset-1.0}group, {http://josm.openstreetmap.de/tagging-preset-1.0}item, {http://josm.openstreetmap.de/tagging-preset-1.0}separator ).
MappingSerbia.xml fails to validate

[anonymous]

Hmm, I uploaded wrong file...