[Patch] upload dialog does not update object list after first upload, (if Mapillary plugin is installed)

[anonymous]

Upload dialog is not updated between uploads, if Mapillary plugin is installed.

Steps to reproduce:

1. Install Mapillary plugin
2. Edit OSM data
3. Upload OSM data
4. Edit OSM data
5. Upload OSM data <-- upload dialog does not update list of object/s to add/modify/delete. Old objects of the first upload are shown there, the objects list is only updated, if I resize the upload dialog window.

If I revert changeset 15802
https://josm.openstreetmap.de/changeset/15802/josm/trunk/src/org/openstreetmap/josm/gui/io/UploadDialog.java
the update dialog works as expected and everything looks ok.

I had this problem with Ubuntu 18.04, now I tried it with a new installed Ubuntu 20.04, same bug there.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-05-29 21:11:25 +0200 (Fri, 29 May 2020)
Revision:16523
Build-Date:2020-05-30 01:30:48
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (16523 en) Linux Ubuntu 20.04 LTS
Java version: 13.0.3+3-Ubuntu-1ubuntu2, Private Build, OpenJDK 64-Bit Server VM
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
libcommons-compress-java: libcommons-compress-java:all-1.19-1
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:-
VM arguments: [-Djosm.home=<josm.pref>]

Plugins:
+ Mapillary (1.5.23)
+ apache-commons (35362)
+ apache-http (35092)
+ javafx-unixoid (35375)
+ jna (35092)

[anonymous]

I didn't revert the whole changeset r15802, only the part which modifies UploadDialog.java.
I just deleted this line:

super.getPreferredSize();

[taylor.smock]

I was unable to reproduce:

Revision:16524
Is-Local-Build:true
Build-Date:2020-05-31 05:11:18

Identification: JOSM/1.5 (16524 SVN en) Linux Ubuntu 20.04 LTS
Memory Usage: 3212 MB / 3992 MB (607 MB allocated, but free)
Java version: 13.0.3+3-Ubuntu-1ubuntu2, Private Build, OpenJDK 64-Bit Server VM
Screen: :0.0 2560x1440, :0.1 2560x1440
Maximum Screen Size: 2560x1440
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
libcommons-compress-java: libcommons-compress-java:all-1.19-1
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:all-20200323-1
liboauth-signpost-java: liboauth-signpost-java:all-1.2.1.2-3
VM arguments: [-Djosm.home=<josm.pref>]
Dataset consistency test: No problems found

Plugins:
+ Mapillary (1.5.23)
+ apache-commons (35362)
+ apache-http (35092)
+ javafx-unixoid (35375)
+ jna (35092)

Last errors/warnings:
- E: java.lang.UnsatisfiedLinkError: <josm.pref>/plugins/javafx/libfxplugins.so: libgstreamer-lite.so: cannot open shared object file: No such file or directory
- W: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- W: Could not read from URL https://a.mapillary.com/v3/sequences?client_id=UTZhSnNFdGpxSEFFREUwb01GYzlXZzpjNGViMzQxMTIzMjY0MjZm&bbox=-108.5635042%2C39.0297858%2C-108.5470247%2C39.0384197!: java.net.SocketTimeoutException: Read timed out. Cause: java.net.SocketTimeoutException: Read timed out
- E: java.lang.InterruptedException
- E: https://a.mapillary.com/v3/organizations/O0K377md1CVrVkzGu4PV5z?client_id=UTZhSnNFdGpxSEFFREUwb01GYzlXZzpjNGViMzQxMTIzMjY0MjZm
- E: java.io.IOException: stream is closed
- E: Trying to get https://www.mapillary.com/developer/api-documentation/images/traffic_sign/general--traffic-sign--g1.png general--traffic-sign--g1
- W: Failed to download icon. ID unknown to the icon list: general--traffic-sign--g1: java.io.IOException: The requested URL https://www.mapillary.com/developer/api-documentation/images/traffic_sign/general--traffic-sign--g1.png was not found
- E: Trying to get https://www.mapillary.com/developer/api-documentation/images/traffic_sign/information--general-directions--g1.png information--general-directions--g1
- W: Failed to download icon. ID unknown to the icon list: information--general-directions--g1: java.io.IOException: The requested URL https://www.mapillary.com/developer/api-documentation/images/traffic_sign/information--general-directions--g1.png was not found

(Note: This was a local build, but the only code change was for the image viewer).

I have a few questions:
1) What is your desktop environment?
2) Are you running under X or Wayland?
3) Are you able to reproduce if you install an additional plugin?
4) Can you please post screenshots?

For my test, I created a fire hydrant (one object, worked as expected), and then modified road geometry (many modifications, worked as expected). Either there is some subtle difference between setups, or there is something wrong with your java installation.

Can you do me a favor and check if the snap/flatpak JOSM versions have the same issue?

[anonymous]

1) What is your desktop environment?

KDE Plasma 5.10

2) Are you running under X or Wayland?

X

3) Are you able to reproduce if you install an additional plugin?

In addition, I installed utilsplugin2, bug is still reproducible.

4) Can you please post screenshots?

Attached:
1.png: first upload (new path with 3 nodes)
2.png: second upload (new water body, 4 nodes), object list is wrong, shows the list of the first upload
resize2.png: same as 2.png but I resized the upload dialog window a little bit (now the object list is correct)

or there is something wrong with your java installation.

I installed Java from Ubuntu repository, nothing special.

Can you do me a favor and check if the snap/flatpak JOSM versions have the same issue?

Download link please?

[taylor.smock]

Replying to anonymous:

1) What is your desktop environment?

KDE Plasma 5.10

OK. I'll install KDE and see if I can reproduce with that.

2) Are you running under X or Wayland?

X

Thanks. I'll use X when attempting to reproduce it.

3) Are you able to reproduce if you install an additional plugin?

In addition, I installed utilsplugin2, bug is still reproducible.

I didn't expect this to make a difference, but just in case.

4) Can you please post screenshots?

Attached:
1.png: first upload (new path with 3 nodes)
2.png: second upload (new water body, 4 nodes), object list is wrong, shows the list of the first upload
resize2.png: same as 2.png but I resized the upload dialog window a little bit (now the object list is correct)

Thanks.

or there is something wrong with your java installation.

I installed Java from Ubuntu repository, nothing special.

I kind of figured that is was from the Ubuntu repository (apt reinstall openjdk-13-jdk if you want to try reinstalling java).

Can you do me a favor and check if the snap/flatpak JOSM versions have the same issue?

Download link please?

In the terminal, run snap install josm or ​https://flathub.org/apps/details/org.openstreetmap.josm for Flatpak (follow the setup directions -- ​https://flatpak.org/setup/Ubuntu/ ).

[skyper]

Does it happen without any plugin installed? E.g. is it a core issue or related to Mapillary?

[anonymous]

I tested JOSM installed with snap:
snap install josm

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-04-06 02:17:07 +0200 (Mon, 06 Apr 2020)
Revision:16239
Build-Date:2020-04-06 00:18:43
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (16239 en) Linux Ubuntu 20.04 LTS
Memory Usage: 188 MB / 1972 MB (41 MB allocated, but free)
Java version: 11.0.7+10-post-Ubuntu-2ubuntu218.04, Ubuntu, OpenJDK 64-Bit Server VM
VM arguments: [-Duser.home=${HOME}]
Dataset consistency test: No problems found

Same bug, but without any Plugins installed.
Thus in JOSM 16239 installed with snap it seems to be a core issue.

But in JOSM 16523 without snap (it was downloaded from https://josm.openstreetmap.de/josm-latest.jar) the issue occurs only with Mapillary plugin installed (see my original report), thus it seems to be related to Mapillary in this case.

[anonymous]

I am able to reproduce with Kubuntu 20.04 Live-CD inside VirtualBox.
​http://cdimage.ubuntu.com/kubuntu/releases/20.04/release/kubuntu-20.04-desktop-amd64.iso
So the operating system is completely clean.
Latest JOSM 16584 without any plugins.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-06-08 23:23:28 +0200 (Mon, 08 Jun 2020)
Revision:16584
Build-Date:2020-06-09 01:30:47
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (16584 en) Linux Ubuntu 20.04 LTS
Memory Usage: 237 MB / 1236 MB (93 MB allocated, but free)
Java version: 14.0.1+7-Ubuntu-1ubuntu1, Private Build, OpenJDK 64-Bit Server VM
Look and Feel: javax.swing.plaf.metal.MetalLookAndFeel
Screen: :0.0 800x600 (scaling 1.0x1.0)
Maximum Screen Size: 800x600
Best cursor sizes: 16x16 -> 16x16, 32x32 -> 32x32
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
fonts-noto: fonts-noto:-
Dataset consistency test: No problems found

Last errors/warnings:
- E: Bad Request - <html>The OSM server 'api06.dev.openstreetmap.org' reported a bad request.<br><br>The area you tried to download is too big or your request was too large.<br>Either request a smaller area or use an export file provided by the OSM community.</html>

OSM API: https://api06.dev.openstreetmap.org/api

[skyper]

See #18523 for the first changes which did not fix it completely.

[richlv]

I'm seeing the upload dialog at first not show the upload stat area (total object count to be uploaded), any resizing (one px is enough) of the dialog makes the stats pop up - please see the two attached screenshots of the dialog before/after resizing.

Does that have the same cause, or should I open a new ticket?

[richlv]

Before resizing

[richlv]

After resizing

[anonymous]

This patch fixes my list update bug.

[Don-vip]

Another investigation of the same problem in #21387

[Don-vip]

Closed as duplicate of #21387.