Modify

Opened 5 weeks ago

Closed 12 days ago

#19320 closed enhancement (fixed)

add link to taghistory.raifer.tech

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 20.06
Component: Core Version:
Keywords: template_report Cc: tyr_asd

Description

Since taghistory now supports permalinks it would be nice if there would be a link below the taginfo link in the context menu of the Tags/Membership panel.

For a simple tag the link is e.g. https://taghistory.raifer.tech/#***/playground/swing

Attachments (1)

raifer.PNG (50.4 KB) - added by GerdP 3 weeks ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 3 weeks ago by simon04

Resolution: fixed
Status: newclosed

In 16596/josm:

fix #19320 - Add links to taghistory.raifer.tech

comment:2 Changed 3 weeks ago by simon04

Milestone: 20.06

comment:3 Changed 3 weeks ago by GerdP

The data at taghistory.raifer.tech seems out-dated. There seems to be no new data since end of 2018?
Or maybe data was not collected for quite a while? One has to zoom out when a well known tag is checked.
https://taghistory.raifer.tech/#***/landuse/farmland

It seems that tags which contain : cause problems, try e.g. addr:city=Bassum

Last edited 3 weeks ago by GerdP (previous) (diff)

comment:4 Changed 3 weeks ago by GerdP

Resolution: fixed
Status: closedreopened

Link that works:
https://taghistory.raifer.tech/#***/addr:city/Bassum

Generated by JOSM:
https://taghistory.raifer.tech/#***/addr%3Acity/Bassum

Not sure if this has to be fixed in JOSM or on the server side?

comment:5 in reply to:  3 Changed 3 weeks ago by Klumbumbus

Replying to GerdP:

The data at taghistory.raifer.tech seems out-dated. There seems to be no new data since end of 2018?

Yes, there was no data update for a longer time, but the dashed line ends always at the current real tag count.

Changed 3 weeks ago by GerdP

Attachment: raifer.PNG added

comment:6 Changed 3 weeks ago by GerdP

Yes, I understood that after zooming out. On my machine, the link to landuse=farmland shows this result. Maybe there is an option to show the full curve?

comment:7 in reply to:  6 Changed 3 weeks ago by Klumbumbus

Replying to GerdP:

Yes, I understood that after zooming out. On my machine, the link to landuse=farmland shows this result. Maybe there is an option to show the full curve?

I wanted to create an issue for that for a longer time. Now I did: https://github.com/tyrasd/taghistory/issues/30

comment:8 Changed 3 weeks ago by Klumbumbus

Cc: tyr_asd added

comment:9 in reply to:  4 Changed 3 weeks ago by anonymous

Replying to GerdP:

Link that works:
https://taghistory.raifer.tech/#***/addr:city/Bassum

Generated by JOSM:
https://taghistory.raifer.tech/#***/addr%3Acity/Bassum

Not sure if this has to be fixed in JOSM or on the server side?

":" is a reserved character, but that does not necessarily mean it must be encoded.

Anyway also
https://taghistory.raifer.tech/#***/addr:municipality=København (which is generated by the server itself, but encoded by the browser)
does not work, so I'd say the server must be fixed to use and accept proper encoding for the permalink.

comment:10 Changed 3 weeks ago by simon04

In 16606/josm:

see #19320 - Fix URL encoding for taghistory.raifer.tech

comment:11 in reply to:  10 Changed 3 weeks ago by stoecker

Replying to simon04:

In 16606/josm:

see #19320 - Fix URL encoding for taghistory.raifer.tech

That's no fix, but a workaround. UTF-8 should not be transfered via URL unencoded, see previous comment.

comment:12 Changed 3 weeks ago by simon04

In RFC 3986, I could not find anything forbidding : in the fragment part. Some related quotations:

https://tools.ietf.org/html/rfc3986#section-2.2

reserved = gen-delims / sub-delims
gen-delims = ":" / "/" / "?" / "#" / "[" / "]" / "@"
sub-delims = "!" / "$" / "&" / "'" / "(" / ")" / "*" / "+" / "," / ";" / "="
These characters are called "reserved" because they may (or may not) be defined as delimiters by the generic syntax.

https://tools.ietf.org/html/rfc3986#section-3.5

The characters slash ("/") and question mark ("?") are allowed to represent data within the fragment identifier.

I do not plan to do more research, considering that the use-case is not critical at all within JOSM.

comment:13 Changed 12 days ago by simon04

Resolution: fixed
Status: reopenedclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.