Modify

Opened 2 weeks ago

Closed 13 days ago

Last modified 13 days ago

#19261 closed enhancement (fixed)

maxspeed:advisory

Reported by: Famlam Owned by: team
Priority: normal Milestone: 20.05
Component: Internal preset Version:
Keywords: maxspeed maxspeed:advisory validator Cc:

Description

What steps will reproduce the problem?

  1. Use maxspeed:advisory on a road with an advisory speed limit
  2. Key not recognised by validator (nor by autocomplete)

What is the expected result?

Recognised key (verifiable, as it's determined by the presence of specific road signs & documented in the wiki & used over 35000 times)
https://wiki.openstreetmap.org/wiki/Key:maxspeed:advisory

What happens instead?

Validator warning about unknown key

Please provide any additional information below. Attach a screenshot if possible.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-04-06 02:17:07 +0200 (Mon, 06 Apr 2020)
Build-Date:2020-04-06 00:18:43
Revision:16239
Relative:URL: ^/trunk

Identification: JOSM/1.5 (16239 nl) Windows 10 64-Bit
OS Build number: Windows 10 Home 1909 (18363)
Memory Usage: 937 MB / 1820 MB (360 MB allocated, but free)
Java version: 1.8.0_251-b08, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1920x1080
Maximum Screen Size: 1920x1080
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35414)
+ changeset-viewer (22)
+ imagery_offset_db (35405)
+ pt_assistant (2.1.10-79-gb14a159)
+ tageditor (35258)
+ turnlanes-tagging (283)
+ undelete (35405)
+ utilsplugin2 (35434)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Attachments (0)

Change History (5)

comment:1 Changed 2 weeks ago by skyper

Component: Core validatorInternal preset

Is this a key for presets or should it be ignored?

comment:2 Changed 2 weeks ago by anonymous

Maybe it would be an idea to make a separate maxspeed preset, to set less-common maxspeed:* keys, with a link to set this in the highway=X-presets (*=forward/backward/advisory/advisory:backward/advisory:forward)?

I think that adding it to the regular highway=X presets would clutter the UI too much, as maxspeed:* is common, but not that common to apply for very many ways.
(Besides, there's the risk that people will give their own 'advice' rather than a traffic-sign-dictated advice, if not accompanied with a small explanation)

Otherwise, I'd add it to the ignore list

comment:3 in reply to:  2 Changed 2 weeks ago by skyper

Replying to anonymous:

Maybe it would be an idea to make a separate maxspeed preset, to set less-common maxspeed:* keys, with a link to set this in the highway=X-presets (*=forward/backward/advisory/advisory:backward/advisory:forward)?

maxspeed:forward/backward is already present more than once. Usually, such tags are lying in external presets, e.g. you need to have the external preset installed to calm validator.

I think that adding it to the regular highway=X presets would clutter the UI too much, as maxspeed:* is common, but not that common to apply for very many ways.

+1

As the position for preset_link is adjustable now, we need to think about better/more linking. The "Road Restriction" preset is one exception but with #18992 not fixed, I did not start to play around and see what is possible.
I have similar issues with the Lane attributes preset.

(Besides, there's the risk that people will give their own 'advice' rather than a traffic-sign-dictated advice, if not accompanied with a small explanation)

It is the job of the preset to supply enough information that it is not misinterpreted.

comment:4 Changed 13 days ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 16478/josm:

fix #19261 - Add maxspeed:advisory

comment:5 Changed 13 days ago by Klumbumbus

Milestone: 20.05

Added in the Road Restrictions preset.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.