Opened 5 years ago
Last modified 23 months ago
#18992 new defect
Tagging Preset: No information exchange between linked presets
Reported by: | skyper | Owned by: | team |
---|---|---|---|
Priority: | major | Milestone: | |
Component: | Core | Version: | |
Keywords: | template_report tagging preset link | Cc: |
Description (last modified by )
What steps will reproduce the problem?
- Have a untagged way selected
- Open any highway preset
- Check
oneway
(checked) - Click on highway/street/road restriction and look at
oneway
check (unchecked) - Check
toll
(checked) and apply - Have a look at
toll
check (unchecked)
What is the expected result?
oneway
is checked in both preset after 3.toll
is checked in both preset after 5.
What happens instead?
oneway
is not checked in 4. and 5.toll
is not checked in 6.
In fact all duplicate keys in the linked preset will never have an effect and are silently ignored.
Please provide any additional information below. Attach a screenshot if possible.
I stumbled over this creating the Presets/MastAndTower and first ignored it as we could say, having the same key in two presets and linking from one to another is not a good idea but as it happens already within defaultpresets, I called it a defect. I did not check all available tagging presets but name
, ref
and operator
are candidates for the same issue so not only checkboxes are a problem.
Relative:URL: ^/trunk Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b Last:Changed Date: 2020-03-24 07:37:08 +0100 (Tue, 24 Mar 2020) Revision:16200 Build-Date:2020-03-25 02:30:51 URL:https://josm.openstreetmap.de/svn/trunk
Attachments (0)
Change History (6)
comment:1 by , 5 years ago
Summary: | Tagging Preset: No information exchange between preset links → Tagging Preset: No information exchange between linked presets |
---|
comment:2 by , 5 years ago
comment:3 by , 5 years ago
Description: | modified (diff) |
---|
comment:5 by , 4 years ago
Priority: | normal → major |
---|
As more and more presets include preset_links and it is almost impossible to prevent any duplicate key in the linked preset, it would be nice, if this could be fixed.
comment:6 by , 23 months ago
This is impossible to solve in the present state of affairs, because the dialogs do not talk to each other but each dialog talks only to the DataSet. The second dialog opens at a time when the first dialog has not yet written the changed data back to the DataSet, so the second dialog cannot know.
In #21851 I proposed a rewrite of the preset system that doesn't have this limitation: the dialogs talk through handles and the handles can be connected either to the DataSet or to another dialog. It would then be easy to implement this function.
I would like to add a preset_link to the "Name" preset from almost all cases where
name=*
is present in defaultpresets but this ticket rather prevents it for now.