[Patch] Windows menu needs an own help topic

[Hb---]

Currently the Windows menu lacks of an own help topic. It shares one [1] with the Toggle/Sidebar actions [2] named /Help/ToggleDialogs [3].

Maintenance, context sensitivity and translation are lacking under this bad structure. Help pages with only one topic are best.

So MainMenu.java needs to be changed to create an own target topic [4].
Target should be /Help/Menu/Windows [5].

[1] https://josm.openstreetmap.de/browser/trunk/src/org/openstreetmap/josm/gui/MainMenu.java#L405

[2] https://josm.openstreetmap.de/browser/trunk/src/org/openstreetmap/josm/actions/DialogsToggleAction.java#L37

[3] https://josm.openstreetmap.de/wiki/Help/ToggleDialogs

[4] https://josm.openstreetmap.de/wiki/DevelopersGuide/HelpSystem/HelpTopicsList

[5] https://josm.openstreetmap.de/wiki/Help/Menu/Windows

[Hb---]

Patch to replace /ToggleDialogs with /Help/Menu/Windows/

[Hb---]

Same patch, new file extension

[skyper]

The patches do not include the corresponding file.

[Hb---]

Same patch, starting with directory structure here: https://josm.openstreetmap.de/browser/josm/trunk

[Don-vip]

In 16102/josm:

fix #18768 - add own help topic to Windows menu (patch by Hb---)

[Hb---]

Thanks for submitting, but it turns out that my patch was crap. I missed the correct directory structure.

Currently the help topic is /Help/Windows
It needs to be /Help/Menu/Windows

The new patch is attached.

[Hb---]

To target Help/Menu/Windows

[Klumbumbus]

In 16103/josm:

fix #18768 - Fix Windows menu help topic (patch by Hb---)

[Don-vip]

In 16105/josm:

see #18768 - checkstyle

[Klumbumbus]

Aww, and I was so confident that I won't screw this up... :D

[Don-vip]

I probably would have missed it too :D

[leni]

Is there an impact for the translated pages? What happens to /ToggleDialogs pages?

Is it enough to add the translation macro to Help/Menu/Windows and create the xx:Help/Menu/Windows pages?

[Hb---]

Replying to leni:

What happens to /ToggleDialogs pages?

That page remains and is now solely for the Editbar and the Sidebar.

Is it enough to add the translation macro to Help/Menu/Windows and create the xx:Help/Menu/Windows pages?

Yes. But the original page in English is currently incomplete and describes only two parts of the menu. Please see https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/gui/MainMenu.java?rev=16102#L399 for the third group.

[skyper]

This fix included the wrong path, see #21000.

[Klumbumbus]

In 17925/josm:

fix #21000, see #18768 - Fix Windows menu help topic (patch by skyper)