Modify

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#18768 closed defect (fixed)

[Patch] Windows menu needs an own help topic

Reported by: Hb--- Owned by: team
Priority: trivial Milestone: 20.03
Component: Core Version:
Keywords: help Cc:

Description

Currently the Windows menu lacks of an own help topic. It shares one [1] with the Toggle/Sidebar actions [2] named /Help/ToggleDialogs [3].

Maintenance, context sensitivity and translation are lacking under this bad structure. Help pages with only one topic are best.

So MainMenu.java needs to be changed to create an own target topic [4].
Target should be /Help/Menu/Windows [5].

[1] https://josm.openstreetmap.de/browser/trunk/src/org/openstreetmap/josm/gui/MainMenu.java#L405

[2] https://josm.openstreetmap.de/browser/trunk/src/org/openstreetmap/josm/actions/DialogsToggleAction.java#L37

[3] https://josm.openstreetmap.de/wiki/Help/ToggleDialogs

[4] https://josm.openstreetmap.de/wiki/DevelopersGuide/HelpSystem/HelpTopicsList

[5] https://josm.openstreetmap.de/wiki/Help/Menu/Windows

Attachments (4)

18768patch.diff (711 bytes) - added by Hb--- 3 months ago.
Patch to replace /ToggleDialogs with /Help/Menu/Windows/
18768.patch (711 bytes) - added by Hb--- 3 months ago.
Same patch, new file extension
full-path-18768.patch (802 bytes) - added by Hb--- 3 months ago.
Same patch, starting with directory structure here: https://josm.openstreetmap.de/browser/josm/trunk
second-18768.patch (755 bytes) - added by Hb--- 3 months ago.
To target Help/Menu/Windows

Download all attachments as: .zip

Change History (17)

Changed 3 months ago by Hb---

Attachment: 18768patch.diff added

Patch to replace /ToggleDialogs with /Help/Menu/Windows/

Changed 3 months ago by Hb---

Attachment: 18768.patch added

Same patch, new file extension

comment:1 Changed 3 months ago by Hb---

Summary: Windows menu needs an own help topic[Patch] Windows menu needs an own help topic

comment:2 Changed 3 months ago by skyper

The patches do not include the corresponding file.

Changed 3 months ago by Hb---

Attachment: full-path-18768.patch added

Same patch, starting with directory structure here: https://josm.openstreetmap.de/browser/josm/trunk

comment:3 Changed 3 months ago by Hb---

Milestone: 20.03

comment:4 Changed 3 months ago by Don-vip

Priority: normaltrivial

comment:5 Changed 3 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 16102/josm:

fix #18768 - add own help topic to Windows menu (patch by Hb---)

comment:6 Changed 3 months ago by Hb---

Thanks for submitting, but it turns out that my patch was crap. I missed the correct directory structure.

Currently the help topic is /Help/Windows
It needs to be /Help/Menu/Windows

The new patch is attached.

Changed 3 months ago by Hb---

Attachment: second-18768.patch added

To target Help/Menu/Windows

comment:7 Changed 3 months ago by Hb---

Resolution: fixed
Status: closedreopened

comment:8 Changed 3 months ago by Klumbumbus

Resolution: fixed
Status: reopenedclosed

In 16103/josm:

fix #18768 - Fix Windows menu help topic (patch by Hb---)

comment:9 Changed 3 months ago by Don-vip

In 16105/josm:

see #18768 - checkstyle

comment:10 Changed 3 months ago by Klumbumbus

Aww, and I was so confident that I won't screw this up... :D

comment:11 Changed 3 months ago by Don-vip

I probably would have missed it too :D

comment:12 Changed 3 months ago by leni

Is there an impact for the translated pages? What happens to /ToggleDialogs pages?

Is it enough to add the translation macro to Help/Menu/Windows and create the xx:Help/Menu/Windows pages?

comment:13 in reply to:  12 Changed 3 months ago by Hb---

Replying to leni:

What happens to /ToggleDialogs pages?

That page remains and is now solely for the Editbar and the Sidebar.

Is it enough to add the translation macro to Help/Menu/Windows and create the xx:Help/Menu/Windows pages?

Yes. But the original page in English is currently incomplete and describes only two parts of the menu. Please see https://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/gui/MainMenu.java?rev=16102#L399 for the third group.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.