changeset manager: No download area after downloading modified objects

[skyper]

What steps will reproduce the problem?

1. open changeset manager
2. enter a changeset number (​78281753) at the top and download changeset information
3. select changeset
4. download modified objects

What is the expected result?

Download area is shown. As there is no certainty that the data is complete, there should be no download area and all striped in background.

What happens instead?

No download area calculated and no strips

Please provide any additional information below. Attach a screenshot if possible.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2019-12-11 01:40:30 +0100 (Wed, 11 Dec 2019)
Revision:15582
Build-Date:2019-12-11 02:30:55
URL:https://josm.openstreetmap.de/svn/trunk

Identification: JOSM/1.5 (15582 en) Linux Debian GNU/Linux 10 (buster)
Memory Usage: 349 MB / 964 MB (151 MB allocated, but free)
Java version: 11.0.5+10-post-Debian-1deb10u1, Debian, OpenJDK 64-Bit Server VM
Java package: openjdk-11-jre:amd64-11.0.5+10-1~deb10u1
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-22
libcommons-compress-java: libcommons-compress-java:all-1.18-2
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:all-20181227-1
Dataset consistency test: No problems found

Last errors/warnings:
- W: No configuration settings found.  Using hardcoded default values for all pools.

[GerdP]

When you download the changed objects there is no download area. I think we only render stripes when there is at least one download area. Same happens when you download a single object or a list of objects.

[skyper]

Replying to GerdP:

When you download the changed objects there is no download area. I think we only render stripes when there is at least one download area. Same happens when you download a single object or a list of objects.

I do not really care about rendering, though this is optional anyway, but I care about validator and about conflicts on upload plus relation consistency. And there we need the download area to determine incomplete data.

[GerdP]

We can consider a layer without a download area containing old data (objects with positive ids) as incomplete.
Maybe should not even allow to upload when we have any new or modified data that is not in a downloaded area?
The problem also occurs when you move an old node out of the download area.

[skyper]

Is it not easier to consider all incomplete as long as we are not 100% sure, like the change/fix with Overpass ?
The rendering of the area is already optional and customizable.

Replying to GerdP:

We can consider a layer without a download area containing old data (objects with positive ids) as incomplete.
Maybe should not even allow to upload when we have any new or modified data that is not in a downloaded area?

How does this work with "update data"/"update selected"?

In general, I hate regulation and do not know how people work.
Reverting changesets or certain edits come to my mind thinking about scenarios.
Overpass queries are mostly incomplete, too.

The problem also occurs when you move an old node out of the download area.

Thought there is a ticket about this but I do not find it.

[skyper]

Replying to skyper:

Replying to GerdP:

The problem also occurs when you move an old node out of the download area.

The opposite is even worse. Moving from outside to inside.

Thought there is a ticket about this but I do not find it.

Did open #18419.

[mdk]

Replying to skyper:

The problem also occurs when you move an old node out of the download area.

Thought there is a ticket about this but I do not find it.

I think you mean #10999

[GerdP]

Can we close this as invalid?

[skyper]

Replying to skyper:

Replying to GerdP:

When you download the changed objects there is no download area. I think we only render stripes when there is at least one download area. Same happens when you download a single object or a list of objects.

I do not really care about rendering, though this is optional anyway, but I care about validator and about conflicts on upload plus relation consistency. And there we need the download area to determine incomplete data.

Did not check, yet, if all validator test produce the same results without a download area and with one or more small bboxes. Gonna open new ticket if I find a problem.

[GerdP]

If they all produce the same results something would be wrong.

[skyper]

josm_way_end_node_near_other.joz​ first example with different results. All layer contain the same data. Only difference is a minimal download area bbox without any data in DataArea.osm. I get warnings about Way end node near other highway (2) and Way end node near other way (2) with no download area which are not present with the download area. locked=true seems to influence validator, too, so use the two layers without _locked.

[GerdP]

Yes, this is intended. We have a lot of validator checks which will not check objects outside of the download area. These differences also show up sometimes when you validate a selection.
A test like "Way end node near other highway" makes no sense when the node is outside of the download area, isn't that obvious?

[GerdP]

BTW: This ticket is closed and the subject is about Changeset Manager. No idea how these findings are related to it.

[skyper]

Replying to GerdP:

Yes, this is intended. We have a lot of validator checks which will not check objects outside of the download area. These differences also show up sometimes when you validate a selection.
A test like "Way end node near other highway" makes no sense when the node is outside of the download area, isn't that obvious?

I know that the test should not be run outside of download area but it is as shown in the example.

These findings are exactly the problems I have if you have no download area at all. The results should be the same, no warnings, with minimal download area and without any download area. Both time the objects are outside of download area but the test is still run if there is no download area at all.

[GerdP]

Your example file josm_way_end_node_near_other.joz doesn't contain OSM data. What do I do with it?
I assume you created a sample were a small download area is around a node?

[skyper]

correct example session with files

[skyper]

Sorry, forgot to added the osm layers. Did replace it with the correct file. Please, use the two unlocked layers.

[GerdP]

So, what do you try to point out? Do you think the "Way end node near other highway" test should also be skipped when there is no download area?

[skyper]

Yeah, the behaviour without any download area should be the same as outside download area. All test involving other objects should be shipped as complete data is needed. New ticket ?

[GerdP]

Yes, new ticket.

[skyper]

Replying to GerdP:

Yes, new ticket.

See #22847