Opened 7 years ago

Last modified 5 years ago

#17633 closed enhancement

complain about even more descriptive names and propose to delete them [PATCH] — at Version 17

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 19.05
Component: Core validator Version:
Keywords: name Cc:

Description (last modified by mkoniecz)

Patch at https://josm.openstreetmap.de/ticket/17633#comment:16

Updated list of suspicious names used more than 2000 times to check:

Please provide any additional information below. Attach a screenshot if possible.

http://overpass-turbo.eu/s/I7p http://overpass-turbo.eu/s/I7r http://overpass-turbo.eu/s/I7t

Next part of https://josm.openstreetmap.de/ticket/17100 and https://josm.openstreetmap.de/ticket/17629

To be added in https://josm.openstreetmap.de/browser/josm/trunk/data/validator/unnecessary.mapcss#L93

Many were matched in https://josm.openstreetmap.de/changeset/15005/josm but some still remain

Change History (17)

comment:1 by mkoniecz, 7 years ago

For name=Path: highway=path dominates, but I plan on matching also relatively rare highway=footway and highway=cycleway to do not encourage people to keep name and switch to highway=footway.

comment:2 by mkoniecz, 7 years ago

For name=School that for some bizarre reason is on large scale used in countries without English used as a local language (probably ow quality HOT edits were the reason) should be matched and removed on amenity=school, building=school and get warnings on building=*.

comment:3 by mkoniecz, 7 years ago

Description: modified (diff)

comment:4 by mkoniecz, 7 years ago

Description: modified (diff)

comment:5 by mkoniecz, 7 years ago

Description: modified (diff)

comment:6 by mkoniecz, 7 years ago

Description: modified (diff)

comment:7 by mkoniecz, 7 years ago

Description: modified (diff)

comment:8 by mkoniecz, 7 years ago

Description: modified (diff)

comment:9 by mkoniecz, 7 years ago

Whops, many of them were already added in https://josm.openstreetmap.de/changeset/15005/josm

comment:10 by mkoniecz, 7 years ago

Description: modified (diff)

comment:11 by mkoniecz, 7 years ago

Description: modified (diff)

comment:12 by mkoniecz, 7 years ago

Description: modified (diff)

comment:13 by Don-vip, 7 years ago

Yep sorry I didn't mention my analysis:

​casa: 4902 "houses" in Spanish? > added for building=house
​Markt: 3960 "markets" in German? > not added, appears for streets, not markets
​Аптека: 3824 pharmacies in Russian > added for amenity=pharmacy
​Bahnhof: 2872 "railway stations" in German? > not added, appears for streets and some buildings where railway=station is not set
​Plebania: 2794 "presbitaries" in Polish? > not added, we should check with Polish community
​Kancelaria: 2757 "offices" in Polish? > not added, we should check with Polish community
​Столовая: 2648 "canteens" in Russian? > not added, there is no osm tag for "canteen" I think
​School: 2550 schools? > added for amenity=school
​مسجد: 2445 "mosques" in Persian? - yes, see ​https://fa.wikipedia.org/wiki/%D9%85%D8%B3%D8%AC%D8%AF > added
​Школа: 2436 "schools" in Russian? - yes, it should be treated like name=school > added
​.: 2429 WTF? > I didn't check yet
​Calvaire: 2223 calvaries in French > not sure. wayside cross does not have exactly the same meaning, so I didn't add it
​Park: "" in ? > appears to have a lot of locations named "Park"
​Siedlung: 2188 "settlements" in German? > same, so I didn't add it

comment:14 by mkoniecz, 7 years ago

​Park: "" in ? > appears to have a lot of locations named "Park"

1400 leisure=park name=Park seems to be a legit validator targets - http://overpass-turbo.eu/s/I92

​Plebania: 2794 "presbitaries" in Polish? > not added, we should check with Polish community

This is on a border of descriptive name and real name. Given that removal of blatant descriptive names is controversial for some I would not introduce this check (as may be obvious from my stream of issues/patches related to descriptive names I strongly dislike them, but I would hesitate here)

​Kancelaria: 2757 "offices" in Polish? > not added, we should check with Polish community

This is probably mostly for parish offices. The same situation as with plebania. I would not do anything for now and revisit it after blatant descriptive names are purged. I would not remove it manually in my usual editing.

.

Dot as name probably makes no sense at all, but it is not a descriptive name. I would give it a separate check.

​Siedlung

Not sure here what should be done with it, unfamiliar with meaning here.

Last edited 7 years ago by mkoniecz (previous) (diff)

comment:15 by mkoniecz, 7 years ago

Overall, I would add rules for

leisure=park name=Park - 1400 cases, ​http://overpass-turbo.eu/s/I92

name=. but as a separate rule (suspicious tags?)

There is also about 200-300 cases of name=School on buildings without amenity=school, it may be worth adding rule for that - http://overpass-turbo.eu/s/I95

comment:16 by mkoniecz, 7 years ago

Last edited 7 years ago by mkoniecz (previous) (diff)

comment:17 by mkoniecz, 7 years ago

Description: modified (diff)
Summary: complain about even more descriptive names and propose to delete themcomplain about even more descriptive names and propose to delete them [PATCH]
Note: See TracTickets for help on using tickets.