Modify

Opened 7 weeks ago

Closed 6 weeks ago

Last modified 6 weeks ago

#16891 closed enhancement (fixed)

[Patch] Define custom browser on Windows

Reported by: iman Owned by: simon04
Priority: normal Milestone: 18.11
Component: Core Version: latest
Keywords: default internet browser windows Cc:

Description

Hi, can we set another default browser to open links? I use Firefox portable and would like to open links using it instead of default browser of Windows.

Attachments (2)

16891.patch (2.8 KB) - added by simon04 6 weeks ago.
16891v2.patch (5.2 KB) - added by simon04 6 weeks ago.

Download all attachments as: .zip

Change History (19)

comment:1 Changed 7 weeks ago by Klumbumbus

Type: taskenhancement

comment:2 Changed 7 weeks ago by Don-vip

It should be possible to set portable firefox as default browser, see https://superuser.com/questions/287313/which-registry-keys-need-to-be-edited-to-change-the-default-browser

Can you please test?

comment:3 Changed 7 weeks ago by Don-vip

Owner: changed from team to iman
Status: newneedinfo

comment:4 Changed 7 weeks ago by anonymous

Not the original poster, but:
The need to set registry keys does defeat the "portable" aspect. I know many people are using portable apps "stationary", but JOSM and portable browser both can work truly portable, you can get java portable as well. For me, setting the path in JOSM directly is something I would love to see as well.

comment:5 in reply to:  4 Changed 7 weeks ago by iman

Replying to Don-vip:

It should be possible to set portable firefox as default browser

Thanks, I think it's possible, but it's not the problem. This PC is shared by others and I don't want they use my browser, or, by using their browser my history be easily accesible by them.

Replying to anonymous:

For me, setting the path in JOSM directly is something I would love to see as well.

This is exactly what I would love to do, too.

comment:6 Changed 7 weeks ago by simon04

Presumably you're using Windows? For Linux configurability, see #5108.

For Windows we could similarly implement an advanced setting browser.windows. If this preference is set, the specified program is launched in favour of the default.

comment:7 Changed 6 weeks ago by iman

Yes, I'm on Windows.
It's great if you implement that.

comment:8 Changed 6 weeks ago by Don-vip

Keywords: windows added
Summary: default internet browserDefine custom browser on Windows

comment:9 Changed 6 weeks ago by simon04

Owner: changed from iman to team
Status: needinfonew

Changed 6 weeks ago by simon04

Attachment: 16891.patch added

comment:10 Changed 6 weeks ago by simon04

Milestone: 18.11
Owner: changed from team to simon04
Summary: Define custom browser on Windows[Patch] Define custom browser on Windows

comment:11 Changed 6 weeks ago by Don-vip

I guess we can include it in 18.10 (no i18n strings).
Some remarks:

  • the if could be simplified to if PlatformManager.getPlatform() != null
  • we don't use star imports (import java.awt.*;)

Changed 6 weeks ago by simon04

Attachment: 16891v2.patch added

comment:12 Changed 6 weeks ago by simon04

I think we can simplify the code further, see attachment:16891v2.patch, but let's keep that for 18.11 to avoid introducing bugs in the last minute :).

comment:13 Changed 6 weeks ago by simon04

Resolution: fixed
Status: newclosed

In 14389/josm:

fix #16891 - Allow to override default web browser on Windows

Set the advanced preference key browser.windows to the browser executable.

comment:14 Changed 6 weeks ago by Klumbumbus

Any idea where this could be documented in the wiki for end users? Else I fear this feature will be used by only 1 person forever as nobody else knows about this preference key.

comment:15 Changed 6 weeks ago by Don-vip

Here: Help/Action/Help

EDIT: woops no, messed up things

Last edited 6 weeks ago by Don-vip (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain simon04.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.