Ticket #16891: 16891.patch

src/org/openstreetmap/josm/tools/OpenBrowser.java

@@ -42 +42 @@
 
         if (Desktop.isDesktopSupported()) {
             try {
-                if (PlatformManager.isPlatformWindows()) {
-                    // Desktop API works fine under Windows, so we don't try any fallback in case of I/O exceptions because it's not API's fault
-                    Desktop.getDesktop().browse(uri);
-                } else if (PlatformManager.isPlatformUnixoid() || PlatformManager.isPlatformOsx()) {
+                if (PlatformManager.isPlatformWindows() || PlatformManager.isPlatformUnixoid() || PlatformManager.isPlatformOsx()) {
                     // see #5629 #5108 #9568
                     PlatformManager.getPlatform().openUrl(uri.toString());
                 } else {

src/org/openstreetmap/josm/tools/PlatformHookWindows.java

@@ -30 +30 @@
 import static org.openstreetmap.josm.tools.Utils.getSystemProperty;
 import static org.openstreetmap.josm.tools.WinRegistry.HKEY_LOCAL_MACHINE;
 
-import java.awt.GraphicsEnvironment;
+import java.awt.*;
 import java.io.BufferedWriter;
 import java.io.File;
 import java.io.IOException;
@@ -39 +39 @@
 import java.io.OutputStreamWriter;
 import java.io.Writer;
 import java.lang.reflect.InvocationTargetException;
+import java.net.URI;
+import java.net.URISyntaxException;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.DirectoryIteratorException;
 import java.nio.file.DirectoryStream;
@@ -187 +189 @@
 
     @Override
     public void openUrl(String url) throws IOException {
-        Runtime.getRuntime().exec(new String[]{"rundll32", "url.dll,FileProtocolHandler", url});
+        final String customBrowser = Config.getPref().get("browser.windows", null);
+        if (customBrowser != null) {
+            Runtime.getRuntime().exec(new String[]{customBrowser, url});
+            return;
+        }
+        try {
+            // Desktop API works fine under Windows
+            Desktop.getDesktop().browse(new URI(url));
+        } catch (IOException | URISyntaxException e) {
+            Logging.log(Logging.LEVEL_WARN, "Desktop class failed. Platform dependent fall back for open url in browser.", e);
+            Runtime.getRuntime().exec(new String[]{"rundll32", "url.dll,FileProtocolHandler", url});
+        }
     }
 
     @Override