Modify

#16846 closed defect (fixed)

[Patch] Manual adjust in geotagging images does not take last time set

Reported by: maarten Owned by: team
Priority: normal Milestone: 19.04
Component: Core image mapping Version: latest
Keywords: correlate regression Cc:

Description (last modified by Don-vip)

When correlating images to a GPX track, you can use manual adjust to get te correct time. When you use this, the new time in the dialog is different from the previous set time.
See the screenshots, I'm starting with a 101.7 seconds offset (geotag1.png), then I press "Manual adjust" and the adjustment dialog (geotag2.png) is set to a 1 minute 5.7 seconds (65.7 seconds) offset.
I think this offset should be set to the same offset as the previous dialog.

JOSM 14289, java 1.8.0_181, Windows 7x64



Attachments (7)

Geotag1.png (20.6 KB) - added by maarten 20 months ago.
Geotag2.png (9.9 KB) - added by maarten 20 months ago.
20181013.gpx (3.1 MB) - added by maarten 20 months ago.
GPS track
IMG_9965.JPG (1.7 MB) - added by maarten 20 months ago.
IMG_9969.JPG (1.1 MB) - added by maarten 20 months ago.
IMG_9985.JPG (1.0 MB) - added by maarten 20 months ago.
16846-manualadjust.diff (958 bytes) - added by Bjoeni 14 months ago.

Change History (15)

Changed 20 months ago by maarten

Attachment: Geotag1.png added

Changed 20 months ago by maarten

Attachment: Geotag2.png added

comment:1 Changed 20 months ago by maarten

Description: modified (diff)

comment:2 Changed 20 months ago by Don-vip

Description: modified (diff)
Owner: changed from team to maarten
Status: newneedinfo

Can you please attach a sample gpx file and enough pictures to reproduce the problem? Thanks.

comment:3 Changed 20 months ago by Don-vip

Component: CoreCore image mapping
Keywords: image geotag removed

Changed 20 months ago by maarten

Attachment: 20181013.gpx added

GPS track

Changed 20 months ago by maarten

Attachment: IMG_9965.JPG added

Changed 20 months ago by maarten

Attachment: IMG_9969.JPG added

Changed 20 months ago by maarten

Attachment: IMG_9985.JPG added

comment:4 Changed 20 months ago by maarten

I've added a track and some photo's.

comment:5 Changed 20 months ago by Don-vip

Owner: changed from maarten to team
Status: needinfonew

comment:6 Changed 14 months ago by Bjoeni

Keywords: regression added
Summary: Manual adjust in geotagging images does not take last time set[Patch] Manual adjust in geotagging images does not take last time set

Regression of #12486 in 9742/josm:

Allowing sub-second offset means measuring in deciseconds instead of seconds, therefore % 600 instead of % 60 has to be used for remainder.

Changed 14 months ago by Bjoeni

Attachment: 16846-manualadjust.diff added

comment:7 Changed 14 months ago by Don-vip

Milestone: 19.04

comment:8 Changed 14 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 14981/josm:

fix #16846 - Manual adjust in geotagging images does not take last time set (regression from r9742, patch by Bjoeni)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.