Modify

Opened 9 months ago

Closed 6 months ago

Last modified 5 months ago

#16147 closed enhancement (fixed)

Pressurised waterway preset

Reported by: francois.lacombe Owned by: team
Priority: normal Milestone: 18.06
Component: Internal preset Version:
Keywords: waterway, pressurised, tunnel, pipeline Cc:

Description (last modified by Don-vip)

Recently, waterway=pressurised was reviewed on osm wiki, encouraging the use of waterway=* key to map not only free space but pipe flow waterway features also.
https://wiki.openstreetmap.org/wiki/Tag:waterway%3Dpressurised

Waterway presets should be updated and get new entries as follow :
==Penstock==

  • waterway=pressurised
  • man_made=pipeline
  • substance=water
  • location={underground,overground}
  • usage=penstock
  • name=*
  • operator=*
  • diameter=*
  • material=*

==Pipe flow tunnel==

  • waterway=pressurised
  • usage={headrace,tailrace,transmission,irrigation}
  • location=underground
  • tunnel=flooded
  • name=*
  • operator=*

==Canal preset should be updated as follow==

  • tunnel={culvert,flooded}
  • usage={transportation,transmission,irrigation,headrace,tailrace}

Main validation rules :

  • usage=penstock requires man_made=pipeline and waterway=pressurised
  • tunnel=yes and waterway=pressurised requires man_made=pipeline
  • tunnel=flooded is highly improbable with man_made=pipeline
  • waterway=canal shouldn't be used with tunnel=yes
  • waterway=pressurised requires tunnel=flooded or man_made=pipeline

Render I'd suggest :

  • waterway=pressurised + tunnel=* => add grey 1px casing to existing waterway line
  • waterway=pressurised + man_made=pipeline => add "pipeline color" 1px casing to existing waterway line

I know it's huge and you may have a lot of undergoing business, it would be great to handle this
Let me know if I can help or provide more precise things

Attachments (0)

Change History (11)

comment:1 Changed 6 months ago by Don-vip

Milestone: 18.06

comment:2 Changed 6 months ago by Don-vip

In 13895/josm:

see #16147 - Presets: add penstock, update canal

comment:3 Changed 6 months ago by francois.lacombe

Hi

Great commit for now with the best icon I could immagine.

Thanks :)

comment:4 Changed 6 months ago by Don-vip

In 13896/josm:

see #16147 - add usage context as "transmission" is already used for power substations

comment:5 Changed 6 months ago by Don-vip

You're welcome :) Can you please review French translations tomorrow?

comment:6 Changed 6 months ago by francois.lacombe

I would if I could find where to go to get preset translations.

Note that transmission substations are tagged with substation=transmission and not usage=transmission
Anyway I don't know if it has any impact yet

comment:7 Changed 6 months ago by anonymous

One more thing :

I've just noticed there is an existing usage key validation rule called 'missing attribute - usage=* without railway=*'
It should be extended to waterways if possible

comment:8 Changed 6 months ago by Don-vip

Description: modified (diff)

comment:9 Changed 6 months ago by Don-vip

Resolution: fixed
Status: newclosed

In 13972/josm:

fix #16147 - add rendering and validator rules for pressurised waterways

comment:10 Changed 6 months ago by Klumbumbus

In 13975/josm:

fix #16423, see #16147 - fix mapcss rule

comment:11 Changed 5 months ago by Klumbumbus

In 14041/josm:

see #16147 - better validator warning text (print value of second tag)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.