Changeset 13972 in josm

Timestamp:

2018-06-24T19:29:55+02:00 (6 years ago)

Author:

Don-vip

Message:

fix #16147 - add rendering and validator rules for pressurised waterways

Location:

trunk

Files:

• data/validator/combinations.mapcss (modified) (6 diffs)
• styles/standard/elemstyles.mapcss (modified) (3 diffs)

trunk/data/validator/combinations.mapcss

@@ -35 +35 @@
 way[tracks                     ][!railway][route!=railway],
 way[traffic_mode               ][!railway][route!=railway],
-way[usage                      ][!railway][route!=railway][man_made!=pipeline],
 way[workrules                  ][!railway][route!=railway],
 way[stream                     ][!waterway],
@@ -110 +109 @@
 *[bridge:movable               ][bridge!=movable][man_made!=bridge],
 *[substation                   ][power!=substation][pipeline!=substation],
-*[reservoir_type               ][landuse!=reservoir][water!=reservoir] {
+*[reservoir_type               ][landuse!=reservoir][water!=reservoir],
+way[waterway=pressurised       ][tunnel!=flooded][man_made!=pipeline] {
   throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.tag}", "{2.tag}");
   group: tr("missing tag");
@@ -179 +179 @@
 }
 
+/* {0.tag} without {1.tag} */
+way[usage=penstock][man_made!=pipeline],
+way[usage=penstock][waterway!=pressurised] {
+  throwWarning: tr("{0} without {1}", "{0.tag}", "{1.tag}");
+  group: tr("missing tag");
+}
+
 /* {0.tag} without {1.tag} or {2.tag} */
 *[amenity=recycling][recycling_type!=container][recycling_type!=centre] {
@@ -211 +218 @@
 *[amenity=vending_machine][shop],
 *[noname?][name],
+way[man_made=pipeline][tunnel=flooded]
+way[waterway=canal][tunnel=yes]
 way[oneway=yes][/:backward/][!traffic_sign:backward][bicycle:backward!=use_sidepath],
 way[oneway=yes][/:forward/][!traffic_sign:forward][bicycle:forward!=use_sidepath],
@@ -375 +384 @@
 }
 
-/* #10140 */
-*[building:levels][!building][!building:part] {
+/* {0.key} without {1.key} or {2.key} see #10140 */
+*[building:levels][!building][!building:part],
+way[usage][!railway][!waterway][route!=railway][man_made!=pipeline] {
   throwWarning: tr("{0} without {1} or {2}", "{0.key}", "{1.key}", "{2.key}");
   group: tr("missing tag");
@@ -463 +473 @@
 }
 
-/* #13138, 14468 */
+/* {1.key} without {2.tag} see #13138, 14468 */
 area:closed[water][natural!~/water|bay|strait/][water!=intermittent] { /* water=intermittent is deprecated and has an own warning */
   throwWarning: tr("{0} without {1}", "{1.key}", "{2.tag}");

trunk/styles/standard/elemstyles.mapcss

@@ -1448 +1448 @@
     repeat-image: "presets/misc/embankment-pattern-centered.png";
 }
-way[man_made=pipeline] {
+way[man_made=pipeline][!waterway] {
     width: 2;
     color: pipeline#660000;
@@ -4313 +4313 @@
     color: riverbank#0000cf;
 }
+way[waterway=pressurised],
 way[waterway=canal] {
     width: 2;
@@ -4322 +4323 @@
     casing-color: lock#303030;
     casing-dashes: 5,20;
+}
+way[waterway=pressurised][tunnel] {
+    casing-width: 1;
+    casing-color: tunnel#964B00;
+}
+way[waterway=pressurised][man_made=pipeline] {
+    casing-width: 1;
+    casing-color: pipeline#660000;
 }
 way[waterway=stream] {