Modify

Opened 4 years ago

Last modified 9 months ago

#14092 new enhancement

Should not suggest to downgrade the classification of some roundabouts

Reported by: naoliv Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: roundabout Cc:

Description

Validate the attached example and see two warnings about Incorrect roundabout (highway:secondary instead of unclassifed)

If we click on Fix JOSM will downgrade both to unclassified, breaking the continuity of the secondary highways.

Could JOSM somehow avoid to give a warning for such cases?
Or maybe warn to verify the highway=*_link ways ending at the roundabout (if we properly tag them with secondary instead secondary_link, we won't have a warning about this)

I am asking this because we are having, again, some users blindly validating and "fixing" the data in OSM using JOSM.
Of course this is not a problem with JOSM, but I guess that this specific situation could be improved.

Thank you!

JOSM:

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-12-05 22:01:54 +0100 (Mon, 05 Dec 2016)
Build-Date:2016-12-06 02:33:24
Revision:11363
Relative:URL: ^/trunk

Identification: JOSM/1.5 (11363 en) Linux Debian GNU/Linux testing (stretch)
Memory Usage: 247 MB / 10206 MB (47 MB allocated, but free)
Java version: 1.8.0_111-8u111-b14-3-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1600x900, :0.1 1280x1024
Maximum Screen Size: 1600x1024
Java package: openjdk-8-jre:amd64-8u111-b14-3
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-11
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Attachments (2)

roundabout.osm (106.5 KB) - added by naoliv 4 years ago.
newexample.osm (20.5 KB) - added by naoliv 3 years ago.

Download all attachments as: .zip

Change History (10)

Changed 4 years ago by naoliv

Attachment: roundabout.osm added

comment:1 Changed 4 years ago by openstreetmap.org-user-d1g

Agree, JOSM shoudn't downgrade highway=secondary + junction=roundabout

Especially 2 classes below secondary (kinda risky guess for "autofix")

comment:2 Changed 4 years ago by openstreetmap.org-user-d1g

It is better to keep upper class (secondary in this case) because there not many roads with top classes (pr, se, tr) in any area (i.e. they are more likely to be mapped well.

Not the opposite: unclassified was correct, but secondary is not.

comment:3 Changed 3 years ago by Don-vip

Owner: changed from team to naoliv
Status: newneedinfo

Please test if this is fixed in r12864+

comment:4 Changed 3 years ago by Don-vip

Keywords: roundabout added

Changed 3 years ago by naoliv

Attachment: newexample.osm added

comment:5 Changed 3 years ago by naoliv

Owner: changed from naoliv to team
Status: needinfonew

It seems good. Tested with an older version and current (12866) and it was improved.
There is only one doubt that I have.
I see a lot of motorways here mapped like the ones in newexample.osm and JOSM always warns about Incorrect roundabout (highway: motorway_link instead motorway) with a fix that upgrades them to motorway

https://i.imgur.com/e0lFIXS.png

I am unsure if they really should be upgraded to motorway, as it doesn't make sense to have only a motorway circle like this.

Another issue that I saw (tell me if it's related or not and if you want that I open another ticket about this), but I am seeing warnings about Highway link is not linked to adequate highway/link (which didn't happen in the older version):

https://i.imgur.com/fJ1NaC7.png

At least these 4 links should stay as motorway_link I guess:
https://i.imgur.com/ug5HnUB.png

comment:6 Changed 3 years ago by Don-vip

Yes the links are incortrectly tagged as motorway instead of links. Is the roundabout test ok if you change them to links?

comment:7 Changed 3 years ago by naoliv

Which links are incorrect?

comment:8 Changed 9 months ago by anonymous

Ticket #19350 has been marked as a duplicate of this ticket.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to naoliv
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.