#13805 closed enhancement (fixed)
improve progress bar of validator
Reported by: | Klumbumbus | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 20.03 |
Component: | Core validator | Version: | |
Keywords: | template_report | Cc: |
Description (last modified by )
- validate a larger data set
- see how the test "Tag checker (MapCSS based)" takes by far the longest time of all the test
- during this test you see no progess in the progress bar
- for better user feedback it would be nice to print all the single mapcss based tests separately
- --> more "fluent" validation progress
This would count for all core tests and all active Rules
Build-Date:2016-10-14 21:42:43 Revision:11128 Is-Local-Build:true Identification: JOSM/1.5 (11128 SVN en) Windows 7 32-Bit Memory Usage: 247 MB / 247 MB (0 MB allocated, but free) Java version: 1.8.0_102-b14, Oracle Corporation, Java HotSpot(TM) Client VM Screen: \Display0 1680x1050 Maximum Screen Size: 1680x1050 Dataset consistency test: No problems found
Attachments (3)
Change History (23)
by , 9 years ago
Attachment: | tagcheckerprogress.png added |
---|
comment:1 by , 9 years ago
Description: | modified (diff) |
---|
comment:2 by , 7 years ago
comment:3 by , 5 years ago
Resolution: | → duplicate |
---|---|
Status: | new → closed |
Closed as duplicate of #17035.
comment:4 by , 5 years ago
Not really fixed. There is a counter and progress now within "Tag checker (MapCSS based)", however the single rules (geometry, numeric, germany specific,... ) are not printed. That may be too complex/too much work?
comment:5 by , 5 years ago
The algo works like this:
For each object an index is used to find which tests may match. For each processed primitive the counter is increased.
This is typically done in miliseconds. It would not help much to show several strings in that time, it would just slow down the test.
follow-up: 7 comment:6 by , 5 years ago
On the other hand it might well be possible to change the logic so that each *.mapcss file is processed as a single test.
Maybe it was always expected to work like that? See also #17737.
follow-up: 8 comment:7 by , 5 years ago
Replying to GerdP:
On the other hand it might well be possible to change the logic so that each *.mapcss file is processed as a single test.
If that makes the validation slower then we shouldn't change it. Imho performance is more important than displaying the single rules.
comment:8 by , 5 years ago
Replying to Klumbumbus:
Replying to GerdP:
On the other hand it might well be possible to change the logic so that each *.mapcss file is processed as a single test.
If that makes the validation slower then we shouldn't change it. Imho performance is more important than displaying the single rules.
I don't think it would change performance to show "geometry" or "deprecated" if we change the logic so that we have multiple instances of MapCSSTagChecker, one for each *.mapcss file. It clearly would be the solution for #17737.
comment:9 by , 5 years ago
The current code in OsmValidator
and ValidateAction
doesn't make it easy to change this. We probably have to treat
test MapCSSTagChecker
completely separated from the other tests. Up to now we use several loops like
for (Test test : allTests) { test.foo(); }
I don't like the idea to add a special case for each of the loops and I don't see how to avoid that either. Maybe there are tricks like reflection to do this but I don't know them.
by , 5 years ago
Attachment: | 13805-grouped.patch added |
---|
comment:12 by , 5 years ago
13805-grouped.patch:
- change flow control so that the tests of one *.mapcss file are performed as a block without side effects on other tests (#17737)
- show the source name (e.g. geometry.mapcss) in the progess bar and an element counter if the tests runs longer than 0.5 seconds
- element counter is increased in steps of 10000 instesd of 1000. Not sure if that is better.
I saw no changes regarding performance. Waiting for #18802 to be closed...
follow-up: 14 comment:13 by , 5 years ago
The patch works fine for me. I would prefer the translated names instead of the file names though if possible:
right part of:
comment:14 by , 5 years ago
Replying to Klumbumbus:
The patch works fine for me. I would prefer the translated names instead of the file names though if possible:
Thanks for testing. Problem regarding translated name is the same as with the tool tip (#18810), so I have two good reasons to work on this ;)
by , 5 years ago
Attachment: | 13805-grouped.2.patch added |
---|
comment:15 by , 5 years ago
The new patch shows the translated name or the name the user has given for his own *.mapcss file. If that optional name is empty it shows tr("unknown"). Altenative would be to show the file name instead as with the first patch version.
comment:16 by , 5 years ago
Resolution: | duplicate |
---|---|
Status: | closed → reopened |
I'll test after ticket:18845#comment:13 is fixed.
comment:17 by , 5 years ago
13805-grouped.2.patch works fine for me. For the fallback for missing name I would use the filename then as "unknown" gives pretty much no informationen.
comment:18 by , 5 years ago
Summary: | improve progess bar of validator → improve progress bar of validator |
---|
Would be great if implemented.