Modify

Opened 9 months ago

Closed 9 months ago

Last modified 9 months ago

#18810 closed enhancement (fixed)

Validator dialog should show the test that produced the message

Reported by: GerdP Owned by: team
Priority: normal Milestone: 20.03
Component: Core validator Version:
Keywords: Cc:

Description (last modified by GerdP)

Inspired by a discussion in the german forum thread: https://forum.openstreetmap.org/viewtopic.php?pid=778892#p778892

It would be good to show the (translated) name of the Test instance which produced the error/warning text. The information is already existing, we just have to render it. This would to find the corresponding entry in the preferences dialog.

Attachments (2)

18810tests.PNG (166.0 KB) - added by Klumbumbus 9 months ago.
validatortooltip.png (6.1 KB) - added by Klumbumbus 9 months ago.

Download all attachments as: .zip

Change History (21)

comment:1 Changed 9 months ago by GerdP

Description: modified (diff)

comment:2 Changed 9 months ago by GerdP

In 15960/josm:

see #18810: Validator dialog should show the test that produced the message

  • show name of Test in tooltip

comment:3 Changed 9 months ago by skyper

Component: CoreCore validator
Milestone: 20.03

comment:4 Changed 9 months ago by GerdP

I think it would be good to show this message also for a group created by the same test, but that requires more code.

comment:5 Changed 9 months ago by skyper

Milestone: 20.03

Sorry, for setting milestone. Thought this was fixed.

comment:6 Changed 9 months ago by Klumbumbus

For the mapcss test it would be useful if the mapcssfile is returned. Currently it says only (in german) "Merkmalsprüfer (basierend auf mapcss)" which is less useful.

comment:7 Changed 9 months ago by GerdP

Resolution: fixed
Status: newclosed

In 15972/josm:

fix #18810: Validator dialog should show the test that produced the message

  • show test also for the grouped error. If multiple tests are involved show "Different tests"
  • for MapCss rules report also the URL/File as stated in the preference dialog, e.g. "resource://data/validator/geometry.mapcss"
  • for Java tests report "Java: " + this.getClass().getName(), e.g. "Java: org.openstreetmap.josm.data.validation.DuplicateWay"

comment:8 Changed 9 months ago by GerdP

Milestone: 20.03

I used "Java: " without tr() since I see no need to translate that string. OK?

comment:9 Changed 9 months ago by Klumbumbus

Resolution: fixed
Status: closedreopened
  • If you hover the plus or minus buttons of the tree structure a tool tip "null" appears.
  • I think it doesn't really fit the UI to present the user the full path. It looks like accidently displayed source code. Could't we use the already translated names from the preferences? This way it would be easier for the user too to connect the tool tip with the entry in the preferences I guess.


Changed 9 months ago by Klumbumbus

Attachment: 18810tests.PNG added

comment:10 in reply to:  9 ; Changed 9 months ago by GerdP

Replying to Klumbumbus:

  • If you hover the plus or minus buttons of the tree structure a tool tip "null" appears.

OK, I'll have a look at that

  • I think it doesn't really fit the UI to present the user the full path. It looks like accidently displayed source code. Could't we use the already translated names from the preferences? This way it would be easier for the user too to connect the tool tip with the entry in the preferences I guess.

That's what I wanted to implement but the translated name is not passed on, only the source path. It will require more changes, I have to learn first how plugins add there own rules to the preference dialog.

comment:11 Changed 9 months ago by GerdP

In 16010/josm:

see #18810: Validator dialog should show the test that produced the message
Don't show tool tip "null" when hovering over the plus or minus buttons

comment:12 in reply to:  10 ; Changed 9 months ago by GerdP

Replying to GerdP:

Replying to Klumbumbus:

  • I think it doesn't really fit the UI to present the user the full path. It looks like accidently displayed source code. Could't we use the already translated names from the preferences? This way it would be easier for the user too to connect the tool tip with the entry in the preferences I guess.

That's what I wanted to implement but the translated name is not passed on, only the source path. It will require more changes, I have to learn first how plugins add there own rules to the preference dialog.

The tool tip shows the same name as the progress bar in the validator, so r16047 fixed this as well for the mapcss tests.
Should I also change the toop tip presented for java tests like UnconnectedWays with prefix "Java:"?
Note that this might help to identify messages produced by plugins.

comment:13 in reply to:  12 ; Changed 9 months ago by Klumbumbus

Replying to GerdP:

Should I also change the toop tip presented for java tests like UnconnectedWays with prefix "Java:"?

Yes, that would be great.

comment:14 in reply to:  13 Changed 9 months ago by GerdP

Replying to Klumbumbus:

Replying to GerdP:

Should I also change the toop tip presented for java tests like UnconnectedWays with prefix "Java:"?

Yes, that would be great.

Any suggestion?

comment:15 Changed 9 months ago by Klumbumbus

What do you mean?

comment:16 Changed 9 months ago by GerdP

I asked if I should change the tool tip, you wrote yes. What would be better than the implemented solution?

comment:17 Changed 9 months ago by Klumbumbus

OK, I misunderstood / missed that we already have the translated Java test name in the second tooltip line.
Example of current status:

So for Java tests we could reword the second line to "Test: Java: Doppelte Punkte" and remove the third line.

Or we keep the current status. I'm fine with that too.

Changed 9 months ago by Klumbumbus

Attachment: validatortooltip.png added

comment:18 Changed 9 months ago by GerdP

Resolution: fixed
Status: reopenedclosed

Then let's keep what we have for now.

comment:19 Changed 9 months ago by GerdP

In 16079/josm:

see #18810: extend delay for tool tip in validator tree

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.