Opened 17 months ago

Closed 8 months ago

Last modified 8 months ago

#17737 closed task (fixed)

Unclear scope of mapcss class (set clause)

Reported by: GerdP Owned by: team
Priority: normal Milestone: 20.03
Component: Core validator Version:
Keywords: Cc: Klumbumbus


We have rules like this in geometry.mapcss

way[highway][area!=yes][!tunnel][!covered] > node {
  set node_in_highway;

I wonder if we have any rules regarding the scope of the class node_in_highway?
It seems that anybody assumes that the scope is limited to the *.mapcss file where it is used.
IIGTR the current implementation in MapCSSTagChecker neither cares about it not does it make sure that the rule sets in different *.mapcss files are executed in any particular order. So, what is the expected result if two *.mapcss use the same class?

Attachments (0)

Change History (2)

comment:1 Changed 8 months ago by GerdP

Resolution: fixed
Status: newclosed

In 16047/josm:

fix #13805,#17737 improve progress bar of validator / Unclear scope of mapcss class (set clause)

  • change flow control so that the tests of one *.mapcss file are performed as a block without side effects on other tests (#17737). Tests which relied on this might need changes.
  • show the rules name (e.g. Geometry) in the progess bar and an element counter if the tests runs longer than 0.5 seconds. If no name was given for the rules the file name is shown (e.g. myrules.mapcss)
  • element counter is increased in steps of 10000 instead of 1000.

comment:2 Changed 8 months ago by Klumbumbus

Milestone: 20.03

Modify Ticket

Change Properties
Set your email in Preferences
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.