Attempt to upload JOSM Changes to Server Causes Exception

[alexkemp]

What steps will reproduce the problem?

1. Update Server + JOSM + Plugins to latest
2. Load JOSM + acquire latest from Server in survey area
3. Add a small row of 20 houses + add 7 other houses as relation to same street
4. Click on 'upload all changes to server' (ctrl+shift+up)
5. stare with disbelief at exception message

What is the expected result?

Uplift of work

What happens instead?

Please provide any additional information below. Attach a screenshot if possible.

Does not seem possible to save existing work; no error, it simply does nothing (the file *was* saved, but there was zero notification of that fact; I switched back to 10526 to get it uplifted)

Each terrace (produced with terracer) produced an accurate terrace + relation then threw an exception at the end; I did NOT report as developers have been throwing tantrums everytime that I did so.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-07-17 17:25:58 +0200 (Sun, 17 Jul 2016)
Build-Date:2016-07-17 15:29:38
Revision:10554
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10554 en_GB) Linux Debian GNU/Linux 8.5 (jessie)
Memory Usage: 649 MB / 1636 MB (203 MB allocated, but free)
Java version: 1.8.0_91-8u91-b14-1~bpo8+1-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
VM arguments: [-Djosm.restart=true, -Djosm.home=<josm.pref>, -Djava.net.useSystemProxies=true]

Dataset consistency test:
[NO DATASET] {Way id=-61229 version=0 MVT nodes=[{Node id=-61225 version=0 MV lat=52.96817703284017,lon=-1.090553373766685}, {Node id=-62317 version=0 MV lat=52.9681970635871,lon=-1.090602189970756}, {Node id=-62318 version=0 MV lat=52.96829638078268,lon=-1.090489834944963}, {Node id=-61228 version=0 MV lat=52.96827635008179,lon=-1.090441018740892}, {Node id=-61225 version=0 MV lat=52.96817703284017,lon=-1.090553373766685}]} is referenced by {Relation id=-62331 version=0 VT [way 345749358, way -61229, way -62327, way -62328, way -62329, way -62330, way -63601, way -63602, way -63740, way -63741, way -63847, way -63848, way -63968, way -64143, way -64158, way -64159, way -64160, way -64251, way -64252, way -64422, way -64433]} but not found in dataset
[NO DATASET] {Way id=-64143 version=0 MVT nodes=[{Node id=-64139 version=0 MV lat=52.968484436378866,lon=-1.0912506494717058}, {Node id=-64150 version=0 MV lat=52.96850523428453,lon=-1.0913016114429888}, {Node id=-64151 version=0 MV lat=52.96857678739982,lon=-1.0912211027272445}, {Node id=-64142 version=0 MV lat=52.968555989528575,lon=-1.0911701407559615}, {Node id=-64139 version=0 MV lat=52.968484436378866,lon=-1.0912506494717058}]} is referenced by {Relation id=-62331 version=0 VT [way 345749358, way -61229, way -62327, way -62328, way -62329, way -62330, way -63601, way -63602, way -63740, way -63741, way -63847, way -63848, way -63968, way -64143, way -64158, way -64159, way -64160, way -64251, way -64252, way -64422, way -64433]} but not found in dataset
[NO DATASET] {Way id=-64422 version=0 MVT nodes=[{Node id=-64419 version=0 MV lat=52.96863220900404,lon=-1.0915728668835276}, {Node id=-64429 version=0 MV lat=52.9686519865053,lon=-1.0916245107360834}, {Node id=-64430 version=0 MV lat=52.96872167678077,lon=-1.0915509291947343}, {Node id=-64420 version=0 MV lat=52.96870189931138,lon=-1.0914992853421783}, {Node id=-64419 version=0 MV lat=52.96863220900404,lon=-1.0915728668835276}]} is referenced by {Relation id=-62331 version=0 VT [way 345749358, way -61229, way -62327, way -62328, way -62329, way -62330, way -63601, way -63602, way -63740, way -63741, way -63847, way -63848, way -63968, way -64143, way -64158, way -64159, way -64160, way -64251, way -64252, way -64422, way -64433]} but not found in dataset


Plugins:
- DirectUpload (32329)
- Mapillary (32639)
- apache-commons (32584)
- apache-http (32584)
- buildings_tools (32639)
- continuosDownload (53)
- terracer (32426)

Last errors/warnings:
- E: java.io.IOException: Server returned HTTP response code: 504 for URL: https://a.mapillary.com/v2/search/im/or?client_id=T1Fzd20xZjdtR0s1VDk5OFNIOXpYdzoxNDYyOGRkYzUyYTFiMzgz&min_lon=-1.095074&max_lat=52.970044&max_lon=-1.093156&limit=20&page=3&min_lat=52.969919
- E: java.io.IOException: Server returned HTTP response code: 504 for URL: https://a.mapillary.com/v2/search/im/or?client_id=T1Fzd20xZjdtR0s1VDk5OFNIOXpYdzoxNDYyOGRkYzUyYTFiMzgz&min_lon=-1.093156&max_lat=52.969419&max_lon=-1.091885&limit=20&page=3&min_lat=52.969166
- E: java.io.IOException: Server returned HTTP response code: 504 for URL: https://a.mapillary.com/v2/search/im/or?client_id=T1Fzd20xZjdtR0s1VDk5OFNIOXpYdzoxNDYyOGRkYzUyYTFiMzgz&min_lon=-1.093804&max_lat=52.969166&max_lon=-1.091885&limit=20&page=4&min_lat=52.968666
- E: java.io.IOException: Server returned HTTP response code: 504 for URL: https://a.mapillary.com/v2/search/im/or?client_id=T1Fzd20xZjdtR0s1VDk5OFNIOXpYdzoxNDYyOGRkYzUyYTFiMzgz&min_lon=-1.093804&max_lat=52.969166&max_lon=-1.091885&limit=20&page=5&min_lat=52.968666
- E: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Relation member must be part of the same dataset as relation(relation -62331, way -61229)
- E: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Relation member must be part of the same dataset as relation(relation -62331, way -61229)
- E: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Relation member must be part of the same dataset as relation(relation -62331, way -61229)
- E: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive must be part of the dataset: {Way id=-61229 version=0 MVT nodes=[{Node id=-61225 version=0 MV lat=52.96817703284017,lon=-1.090553373766685}, {Node id=-62317 version=0 MV lat=52.9681970635871,lon=-1.090602189970756}, {Node id=-62318 version=0 MV lat=52.96829638078268,lon=-1.090489834944963}, {Node id=-61228 version=0 MV lat=52.96827635008179,lon=-1.090441018740892}, {Node id=-61225 version=0 MV lat=52.96817703284017,lon=-1.090553373766685}]}
- E: java.lang.reflect.InvocationTargetException. Cause: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive must be part of the dataset: {Way id=-61229 version=0 MVT nodes=[{Node id=-61225 version=0 MV lat=52.96817703284017,lon=-1.090553373766685}, {Node id=-62317 version=0 MV lat=52.9681970635871,lon=-1.090602189970756}, {Node id=-62318 version=0 MV lat=52.96829638078268,lon=-1.090489834944963}, {Node id=-61228 version=0 MV lat=52.96827635008179,lon=-1.090441018740892}, {Node id=-61225 version=0 MV lat=52.96817703284017,lon=-1.090553373766685}]}
- E: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive must be part of the dataset: {Way id=-61229 version=0 MVT nodes=[{Node id=-61225 version=0 MV lat=52.96817703284017,lon=-1.090553373766685}, {Node id=-62317 version=0 MV lat=52.9681970635871,lon=-1.090602189970756}, {Node id=-62318 version=0 MV lat=52.96829638078268,lon=-1.090489834944963}, {Node id=-61228 version=0 MV lat=52.96827635008179,lon=-1.090441018740892}, {Node id=-61225 version=0 MV lat=52.96817703284017,lon=-1.090553373766685}]}

org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive must be part of the dataset: {Way id=-61229 version=0 MVT nodes=[{Node id=-61225 version=0 MV lat=52.96817703284017,lon=-1.090553373766685}, {Node id=-62317 version=0 MV lat=52.9681970635871,lon=-1.090602189970756}, {Node id=-62318 version=0 MV lat=52.96829638078268,lon=-1.090489834944963}, {Node id=-61228 version=0 MV lat=52.96827635008179,lon=-1.090441018740892}, {Node id=-61225 version=0 MV lat=52.96817703284017,lon=-1.090553373766685}]}
	at org.openstreetmap.josm.data.osm.OsmPrimitive.checkDataset(OsmPrimitive.java:358)
	at org.openstreetmap.josm.data.osm.OsmPrimitive.getReferrers(OsmPrimitive.java:1110)
	at org.openstreetmap.josm.data.osm.OsmPrimitive.getReferrers(OsmPrimitive.java:1131)
	at org.openstreetmap.josm.data.validation.tests.Addresses.getAndCheckAssociatedStreets(Addresses.java:83)
	at org.openstreetmap.josm.data.validation.tests.Addresses.checkHouseNumbersWithoutStreet(Addresses.java:113)
	at org.openstreetmap.josm.data.validation.tests.Addresses.visit(Addresses.java:138)
	at org.openstreetmap.josm.data.osm.Way.accept(Way.java:211)
	at org.openstreetmap.josm.data.validation.Test.visit(Test.java:211)
	at org.openstreetmap.josm.actions.upload.ValidateUploadHook.checkUpload(ValidateUploadHook.java:61)
	at org.openstreetmap.josm.actions.UploadAction.checkPreUploadConditions(UploadAction.java:207)
	at org.openstreetmap.josm.actions.UploadAction.uploadData(UploadAction.java:231)
	at org.openstreetmap.josm.actions.UploadAction.actionPerformed(UploadAction.java:271)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:252)
	at java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:289)
	at java.awt.Component.processMouseEvent(Component.java:6535)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3324)
	at java.awt.Component.processEvent(Component.java:6300)
	at java.awt.Container.processEvent(Container.java:2236)
	at java.awt.Component.dispatchEventImpl(Component.java:4891)
	at java.awt.Container.dispatchEventImpl(Container.java:2294)
	at java.awt.Component.dispatchEvent(Component.java:4713)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4888)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4525)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4466)
	at java.awt.Container.dispatchEventImpl(Container.java:2280)
	at java.awt.Window.dispatchEventImpl(Window.java:2750)
	at java.awt.Component.dispatchEvent(Component.java:4713)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
	at java.awt.EventQueue$4.run(EventQueue.java:731)
	at java.awt.EventQueue$4.run(EventQueue.java:729)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

[stoecker]

Can you reproduce that? This is an error in any of the functions of JOSM or it's plugins. We need an indication of what function it may be and what modification triggers it. Very likely a plugin and not the core.

Best would be if you can produce an small guideline leading to this error. You can use the "Show Status report" in Help menu to check consistency, so it does not show up only at the end of your work before upload.

[alexkemp]

Status_Report before any changes

[alexkemp]

Status_Report after the exception

[alexkemp]

Diary of actions to cause exception

[alexkemp]

Diary of each & every action taken to cause another exception on attempt at uplift to server attached. In addition, status-reports for before & after exception attached.

HTH

PS
Window continues to have a '*' (indicating need to save) even after saving.

[alexkemp]

The recent changes in Core have allowed terracer to now accurately create a relation:

10526 => illegal terrace + no relation + exception
10554 => legal terrace + legal relation (no change to terracer since 10526)

Please, as you fix further errors in the Core, will you ensure that you do not again make changes which shaft terracer. Thanks.

[alexkemp]

Oh shame... a small alteration to that previous comment. The very first house in each terrace is missing from the relation. Oh shame.

[stoecker]

Closed as duplicate of #11878.
Replying to alexkemp:

The recent changes in Core have allowed terracer to now accurately create a relation:

10526 => illegal terrace + no relation + exception
10554 => legal terrace + legal relation (no change to terracer since 10526)

Any change can only be a coincidence. There is a bug in terracer which probably may cause different effects depending on data or state or whatever. Problem is, that terracer is essentially unmaintained.

Your description above seems appropriate to find the issue, now only someone with enough time needs actually to investigate that problem.

Please, as you fix further errors in the Core, will you ensure that you do not again make changes which shaft terracer. Thanks.

JOSM core will not in any case change development to care for bugs in plugins. That's an absolutely strange idea.