Add office=* items to internal presets

[Don-vip]

​office is widely used (150k occurences) but yet missing from the internal presets, although some values are rendered by the default map style.

We have examples in Presets/NewTags.

Some ideas for icons:

Tag	16px	24px
​`office=accountant`
​`office=advertising_agency`
​`office=employment_agency`
​`office=government`
​`office=insurance`
​`office=it`
​`office=newspaper`
​`office=research`

[Klumbumbus]

In 9011/josm:

see #12035 - add office=* items to internal preset and mappaint style

[Klumbumbus]

This is with generic icon for now.

I added all values from the table at ​Key:office except:

I did not add the following values because they are duplicates: realtor and real_estate_agent (duplicate of estate_agent), tax (duplicate of government), travel_agent (duplicate of shop=travel_agency)

I did not add the following values because of low usage numbers: forestry (146) , guide (28), private_investigator (6), quango (148), register (134), water_utility (65)

(numbers from taginfo from today)

[aceman]

Thanks!

[aceman]

May there be strings clashes here with existing strings which cause problems for translators. I'm thinking e.g. "administrative" (boundary), telecommunication (tower:type), religion (religion key). Is a context needed?

[Klumbumbus]

Replying to aceman:

Is a context needed?

It is already in there. name_context="office"

[aceman]

Ah yes, sorry.

[Klumbumbus]

If individual icons are wanted then I would need some help, because finding/editing a good icon takes a lot of time sometimes. The icons in Presets/NewTags are problematic, because the source and license is unclear and some are german specific.

Please see icon guidelines => DevelopersGuide/DefaultPresets

[Don-vip]

Replying to Klumbumbus:

If individual icons are wanted then I would need some help

Looks like OSM carto needs help too:
​https://github.com/gravitystorm/openstreetmap-carto/issues/108
​https://github.com/gravitystorm/openstreetmap-carto/issues/271
​https://github.com/gravitystorm/openstreetmap-carto/issues/1697
​https://github.com/gravitystorm/openstreetmap-carto/issues/1922

[Klumbumbus]

What about the license? I see that your linked icons are GPL or CC-BY. Do we need to add text to the about window. when using icons with such a license?

[Don-vip]

I assume a mention in the last section of CONTRIBUTION file would be enough?

[Don-vip]

Paul, is it OK to add CC-BY icons?

[Don-vip]

Let's continue the discussion to #12136.

[Don-vip]

Ticket #12213 has been marked as a duplicate of this ticket.

[Klumbumbus]

In 9681/josm:

see #12227 - add craft=* to preset and mappaint style, warn about craft=yes; fix office area style (see #12035); add traffic_sign to validator ignore list