#12035 closed enhancement (fixed)
Add office=* items to internal presets
Reported by: | Don-vip | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 15.11 |
Component: | Internal preset | Version: | |
Keywords: | office license | Cc: | bastiK |
Description (last modified by )
office is widely used (150k occurences) but yet missing from the internal presets, although some values are rendered by the default map style.
We have examples in Presets/NewTags.
Some ideas for icons:
Tag | 16px | 24px |
---|---|---|
`office=accountant` | ||
`office=advertising_agency` | ||
`office=employment_agency` | ||
`office=government` | ||
`office=insurance` | ||
`office=it` | ||
`office=newspaper` | ||
`office=research` |
Attachments (0)
Change History (24)
comment:1 by , 9 years ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:2 by , 9 years ago
comment:3 by , 9 years ago
This is with generic icon for now.
I added all values from the table at Key:office except:
I did not add the following values because they are duplicates: realtor and real_estate_agent (duplicate of estate_agent), tax (duplicate of government), travel_agent (duplicate of shop=travel_agency)
I did not add the following values because of low usage numbers: forestry (146) , guide (28), private_investigator (6), quango (148), register (134), water_utility (65)
(numbers from taginfo from today)
follow-up: 6 comment:5 by , 9 years ago
May there be strings clashes here with existing strings which cause problems for translators. I'm thinking e.g. "administrative" (boundary), telecommunication (tower:type), religion (religion key). Is a context needed?
comment:6 by , 9 years ago
follow-up: 9 comment:8 by , 9 years ago
Owner: | changed from | to
---|---|
Status: | assigned → new |
If individual icons are wanted then I would need some help, because finding/editing a good icon takes a lot of time sometimes. The icons in Presets/NewTags are problematic, because the source and license is unclear and some are german specific.
Please see icon guidelines => DevelopersGuide/DefaultPresets
comment:9 by , 9 years ago
Replying to Klumbumbus:
If individual icons are wanted then I would need some help
Looks like OSM carto needs help too:
https://github.com/gravitystorm/openstreetmap-carto/issues/108
https://github.com/gravitystorm/openstreetmap-carto/issues/271
https://github.com/gravitystorm/openstreetmap-carto/issues/1697
https://github.com/gravitystorm/openstreetmap-carto/issues/1922
comment:10 by , 9 years ago
Description: | modified (diff) |
---|
comment:11 by , 9 years ago
Description: | modified (diff) |
---|
comment:12 by , 9 years ago
Description: | modified (diff) |
---|
comment:13 by , 9 years ago
Description: | modified (diff) |
---|
comment:14 by , 9 years ago
Description: | modified (diff) |
---|
comment:15 by , 9 years ago
Description: | modified (diff) |
---|
comment:16 by , 9 years ago
Description: | modified (diff) |
---|
comment:17 by , 9 years ago
Description: | modified (diff) |
---|
comment:18 by , 9 years ago
Description: | modified (diff) |
---|
comment:19 by , 9 years ago
What about the license? I see that your linked icons are GPL or CC-BY. Do we need to add text to the about window. when using icons with such a license?
comment:20 by , 9 years ago
Cc: | added |
---|---|
Keywords: | license added |
I assume a mention in the last section of CONTRIBUTION
file would be enough?
comment:22 by , 9 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Let's continue the discussion to #12136.
In 9011/josm: