Modify

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#12034 closed defect (fixed)

[patch] Error message when using the ALKIS WMS layer

Reported by: chris66 Owned by: wiktorn
Priority: normal Milestone: 15.12
Component: Core imagery Version:
Keywords: ALKIS WMS Atlas Cc:

Description

When loading the ALKIS WMS layer a warning box appears:

"Die Ebene WMS-ATLAS unterstützt die neue Projektion EPSG:3857 nicht"

After confirming the box, the layer is loaded but the image is not as unsharp (lower resolution) compared to older versions of JOSM.

Attachments (2)

warning_messages.patch (13.6 KB ) - added by wiktorn 10 years ago.
preliminary patch
warning_messages.2.patch (14.0 KB ) - added by wiktorn 10 years ago.

Download all attachments as: .zip

Change History (14)

comment:2 by Don-vip, 10 years ago

Component: CoreCore imagery

comment:3 by wiktorn, 10 years ago

Owner: changed from team to wiktorn
Status: newassigned

comment:4 by anonymous, 10 years ago

Old version 8491 is okay.

No error message and image is more sharp.

in reply to:  4 comment:5 by wiktorn, 10 years ago

Replying to anonymous:

Old version 8491 is okay.

No error message and image is more sharp.

To get more "sharp" imagery you may go to Imagery / Imagery Preferences / Settings and choose positive tile zoom offset.

@all:
I'd like to add possibility to silence this warnings. I plan to implement following solution:

  1. add two additional tags for imagery:
  • verified georeference (i.e. the imagery doesn't need imagery adjusting)
  • supports non-square imagery requests (i.e. EPSG:3857 to EPSG:4326 works properly)
  1. Implement the change, that will not show warning about imagery adjust, when working with verified imageries
  2. Add a checkbox in the warning message about imagery adjust, "Do not warn again" instead of current solution, that show the warning only once. This would be saved to user imagery preferences as "verified georeference"
  3. Add a similar checkbox in the warning message about EPSG:3857 to EPSG:4326, which would be stored as non-square imagery requests to user preferences

And of course - users will have the possibility to update Maps and do hide the warnings for all users.

Any thoughts?

comment:6 by wiktorn, 10 years ago

Summary: Error message when using the ALKIS WMS layer[alpha patch] Error message when using the ALKIS WMS layer

Enclosed first version of the patch. The only problem that I discovered is some discrepancy between imageries that are proposed by ImageryMenu.refreshImageryMenu() which cover viewed area.

For these - as they are not activated - they do not land in imagery.entries preference - they are always check against the default. So it's not possible to store user decision "Do not show this message again" there. Moving imagery definitions to imagery.entries would change the way, they appear in menu.

Any thoughts how to approach this problem? Create imagery.entries.default?

comment:7 by anonymous, 10 years ago

Checkbox "don't warn again" is okay for me.

comment:8 by A_Pirard, 10 years ago

I have just checked that if a preset contains
<projections> EPSG:4326 EPSG:3857 </projections>
the 3857->4326 fall-back message is not issued.
It's unclear in the preset doc what that tag is user for.
(If the server is queried for its CECPs and if Arcgis REST supports all projections.)
Unfortunately, JOSM layer installer does not allow setting the equivalent.
And even less pasting the HTTP request template.

comment:9 by stoecker, 10 years ago

Just read the patch: You can't use + and variables to create user visible strings in JOSM, especially not in a tr(). That's an obsolute NO-NO-NO!

in reply to:  9 comment:10 by wiktorn, 10 years ago

Replying to stoecker:

Just read the patch: You can't use + and variables to create user visible strings in JOSM, especially not in a tr(). That's an obsolute NO-NO-NO!

Good point, thanks.

by wiktorn, 10 years ago

Attachment: warning_messages.patch added

preliminary patch

by wiktorn, 10 years ago

Attachment: warning_messages.2.patch added

comment:11 by wiktorn, 10 years ago

Summary: [alpha patch] Error message when using the ALKIS WMS layer[patch] Error message when using the ALKIS WMS layer

Added updated patch version. Now it uses ExtendedDialog.toggleEnable in WMSLayer and similar property naming scheme in AlignImageryPanel

comment:12 by wiktorn, 10 years ago

Milestone: 15.12
Resolution: fixed
Status: assignedclosed

In 9134/josm: commited fix for this bug.

Last edited 10 years ago by wiktorn (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain wiktorn.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.