Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#11827 closed defect (fixed)

Unexpected exception when attempting to upload data

Reported by: kieron.thwaites@… Owned by: team
Priority: normal Milestone: 15.09
Component: Core Version:
Keywords: template_report regression Cc: shinigami

Description

What steps will reproduce the problem?

  1. Performed various edits on OSM data (data with changes attached)
  2. Clicked the "Upload all changes" button

What is the expected result?

Upload confirmation or validation error dialog was expected.

What happens instead?

Unexpected exception dialog was displayed.

Please provide any additional information below. Attach a screenshot if possible.

Revision: 8677
Repository Root: http://josm.openstreetmap.de/svn
Relative URL: ^/trunk
Last Changed Author: Don-vip
Last Changed Date: 2015-08-21 22:18:03 +0200 (Fri, 21 Aug 2015)
Build-Date: 2015-08-21 23:32:08
URL: http://josm.openstreetmap.de/svn/trunk
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Rev: 8677

Identification: JOSM/1.5 (8677 en) Windows 8 64-Bit
Memory Usage: 247 MB / 247 MB (85 MB allocated, but free)
Java version: 1.8.0_51, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:C:\Program Files (x86)\Java\jre1.8.0_51\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Users\Kieron\AppData\LocalLow\Sun\Java\Deployment\cache\6.0\56\1ee8cfb8-4f39036c, -Djnlpx.remove=false, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.splashport=60192, -Djnlp.application.href=https://josm.openstreetmap.de/download/josm.jnlp, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAC1Eam5scC5hcHBsaWNhdGlvbi5ocmVmPWh0dHBzOi8vam9zbS5vcGVuc3RyZWV0bWFwLmRlL2Rvd25sb2FkL2pvc20uam5scAA=]
Dataset consistency test: No problems found

Plugins:
- turnlanes (31241)

Last errors/warnings:
- E: java.lang.UnsupportedOperationException
- E: java.lang.UnsupportedOperationException
- E: java.lang.UnsupportedOperationException

java.lang.UnsupportedOperationException
	at java.util.Collections$1.remove(Unknown Source)
	at java.util.AbstractMap.remove(Unknown Source)
	at org.openstreetmap.josm.data.validation.tests.DuplicateWay.removeUninterestingKeys(DuplicateWay.java:164)
	at org.openstreetmap.josm.data.validation.tests.DuplicateWay.visit(DuplicateWay.java:190)
	at org.openstreetmap.josm.data.osm.Way.accept(Way.java:215)
	at org.openstreetmap.josm.data.validation.Test.visit(Test.java:201)
	at org.openstreetmap.josm.actions.upload.ValidateUploadHook.checkUpload(ValidateUploadHook.java:61)
	at org.openstreetmap.josm.actions.UploadAction.checkPreUploadConditions(UploadAction.java:207)
	at org.openstreetmap.josm.actions.UploadAction.uploadData(UploadAction.java:231)
	at org.openstreetmap.josm.actions.UploadAction.actionPerformed(UploadAction.java:288)
	at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
	at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
	at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
	at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
	at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
	at java.awt.Component.processMouseEvent(Unknown Source)
	at javax.swing.JComponent.processMouseEvent(Unknown Source)
	at java.awt.Component.processEvent(Unknown Source)
	at java.awt.Container.processEvent(Unknown Source)
	at java.awt.Component.dispatchEventImpl(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
	at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
	at java.awt.Container.dispatchEventImpl(Unknown Source)
	at java.awt.Window.dispatchEventImpl(Unknown Source)
	at java.awt.Component.dispatchEvent(Unknown Source)
	at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.awt.EventQueue.access$500(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.awt.EventQueue$3.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.awt.EventQueue$4.run(Unknown Source)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
	at java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.awt.EventDispatchThread.run(Unknown Source)

Attachments (1)

crash.osm (108.4 KB) - added by kieron.thwaites@… 5 years ago.
The data that was used in the upload attempt (and that caused the unexpected exception)

Download all attachments as: .zip

Change History (6)

Changed 5 years ago by kieron.thwaites@…

Attachment: crash.osm added

The data that was used in the upload attempt (and that caused the unexpected exception)

comment:1 Changed 5 years ago by simon04

Cc: shinigami added
Keywords: regression added
Milestone: 15.09

This is a regression of r8566/#11653.

org.openstreetmap.josm.data.validation.tests.DuplicateWay#removeUninterestingKeys (and other methods?) expects the map to be modifiable.

comment:2 Changed 5 years ago by simon04

In 8708/josm:

see #11827 - see #11653 - Revert r8566 till its impacts are fully clarified

Some/many parts of the code rely on org.openstreetmap.josm.data.osm.AbstractPrimitive#getKeys to be modifiable.

comment:3 Changed 5 years ago by simon04

Resolution: fixed
Status: newclosed

comment:4 Changed 5 years ago by simon04

Ticket #11847 has been marked as a duplicate of this ticket.

comment:5 Changed 5 years ago by simon04

In 8709/josm:

see #11827 - fix NPE introduced in r8708

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.