Modify ↓

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#11653 closed enhancement (fixed)

[PATCH] AbstractPrimitive.getKeys optimization

Reported by: shinigami Owned by: team
Priority: normal Milestone: 15.08
Component: Core Version: latest
Keywords: performance Cc:

Description

AbstractPrimitive.getKeys creates HashMap even for empty keys data. Change to Collections.emptyMap and singletonMap saves lots of garbage during file loading.

Attachments (1)

getkeys.patch​ (1.1 KB ) - added by shinigami 10 years ago.
patch

Download all attachments as: .zip

Change History (5)

by shinigami, 10 years ago

Attachment: getkeys.patch​ added

patch

comment:1 by Don-vip, 10 years ago

Keywords: performance added
Milestone: → 15.07
Summary: AbstractPrimitive.getKeys optimization → [PATCH] AbstractPrimitive.getKeys optimization

comment:2 by Don-vip, 10 years ago

Resolution: → fixed
Status: new → closed

In 8566/josm:

fix #11653 - AbstractPrimitive.getKeys optimization (patch by shinigami)

comment:3 by Don-vip, 10 years ago

Milestone: 15.07 → 15.08

Milestone renamed

comment:4 by simon04, 10 years ago

In 8708/josm:

see #11827 - see #11653 - Revert r8566 till its impacts are fully clarified

Some/many parts of the code rely on org.openstreetmap.josm.data.osm.AbstractPrimitive#getKeys to be modifiable.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.