Modify ↓

Opened 9 years ago

Closed 9 years ago

Last modified 4 years ago

#11389 closed enhancement (fixed)

[Patch] Check for maxspeed in combination with maxspeed:forward/backward

Reported by: Basstoelpel Owned by: Basstoelpel
Priority: normal Milestone: 15.09
Component: Core validator Version: latest
Keywords: validator maxspeed Cc:

Description

Validator should check for the combination of maxspeed and maxspeed:forward or maxspeed:backward. Either the combination is superfluous or inconsistent.

And maybe it should check for equal values in maxspeed:forward and maxspeed:backward, because that can be simplified.

Attachments (1)

validate-maxspeed.patch​ (7.2 KB ) - added by windu.2b 9 years ago.

Download all attachments as: .zip

Change History (8)

by windu.2b, 9 years ago

Attachment: validate-maxspeed.patch​ added

comment:1 by windu.2b, 9 years ago

This patch validates the "maxspeed", "maxspeed:backward", "maxspeed:forward", "source:maxspeed" and "zone:maxspeed" values.

If "maxspeed:backward" and "maxspeed:forward" have the same value, a warning message suggests to use the "maxspeed" tag instead.

comment:2 by mdk, 9 years ago

Summary: Check for maxspeed in combination with maxspeed:forward/backward → [Patch] Check for maxspeed in combination with maxspeed:forward/backward

comment:3 by simon04, 9 years ago

Milestone: → 15.07

Please see my comment here: ticket:11529#comment:3

comment:4 by Don-vip, 9 years ago

Milestone: 15.07 → 15.08

Milestone renamed

comment:5 by Don-vip, 9 years ago

Milestone: 15.08 → 15.09
Owner: changed from team to Basstoelpel
Status: new → needinfo

Thanks for the patch. Like for #11529, can you please see if the test can be converted to a MapCSS-based one instead?

comment:6 by Klumbumbus, 9 years ago

Resolution: → fixed
Status: needinfo → closed

In 8700/josm:

fix #11389 - Add validator tests for combinations of maxspeed, maxspeed:forward and maxspeed:backward; enhance numerical test to forward and backward versions and remove "*=unknown" from whitelist of this numerical test

comment:7 by Klumbumbus, 4 years ago

In 17024/josm:

fix #19769, see #11389, see #19010 - Fix validator warning messages

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Basstoelpel.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.