Modify

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#11529 closed enhancement (fixed)

[Patch]Check for maxweight in combination with maxweight:forward/backward

Reported by: windu.2b Owned by: windu.2b
Priority: normal Milestone: 15.09
Component: Core validator Version:
Keywords: Cc:

Description


Attachments (1)

0002-Validate-the-maxweight-tags-and-values.patch (7.8 KB) - added by windu.2b 4 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 4 years ago by Don-vip

Milestone: 15.06

comment:2 Changed 4 years ago by windu.2b

Component: CoreCore validator

comment:3 Changed 4 years ago by simon04

Thank you for your contribution. We also have a powerful Help/Validator/MapCSSTagChecker which is likely able to perform those tests.

  • See source:trunk/data/validator/numeric.mapcss for tests concerning numeric values and units.
  • The maxweight:backward == maxweight:forward test would apply for many other base keys as well (such as maxspeed or maxwidth)
  • Instead of "Value of {0} is not correct", a more concrete warning would help the user to correct the issue.

comment:4 Changed 4 years ago by Don-vip

Milestone: 15.0615.07

skip milestone 15.06

comment:5 Changed 4 years ago by Don-vip

Milestone: 15.0715.08

Milestone renamed

comment:6 Changed 4 years ago by Don-vip

Milestone: 15.0815.09
Owner: changed from team to windu.2b
Status: newneedinfo

Thanks for the patch. Like for #11389, can you please see if the test can be converted to a MapCSS-based one instead and address Simon's remarks?

comment:7 Changed 4 years ago by Klumbumbus

Resolution: fixed
Status: needinfoclosed

In 8701/josm:

fix #11529 - add numeric test for maxweight (copied from maxwidth test directly above)

comment:8 Changed 4 years ago by Klumbumbus

I don't think we need a test for maxweight:forward and maxweight:backward, because maxweight restrictions usually count for both directions. Therefore there are only 101x maxweight:forward and 112x maxweight:backward on ways in the database (and only 10 ways have both tags).

Last edited 4 years ago by Klumbumbus (previous) (diff)

comment:9 Changed 4 years ago by ViriatoLusitano

Is it possible to do something similar for maxspeed:lanes or minspeed:lanes? The first has about 2000 different uses and the latter 388 and they are slowly growing as motorway mapping matures around the world.

comment:10 in reply to:  9 Changed 4 years ago by Klumbumbus

Replying to ViriatoLusitano:

Is it possible to do something similar for maxspeed:lanes or minspeed:lanes? The first has about 2000 different uses and the latter 388 and they are slowly growing as motorway mapping matures around the world.

This requires some core changes first, see #11832

comment:11 Changed 3 years ago by Klumbumbus

In 10995/josm:

see #11529 - more validation of different number of lanes

comment:12 in reply to:  9 Changed 3 years ago by Klumbumbus

Replying to ViriatoLusitano:

Is it possible to do something similar for maxspeed:lanes or minspeed:lanes? The first has about 2000 different uses and the latter 388 and they are slowly growing as motorway mapping matures around the world.

I checked all values of maxspeed:lanes http://taginfo.openstreetmap.org/keys/maxspeed%3Alanes#values and minspeed:lanes http://taginfo.openstreetmap.org/keys/minspeed%3Alanes#values and the only error was wrong number of | in the value. The added test compares it with the lanes key. This is limited to motorways and trunks to avoid false positives for streets with lanes for non motorized traffic, see #8519.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain windu.2b.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.