[Patch]Check for maxweight in combination with maxweight:forward/backward

[simon04]

Thank you for your contribution. We also have a powerful Help/Validator/MapCSSTagChecker which is likely able to perform those tests.

• See source:trunk/data/validator/numeric.mapcss for tests concerning numeric values and units.
• The maxweight:backward == maxweight:forward test would apply for many other base keys as well (such as maxspeed or maxwidth)
• Instead of "Value of {0} is not correct", a more concrete warning would help the user to correct the issue.

[Don-vip]

skip milestone 15.06

[Don-vip]

Milestone renamed

[Don-vip]

Thanks for the patch. Like for #11389, can you please see if the test can be converted to a MapCSS-based one instead and address Simon's remarks?

[Klumbumbus]

In 8701/josm:

fix #11529 - add numeric test for maxweight (copied from maxwidth test directly above)

[Klumbumbus]

I don't think we need a test for maxweight:forward and maxweight:backward, because maxweight restrictions usually count for both directions. Therefore there are only 101x maxweight:forward and 112x maxweight:backward on ways in the database (and only 10 ways have both tags).

[ViriatoLusitano]

Is it possible to do something similar for maxspeed:lanes or minspeed:lanes? The first has about ​2000 different uses and the latter ​388 and they are slowly growing as motorway mapping matures around the world.

[Klumbumbus]

Replying to ViriatoLusitano:

Is it possible to do something similar for maxspeed:lanes or minspeed:lanes? The first has about ​2000 different uses and the latter ​388 and they are slowly growing as motorway mapping matures around the world.

This requires some core changes first, see #11832

[Klumbumbus]

In 10995/josm:

see #11529 - more validation of different number of lanes

[Klumbumbus]

Replying to ViriatoLusitano:

Is it possible to do something similar for maxspeed:lanes or minspeed:lanes? The first has about ​2000 different uses and the latter ​388 and they are slowly growing as motorway mapping matures around the world.

I checked all values of maxspeed:lanes ​http://taginfo.openstreetmap.org/keys/maxspeed%3Alanes#values and minspeed:lanes ​http://taginfo.openstreetmap.org/keys/minspeed%3Alanes#values and the only error was wrong number of | in the value. The added test compares it with the lanes key. This is limited to motorways and trunks to avoid false positives for streets with lanes for non motorized traffic, see #8519.