Modify

Opened 12 days ago

Closed 6 days ago

#19769 closed defect (fixed)

Typo in error message

Reported by: Famlam Owned by: team
Priority: normal Milestone: 20.09
Component: Core validator Version: tested
Keywords: template_report Cc:

Description (last modified by Famlam)

What steps will reproduce the problem?

  1. Have a way with cycleway:right=lane and cycleway:left=lane

or

  1. Have a way with maxspeed:forward=30 and maxspeed:backward=30

or

  1. Have a way with sidewalk:left=yes and sidewalk:right=yes

What is the expected result?

Warning (in the cycleway case) Same value of cycleway:left and cycleway:right

What happens instead?

Warning (in the cycleway case) Same value of cycleway:left and cycleway

Please provide any additional information below. Attach a screenshot if possible.

Due to a few checks at or below:
https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/combinations.mapcss#L477

- way["sidewalk:left"=*"sidewalk:right"][!sidewalk] {
- way["cycleway:left"=*"cycleway:right"][!cycleway] {
- way["maxspeed:forward"=*"maxspeed:backward"][!maxspeed] {

each with

throwWarning: tr("Same value of {0} and {1}", "{0.key}", "{1.key}");

while {1.key} refers to the non-existing tag in the [!xxxxx] selector

Solution would be easy: add [sidewalk:right] or [cycleway:right] or [maxspeed:backward] respectively as the first or second selector

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-09-06 16:54:59 +0200 (Sun, 06 Sep 2020)
Build-Date:2020-09-07 01:30:48
Revision:17013
Relative:URL: ^/trunk

Identification: JOSM/1.5 (17013 nl) Windows 10 64-Bit
OS Build number: Windows 10 Home 2004 (19041)
Memory Usage: 849 MB / 1820 MB (393 MB allocated, but free)
Java version: 1.8.0_261-b12, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Look and Feel: com.sun.java.swing.plaf.windows.WindowsLookAndFeel
Screen: \Display0 1920x1080 (scaling 1.0x1.0)
Maximum Screen Size: 1920x1080
Best cursor sizes: 16x16 -> 32x32, 32x32 -> 32x32
Dataset consistency test: No problems found

Plugins:
+ OpeningHoursEditor (35414)
+ imagery_offset_db (35405)
+ pt_assistant (2.1.10-80-g7d9bba3)
+ tageditor (35258)
+ turnlanes-tagging (283)
+ undelete (35521)
+ utilsplugin2 (35487)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/PublicTransport&zip=1

Validator rules:
+ %UserProfile%\Documents\tijdelijke bestanden\josm-eigen.validator.mapcss

Attachments (0)

Change History (4)

comment:1 Changed 12 days ago by Famlam

Description: modified (diff)

comment:2 Changed 12 days ago by Klumbumbus

Milestone: 20.09

comment:3 Changed 12 days ago by Famlam

Description: modified (diff)

comment:4 Changed 6 days ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 17024/josm:

fix #19769, see #11389, see #19010 - Fix validator warning messages

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.