Modify ↓

Opened 9 years ago

Closed 5 years ago

#11388 closed defect (fixed)

duplicated relations not detected when members order differ

Reported by: naoliv Owned by: Don-vip
Priority: normal Milestone: 19.09
Component: Core validator Version:
Keywords: relation member order Cc:

Description

Validate the attached file and see that there isn't any warning or error about a duplicated relation.
Note that the one with name=2 has some unsorted members.

Shouldn't the validator sort (internally) the relations and compare them?

JOSM

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2015-04-30 01:31:09
Last Changed Author: Balaitous
Revision: 8294
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2015-04-30 00:01:40 +0200 (Thu, 30 Apr 2015)
Last Changed Rev: 8294

Identification: JOSM/1.5 (8294 pt_BR) Linux Debian GNU/Linux 8.0 (jessie)
Memory Usage: 247 MB / 10206 MB (142 MB allocated, but free)
Java version: 1.7.0_75, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u75-2.5.4-2
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Plugins:
- Create_grid_of_ways (30892)
- OpeningHoursEditor (30962)
- PicLayer (30962)
- SimplifyArea (30962)
- buildings_tools (31100)
- conflation (0.1.7)
- contourmerge (1013)
- download_along (30892)
- editgpx (30892)
- geotools (31068)
- importvec (30892)
- jts (31002)
- log4j (30892)
- measurement (30892)
- merge-overlap (30988)
- opendata (31050)
- pbf (31010)
- pdfimport (30892)
- poly (31056)
- reverter (30990)
- scripting (30710)
- todo (29154)
- turnrestrictions (31034)
- undelete (30892)
- utilsplugin2 (31072)

Attachments (2)

duplicated.osm​ (1.5 KB ) - added by naoliv 9 years ago.
duplicate2.osm​ (101.8 KB ) - added by naoliv 9 years ago.
Another example

Download all attachments as: .zip

Change History (5)

by naoliv, 9 years ago

Attachment: duplicated.osm​ added

by naoliv, 9 years ago

Attachment: duplicate2.osm​ added

Another example

comment:1 by skyper, 8 years ago

+1 to warn about relations with exact duplicate members not depending of the order.

comment:2 by Don-vip, 5 years ago

Keywords: relation member order added
Milestone: → 19.09
Owner: changed from team to Don-vip
Status: new → assigned
Summary: Better duplicated relation test → duplicated relations not detected when members order differ
Type: enhancement → defect

comment:3 by Don-vip, 5 years ago

Resolution: → fixed
Status: assigned → closed

In 15375/josm:

fix #11388 - detect duplicated relations even if members order differ

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.